From a9864f7d87a08c87775c216bf01596a7c9edff61 Mon Sep 17 00:00:00 2001
From: Daniel Barbero Martin <daniel.barbero@artica.es>
Date: Thu, 10 Jun 2021 08:45:50 +0200
Subject: [PATCH] Wip command center, clean functions db

---
 pandora_console/include/functions_treeview.php      |  7 -------
 pandora_console/operation/agentes/alerts_status.php | 13 ++-----------
 .../operation/agentes/estado_generalagente.php      |  7 -------
 pandora_console/operation/agentes/ver_agente.php    | 10 ++--------
 4 files changed, 4 insertions(+), 33 deletions(-)

diff --git a/pandora_console/include/functions_treeview.php b/pandora_console/include/functions_treeview.php
index d72abf3c33..505c56c2d1 100755
--- a/pandora_console/include/functions_treeview.php
+++ b/pandora_console/include/functions_treeview.php
@@ -511,12 +511,6 @@ function treeview_printTable($id_agente, $server_data=[], $no_head=false)
     enterprise_include_once('meta/include/functions_ui_meta.php');
     include_graphs_dependencies();
 
-    $is_extra = enterprise_hook('policies_is_agent_extra_policy', [$id_agente]);
-
-    if ($is_extra === ENTERPRISE_NOT_HOOK) {
-        $is_extra = false;
-    }
-
     $user_access_node = can_user_access_node();
 
     if (is_metaconsole()) {
@@ -550,7 +544,6 @@ function treeview_printTable($id_agente, $server_data=[], $no_head=false)
 
     if (! check_acl_one_of_groups($config['id_user'], $groups, 'AR', false)
         && ! check_acl_one_of_groups($config['id_user'], $groups, 'AW', false)
-        && !$is_extra
     ) {
         db_pandora_audit(
             'ACL Violation',
diff --git a/pandora_console/operation/agentes/alerts_status.php b/pandora_console/operation/agentes/alerts_status.php
index 54e936839a..345b1379e9 100755
--- a/pandora_console/operation/agentes/alerts_status.php
+++ b/pandora_console/operation/agentes/alerts_status.php
@@ -129,21 +129,12 @@ if ($idAgent != 0) {
 
     $id_group = agents_get_agent_group($idAgent);
 
-    $is_extra = enterprise_hook(
-        'policies_is_agent_extra_policy',
-        [$id_agente]
-    );
-
-    if ($is_extra === ENTERPRISE_NOT_HOOK) {
-        $is_extra = false;
-    }
-
-    // All groups is calculated in ver_agente.php. Avoid to calculate it again
+    // All groups is calculated in ver_agente.php. Avoid to calculate it again.
     if (!isset($all_groups)) {
         $all_groups = agents_get_all_groups_agent($idAgent, $id_group);
     }
 
-    if (!check_acl_one_of_groups($config['id_user'], $all_groups, 'AR') && !check_acl_one_of_groups($config['id_user'], $id_group, 'AW') && !$is_extra) {
+    if (!check_acl_one_of_groups($config['id_user'], $all_groups, 'AR') && !check_acl_one_of_groups($config['id_user'], $id_group, 'AW')) {
         db_pandora_audit('ACL Violation', 'Trying to access alert view');
         include 'general/noaccess.php';
         exit;
diff --git a/pandora_console/operation/agentes/estado_generalagente.php b/pandora_console/operation/agentes/estado_generalagente.php
index f2b69d5b56..b1556d93c1 100755
--- a/pandora_console/operation/agentes/estado_generalagente.php
+++ b/pandora_console/operation/agentes/estado_generalagente.php
@@ -63,15 +63,8 @@ if ($agent === false) {
     return;
 }
 
-$is_extra = enterprise_hook('policies_is_agent_extra_policy', [$id_agente]);
-
-if ($is_extra === ENTERPRISE_NOT_HOOK) {
-    $is_extra = false;
-}
-
 if (! check_acl_one_of_groups($config['id_user'], $all_groups, 'AR')
     && ! check_acl_one_of_groups($config['id_user'], $all_groups, 'AW')
-    && !$is_extra
 ) {
     db_pandora_audit(
         'ACL Violation',
diff --git a/pandora_console/operation/agentes/ver_agente.php b/pandora_console/operation/agentes/ver_agente.php
index 52083168e3..3cb9ac8a15 100644
--- a/pandora_console/operation/agentes/ver_agente.php
+++ b/pandora_console/operation/agentes/ver_agente.php
@@ -1222,15 +1222,9 @@ $agent = db_get_row('tagente', 'id_agente', $id_agente);
 // Get group for this id_agente.
 $id_grupo = $agent['id_grupo'];
 
-$is_extra = enterprise_hook('policies_is_agent_extra_policy', [$id_agente]);
-
-if ($is_extra === ENTERPRISE_NOT_HOOK) {
-    $is_extra = false;
-}
-
 $all_groups = agents_get_all_groups_agent($id_agente, $id_grupo);
 
-if (! check_acl_one_of_groups($config['id_user'], $all_groups, 'AR') && ! check_acl_one_of_groups($config['id_user'], $all_groups, 'AW', $id_agente) && !$is_extra) {
+if (! check_acl_one_of_groups($config['id_user'], $all_groups, 'AR') && ! check_acl_one_of_groups($config['id_user'], $all_groups, 'AW', $id_agente)) {
     db_pandora_audit(
         'ACL Violation',
         'Trying to access (read) to agent '.agents_get_name($id_agente)
@@ -1283,7 +1277,7 @@ $tab = get_parameter('tab', 'main');
 // Manage tab.
 $managetab = [];
 
-if (check_acl_one_of_groups($config['id_user'], $all_groups, 'AW') || $is_extra) {
+if (check_acl_one_of_groups($config['id_user'], $all_groups, 'AW')) {
     $managetab['text'] = '<a href="index.php?sec=gagente&sec2=godmode/agentes/configurar_agente&id_agente='.$id_agente.'">'.html_print_image(
         'images/setup.png',
         true,