From b16aac61f64d20106230042d2df1d65fb87d8692 Mon Sep 17 00:00:00 2001 From: slerena Date: Tue, 5 Aug 2008 11:42:08 +0000 Subject: [PATCH] 2008-08-05 Sancho Lerena * AUTHORS: Added Evi to AUTHORS file. * pandoradb.sql: MAJOR UPDATE and normalization of database structure. trecon_task table has changed from previous 2.0 version. * pandoradb_data.sql: Minimal updates. * reporting_builder.php: Fixed bug #2035570 (Two weeks instead one week in combo to select SLA period). . * manage_config_remote.php: Fixed bug #2032889: Show configurations not present in disk and fail to copy them. * manage_recontask.php: Show OS, and some stetical changes and code optimization. Removed old code for assigned network servers and so on. * manage_recontask_form.php: Removed old fields, added new fields, fixed old bugs (create incident combo). * config_inc.php: Code cleanup, updated variables. * config_process.php: Updated version info. * estado_ultimopaquete.php: Added refresh icon. * view_server.php: Added missing link to view_server_detail.php for recon servers. Somebody take it prisoner :-) * view_server_detail.php: Code stype update, and some fixes and new column information. * modificar_agente.php, configurar_agente.php: Fixed use of $id_user. * index.php: Temporal workaround to use $id_user as global. Need to fix. git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1003 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f --- pandora_console/AUTHORS | 2 +- pandora_console/ChangeLog | 38 ++ .../godmode/agentes/configurar_agente.php | 18 +- .../godmode/agentes/manage_config_remote.php | 15 +- .../godmode/agentes/modificar_agente.php | 20 +- .../godmode/reporting/reporting_builder.php | 14 +- .../godmode/servers/manage_recontask.php | 107 ++--- .../godmode/servers/manage_recontask_form.php | 60 ++- pandora_console/include/config.inc.php | 16 +- pandora_console/include/config_process.php | 10 +- pandora_console/index.php | 2 + .../agentes/estado_ultimopaquete.php | 12 +- .../operation/servers/view_server.php | 10 +- .../operation/servers/view_server_detail.php | 286 +++++++------ pandora_console/pandoradb.sql | 387 +++++++++--------- pandora_console/pandoradb_data.sql | 63 ++- pandora_console/reporting/fgraph.php | 4 +- 17 files changed, 562 insertions(+), 502 deletions(-) diff --git a/pandora_console/AUTHORS b/pandora_console/AUTHORS index b60222fd8d..aab7d5f8ed 100644 --- a/pandora_console/AUTHORS +++ b/pandora_console/AUTHORS @@ -2,8 +2,8 @@ Sancho Lerena Esteban Sanchez Jorge Gonzalez Raul Mateos -Esteban Sanchez Ramon Novoa +Evi Vanoost See full list of contributors on: diff --git a/pandora_console/ChangeLog b/pandora_console/ChangeLog index 2e6055f1cc..ca97e5f4e2 100644 --- a/pandora_console/ChangeLog +++ b/pandora_console/ChangeLog @@ -1,3 +1,36 @@ +2008-08-05 Sancho Lerena + + * AUTHORS: Added Evi to AUTHORS file. + + * pandoradb.sql: MAJOR UPDATE and normalization of database + structure. trecon_task table has changed from previous 2.0 version. + + * pandoradb_data.sql: Minimal updates. + + * reporting_builder.php: Fixed bug #2035570 (Two weeks instead one + week in combo to select SLA period). + . + * manage_config_remote.php: Fixed bug #2032889: Show configurations + not present in disk and fail to copy them. + + * manage_recontask.php: Show OS, and some stetical changes and code + optimization. Removed old code for assigned network servers and so on. + + * manage_recontask_form.php: Removed old fields, added new fields, fixed + old bugs (create incident combo). + + * config_inc.php: Code cleanup, updated variables. + + * config_process.php: Updated version info. + + * estado_ultimopaquete.php: Added refresh icon. + + * view_server.php: Added missing link to view_server_detail.php for + recon servers. Somebody take it prisoner :-) + + * view_server_detail.php: Code stype update, and some fixes and new + column information. + 2008-08-05 Esteban Sanchez * include/functions_extensions.php: Added function to call login @@ -17,6 +50,10 @@ * ChangeLog: Added comment about commit #1000. + * modificar_agente.php, configurar_agente.php: Fixed use of $id_user. + + * index.php: Temporal workaround to use $id_user as global. Need to fix. + 2008-08-04 Esteban Sanchez * index.php: Set id_user in config array when login. This fixes errors @@ -83,6 +120,7 @@ * include/help/en/help_plugin_definition.php: Language corrections. +>>>>>>> .r1002 2008-07-31 Sancho Lerena * include/help/en/help_plugin_definition.php: New help page for diff --git a/pandora_console/godmode/agentes/configurar_agente.php b/pandora_console/godmode/agentes/configurar_agente.php index 3101963c25..14ce5286b3 100644 --- a/pandora_console/godmode/agentes/configurar_agente.php +++ b/pandora_console/godmode/agentes/configurar_agente.php @@ -19,7 +19,7 @@ // Load global vars require("include/config.php"); -if (give_acl($id_user, 0, "AW")!=1) { +if (give_acl($config["id_user"], 0, "AW")!=1) { audit_db($id_usuario,$REMOTE_ADDR, "ACL Violation","Trying to access agent manager"); require ("general/noaccess.php"); exit; @@ -496,7 +496,7 @@ if ((isset($agent_created_ok)) && ($agent_created_ok == 1)){ if (isset($_GET["id_agente"])) { $id_agente = $_GET["id_agente"]; $id_grupo = dame_id_grupo($id_agente); - if (give_acl($id_user, $id_grupo, "AW")==1){ + if (give_acl($config["id_user"], $id_grupo, "AW")==1){ $sql1='SELECT * FROM tagente WHERE id_agente = '.$id_agente; $result=mysql_query($sql1); if ($row=mysql_fetch_array($result)){ @@ -523,7 +523,7 @@ if (isset($_GET["id_agente"])) { exit; } } else { - audit_db($id_user,$REMOTE_ADDR, "ACL Violation","Trying to admin an Agent out of admin groups!"); + audit_db($config["id_user"],$REMOTE_ADDR, "ACL Violation","Trying to admin an Agent out of admin groups!"); require ("general/noaccess.php"); echo ""; require ("general/footer.php"); @@ -566,8 +566,8 @@ if ((isset($_GET["update_module"])) && (!isset($_POST["oid"])) && (!isset($_POST if (isset($_GET["update_alert"])){ $id_grupo = dame_id_grupo($id_agente); - if (give_acl($id_user, $id_grupo, "LW")==0){ - audit_db($id_user,$REMOTE_ADDR, "ACL Violation","Trying to update an alert without admin rights"); + if (give_acl($config["id_user"], $id_grupo, "LW")==0){ + audit_db($config["id_user"],$REMOTE_ADDR, "ACL Violation","Trying to update an alert without admin rights"); require ("general/noaccess.php"); echo ""; require ("general/footer.php"); @@ -617,8 +617,8 @@ if ((isset($_POST["update_module"])) || (isset($_POST["insert_module"]))) { $id_agente_modulo = $_POST["id_agente_modulo"]; } $id_grupo = dame_id_grupo($id_agente); - if (give_acl($id_user, $id_grupo, "AW")==0){ - audit_db($id_user,$REMOTE_ADDR, "ACL Violation","Trying to create a module without admin rights"); + if (give_acl($config["id_user"], $id_grupo, "AW")==0){ + audit_db($config["id_user"],$REMOTE_ADDR, "ACL Violation","Trying to create a module without admin rights"); require ("general/noaccess.php"); echo ""; require ("general/footer.php"); @@ -763,8 +763,8 @@ if (((!isset($_POST["nc"]) OR ($_POST["nc"]==-1))) && (!isset($_POST["oid"])) && // ================= if (isset($_GET["delete_module"])){ // DELETE agent module ! $id_borrar_modulo = $_GET["delete_module"]; - $id_grupo = dame_id_grupo($id_agente); if (give_acl($id_user, $id_grupo, "AW")==0){ - audit_db($id_user,$REMOTE_ADDR, "ACL Violation", + $id_grupo = dame_id_grupo($id_agente); if (give_acl($config["id_user"], $id_grupo, "AW")==0){ + audit_db($config["id_user"],$REMOTE_ADDR, "ACL Violation", "Trying to delete a module without admin rights"); require ("general/noaccess.php"); exit; diff --git a/pandora_console/godmode/agentes/manage_config_remote.php b/pandora_console/godmode/agentes/manage_config_remote.php index 451ef34dc5..db5b846dc1 100644 --- a/pandora_console/godmode/agentes/manage_config_remote.php +++ b/pandora_console/godmode/agentes/manage_config_remote.php @@ -102,13 +102,20 @@ if ((isset($_GET["operacion"])) AND ($update_agent == -1) AND ($update_group == else $sql1 = 'SELECT * FROM tagente ORDER BY nombre'; echo ''; diff --git a/pandora_console/godmode/agentes/modificar_agente.php b/pandora_console/godmode/agentes/modificar_agente.php index 585ba0ec94..848ed86724 100644 --- a/pandora_console/godmode/agentes/modificar_agente.php +++ b/pandora_console/godmode/agentes/modificar_agente.php @@ -18,8 +18,8 @@ // Load global vars require("include/config.php"); -if (give_acl($id_user, 0, "AW") != 1) { - audit_db($id_user,$REMOTE_ADDR, "ACL Violation", +if (give_acl($config["id_user"], 0, "AW") != 1) { + audit_db($config["id_user"],$REMOTE_ADDR, "ACL Violation", "Trying to access Agent Management"); require ("general/noaccess.php"); exit; @@ -40,7 +40,7 @@ if (isset($_GET["borrar_agente"])){ // if delete agent $id_agente = entrada_limpia($_GET["borrar_agente"]); $agent_name = dame_nombre_agente($id_agente); $id_grupo = dame_id_grupo($id_agente); - if (give_acl($id_user, $id_grupo, "AW")==1){ + if (give_acl($config["id_user"], $id_grupo, "AW")==1){ // Firts delete from agents table $sql_delete= "DELETE FROM tagente WHERE id_agente = ".$id_agente; @@ -87,7 +87,7 @@ if (isset($_GET["borrar_agente"])){ // if delete agent } $sql = "DELETE FROM taddress_agent where id_agent = $id_agente"; $result=mysql_query($sql); - audit_db($id_user,$REMOTE_ADDR, "Agent '$agent_name' deleted", "Agent Management"); + audit_db($config["id_user"],$REMOTE_ADDR, "Agent '$agent_name' deleted", "Agent Management"); // Delete remote configuration $agent_md5 = md5($agent_name, FALSE); @@ -99,7 +99,7 @@ if (isset($_GET["borrar_agente"])){ // if delete agent unlink ($file_name); } } else { // NO permissions. - audit_db($id_user,$REMOTE_ADDR, "ACL Violation", + audit_db($config["id_user"],$REMOTE_ADDR, "ACL Violation", "Trying to delete agent '$agent_name'"); require ("general/noaccess.php"); exit; @@ -128,7 +128,7 @@ if ( $ag_group > 1 ){ ""; } echo ""; // Group all is always active -$mis_grupos = list_group ($id_user); //Print combo for groups and set an array with all groups +$mis_grupos = list_group ($config["id_user"]); //Print combo for groups and set an array with all groups echo ""; echo "