tyler.durden
/
pandorafms
mirror of https://github.com/pandorafms/pandorafms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#11149 Fix conditional when selected is string and value is integer

This commit is contained in:
miguel angel rasteu 2023-05-23 13:39:40 +02:00
parent ae7c5d8f67
commit bbd8679235
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pandora_console/include/functions_html.php
View File

@ -903,6 +903,11 @@ function html_print_select(
) { ) {
// This fixes string ($value) to int ($selected) comparisons // This fixes string ($value) to int ($selected) comparisons
$output .= ' selected="selected"'; $output .= ' selected="selected"';
} else if (is_numeric($value) && is_string($selected)) {
$str_value = strval($value);
if ($str_value === $selected) {
$output .= ' selected="selected"';
}
} else if ($value === $selected) { } else if ($value === $selected) {
// Needs type comparison otherwise if $selected = 0 and $value = "string" this would evaluate to true // Needs type comparison otherwise if $selected = 0 and $value = "string" this would evaluate to true
$output .= ' selected="selected"'; $output .= ' selected="selected"';
@ -2155,6 +2160,7 @@ function html_print_extended_select_for_time(
} }
ob_start(); ob_start();
hd($fields, true);
// Use the no_meta parameter because this image is only in the base console. // Use the no_meta parameter because this image is only in the base console.
echo '<div id="'.$uniq_name.'_default" class="wauto inline_flex">'; echo '<div id="'.$uniq_name.'_default" class="wauto inline_flex">';
html_print_select( html_print_select(