diff --git a/pandora_console/godmode/agentes/agent_wizard.wmi_explorer.php b/pandora_console/godmode/agentes/agent_wizard.wmi_explorer.php
index 47a5cc5a35..5d889178bb 100644
--- a/pandora_console/godmode/agentes/agent_wizard.wmi_explorer.php
+++ b/pandora_console/godmode/agentes/agent_wizard.wmi_explorer.php
@@ -1,16 +1,18 @@
$row) {
- // First and second rows are Class and column names, ignore it
+ // First and second rows are Class and column names, ignore it.
if ($index < 2) {
continue;
}
@@ -81,60 +89,74 @@ if ($wmiexplore) {
$row_exploded = explode('|', $row);
if (!in_array($row_exploded[$processes_name_field], $processes)) {
- $processes[$row_exploded[$processes_name_field]] = $row_exploded[$processes_name_field];
+ if (preg_match('/ERROR/', $row_exploded[$processes_name_field])) {
+ $processes[$row_exploded[$prouycesses_name_field]] = __('None');
+ } else {
+ $processes[$row_exploded[$prouycesses_name_field]] = $row_exploded[$processes_name_field];
+ }
}
}
unset($output);
- // Services
+ // Services.
$wmi_services = $wmi_command.' "select Name from Win32_Service"';
$services_name_field = 0;
$services_check_field = 1;
- if (enterprise_installed()) {
- if ($server_to_exec != 0) {
- $server_data = db_get_row('tserver', 'id_server', $server_to_exec);
- exec('ssh pandora_exec_proxy@'.$server_data['ip_address']." '".$wmi_services."'", $output, $rc);
- } else {
- exec($wmi_services, $output);
- }
+ if (enterprise_installed() && (int) $server_to_exec != 0) {
+ $server_data = db_get_row(
+ 'tserver',
+ 'id_server',
+ $server_to_exec
+ );
+ exec(
+ 'ssh pandora_exec_proxy@'.$server_data['ip_address']."
+ '".$wmi_services."'",
+ $output,
+ $rc
+ );
} else {
exec($wmi_services, $output);
}
foreach ($output as $index => $row) {
- // First and second rows are Class and column names, ignore it
+ // First and second rows are Class and column names, ignore it.
if ($index < 2) {
continue;
}
- $row_exploded = explode('|', $row);
+ $row_exploded = explode('|', $row);
if (!in_array($row_exploded[$services_name_field], $services)) {
- $services[$row_exploded[$services_name_field]] = $row_exploded[$services_name_field];
+ if (preg_match('/ERROR/', $row_exploded[$services_name_field])) {
+ $services[$row_exploded[$services_name_field]] = __('None');
+ } else {
+ $services[$row_exploded[$services_name_field]] = $row_exploded[$services_name_field];
+ }
}
}
unset($output);
- // Disks
+ // Disks.
$wmi_disks = $wmi_command.' "Select DeviceID from Win32_LogicalDisk"';
$disks_name_field = 0;
- if (enterprise_installed()) {
- if ($server_to_exec != 0) {
- $server_data = db_get_row('tserver', 'id_server', $server_to_exec);
- exec('ssh pandora_exec_proxy@'.$server_data['ip_address']." '".$wmi_disks."'", $output, $rc);
- } else {
- exec($wmi_disks, $output);
- }
+ if (enterprise_installed() && (int) $server_to_exec != 0) {
+ $server_data = db_get_row('tserver', 'id_server', $server_to_exec);
+ exec(
+ 'ssh pandora_exec_proxy@'.$server_data['ip_address']."
+ '".$wmi_disks."'",
+ $output,
+ $rc
+ );
} else {
exec($wmi_disks, $output);
}
foreach ($output as $index => $row) {
- // First and second rows are Class and column names, ignore it
+ // First and second rows are Class and column names, ignore it.
if ($index < 2) {
continue;
}
@@ -142,14 +164,21 @@ if ($wmiexplore) {
$row_exploded = explode('|', $row);
if (!in_array($row_exploded[$disks_name_field], $services)) {
- $disk_string = sprintf(__('Free space on %s'), $row_exploded[$disks_name_field]);
- $disks[$row_exploded[$disks_name_field]] = $disk_string;
+ if (preg_match('/ERROR/', $row_exploded[$disks_name_field])) {
+ $disks[$row_exploded[$disks_name_field]] = __('None');
+ } else {
+ $disk_string = sprintf(
+ __('Free space on %s'),
+ $row_exploded[$disks_name_field]
+ );
+ $disks[$row_exploded[$disks_name_field]] = $disk_string;
+ }
}
}
unset($output);
- // WMI Components
+ // WMI Components.
$network_component_groups = network_components_get_groups(MODULE_WMI);
}
}
@@ -163,14 +192,14 @@ if ($create_modules) {
$components = [];
foreach ($modules as $module) {
- // Split module data to get type
+ // Split module data to get type.
$module_exploded = explode('_', $module);
$type = $module_exploded[0];
- // Delete type from module data
+ // Delete type from module data.
unset($module_exploded[0]);
- // Rebuild module data
+ // Rebuild module data.
$module = implode('_', $module_exploded);
switch ($type) {
@@ -189,10 +218,14 @@ if ($create_modules) {
case 'component':
$components[] = $module;
break;
+
+ default:
+ // Default.
+ break;
}
}
- // Common values for WMI modules
+ // Common values for WMI modules.
$values = [
'ip_target' => $ip_target,
'tcp_send' => $tcp_send,
@@ -202,7 +235,10 @@ if ($create_modules) {
];
if ($server_to_exec != 0) {
- $sql = sprintf('SELECT server_type FROM tserver WHERE id_server = %d', $server_to_exec);
+ $sql = sprintf(
+ 'SELECT server_type FROM tserver WHERE id_server = %d',
+ $server_to_exec
+ );
$row = db_get_row_sql($sql);
if ($row['server_type'] == 13) {
@@ -210,89 +246,146 @@ if ($create_modules) {
}
}
- // Create Service modules
+ // Create Service modules.
$services_values = $values;
$services_values['snmp_community'] = 'Running';
- // Key string
+ // Key string.
$services_values['tcp_port'] = 1;
- // Field number (Running/Stopped)
+ // Field number (Running/Stopped).
$services_values['id_tipo_modulo'] = 2;
- // Generic boolean
- $services_result = wmi_create_wizard_modules($id_agent, $services, 'services', $services_values, 0, 0, $server_to_exec);
+ // Generic boolean.
+ $services_result = wmi_create_wizard_modules(
+ $id_agent,
+ $services,
+ 'services',
+ $services_values,
+ 0,
+ 0,
+ $server_to_exec
+ );
- // Create Process modules
+ // Create Process modules.
$processes_values = $values;
$processes_values['tcp_port'] = 0;
- // Field number (OID)
+ // Field number (OID).
$processes_values['id_tipo_modulo'] = 2;
- // Generic boolean
- $processes_result = wmi_create_wizard_modules($id_agent, $processes, 'processes', $processes_values, 0, 0, $server_to_exec);
+ // Generic boolean.
+ $processes_result = wmi_create_wizard_modules(
+ $id_agent,
+ $processes,
+ 'processes',
+ $processes_values,
+ 0,
+ 0,
+ $server_to_exec
+ );
- // Create Space on disk modules
+ // Create Space on disk modules.
$disks_values = $values;
$disks_values['tcp_port'] = 1;
- // Free space in bytes
+ // Free space in bytes.
$disks_values['id_tipo_modulo'] = 1;
- // Generic numeric
+ // Generic numeric.
$disks_values['unit'] = 'Bytes';
- // Unit
- $disks_result = wmi_create_wizard_modules($id_agent, $disks, 'disks', $disks_values, 0, 0, $server_to_exec);
+ // Unit.
+ $disks_result = wmi_create_wizard_modules(
+ $id_agent,
+ $disks,
+ 'disks',
+ $disks_values,
+ 0,
+ 0,
+ $server_to_exec
+ );
- // Create modules from component
+ // Create modules from component.
$components_values = $values;
$components_values['id_agente'] = $id_agent;
- $components_result = wmi_create_module_from_components($components, $components_values, 0, 0, $server_to_exec);
+ $components_result = wmi_create_module_from_components(
+ $components,
+ $components_values,
+ 0,
+ 0,
+ $server_to_exec
+ );
- // Errors/Success messages
+ // Errors/Success messages.
$success_message = '';
$error_message = '';
if (!empty($services_result)) {
if (count($services_result[NOERR]) > 0) {
- $success_message .= sprintf(__('%s service modules created succesfully'), count($services_result[NOERR])).'
';
+ $success_message .= sprintf(
+ __('%s service modules created succesfully'),
+ count($services_result[NOERR])
+ ).'
';
}
if (count($services_result[ERR_GENERIC]) > 0) {
- $error_message .= sprintf(__('Error creating %s service modules'), count($services_result[ERR_GENERIC])).'
';
+ $error_message .= sprintf(
+ __('Error creating %s service modules'),
+ count($services_result[ERR_GENERIC])
+ ).'
';
}
}
if (!empty($processes_result)) {
if (count($processes_result[NOERR]) > 0) {
- $success_message .= sprintf(__('%s process modules created succesfully'), count($processes_result[NOERR])).'
';
+ $success_message .= sprintf(
+ __('%s process modules created succesfully'),
+ count($processes_result[NOERR])
+ ).'
';
}
if (count($processes_result[ERR_GENERIC]) > 0) {
- $error_message .= sprintf(__('Error creating %s process modules'), count($processes_result[ERR_GENERIC])).'
';
+ $error_message .= sprintf(
+ __('Error creating %s process modules'),
+ count($processes_result[ERR_GENERIC])
+ ).'
';
}
}
if (!empty($disks_result)) {
if (count($disks_result[NOERR]) > 0) {
- $success_message .= sprintf(__('%s disk space modules created succesfully'), count($disks_result[NOERR])).'
';
+ $success_message .= sprintf(
+ __('%s disk space modules created succesfully'),
+ count($disks_result[NOERR])
+ ).'
';
}
if (count($disks_result[ERR_GENERIC]) > 0) {
- $error_message .= sprintf(__('Error creating %s disk space modules'), count($disks_result[ERR_GENERIC])).'
';
+ $error_message .= sprintf(
+ __('Error creating %s disk space modules'),
+ count($disks_result[ERR_GENERIC])
+ ).'
';
}
}
if (!empty($components_result)) {
if (count($components_result[NOERR]) > 0) {
- $success_message .= sprintf(__('%s modules created from components succesfully'), count($components_result[NOERR])).'
';
+ $success_message .= sprintf(
+ __('%s modules created from components succesfully'),
+ count($components_result[NOERR])
+ ).'
';
}
if (count($components_result[ERR_GENERIC]) > 0) {
- $error_message .= sprintf(__('Error creating %s modules from components'), count($components_result[ERR_GENERIC])).'
';
+ $error_message .= sprintf(
+ __('Error creating %s modules from components'),
+ count($components_result[ERR_GENERIC])
+ ).'
';
}
if (count($components_result[ERR_EXIST]) > 0) {
- $error_message .= sprintf(__('%s modules already exist'), count($components_result[ERR_EXIST])).'
';
+ $error_message .= sprintf(
+ __('%s modules already exist'),
+ count($components_result[ERR_EXIST])
+ ).'
';
}
}
@@ -306,7 +399,9 @@ if ($create_modules) {
}
echo ' ';
-echo "