tyler.durden
/
pandorafms
mirror of https://github.com/pandorafms/pandorafms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not displayed advanced filters if custom filters are disabled. Small 

fixes.
This commit is contained in:
Ramon Novoa 2015-04-15 12:31:31 +02:00
parent bf6e9cf4f6
commit f8a2fbfbf9
2 changed files with 30 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pandora_console/include/functions_netflow.php
View File

@ -1103,6 +1103,12 @@ function netflow_draw_item ($start_date, $end_date, $interval_length, $type, $fi
$aggregate = $filter['aggregate']; $aggregate = $filter['aggregate'];
$unit = $filter['output']; $unit = $filter['output'];
$interval = $end_date - $start_date; $interval = $end_date - $start_date;
if (defined ('METACONSOLE')) {
$width = 950;
} else {
$width = 850;
}
$height = 320;
// Process item // Process item
switch ($type) { switch ($type) {
@ -1119,7 +1125,8 @@ function netflow_draw_item ($start_date, $end_date, $interval_length, $type, $fi
if ($interval_length != 0) { if ($interval_length != 0) {
$html .= "&nbsp;<b>" . _('Resolution') . ":</b> $interval_length " . __('seconds'); $html .= "&nbsp;<b>" . _('Resolution') . ":</b> $interval_length " . __('seconds');
} }
$html .= graph_netflow_aggregate_area ($data, $interval, 850, 320, netflow_format_unit ($unit));
$html .= graph_netflow_aggregate_area ($data, $interval, $width, $height, netflow_format_unit ($unit));
return $html; return $html;
} }
else if ($output == 'PDF') { else if ($output == 'PDF') {
@ -1128,7 +1135,7 @@ function netflow_draw_item ($start_date, $end_date, $interval_length, $type, $fi
if ($interval_length != 0) { if ($interval_length != 0) {
$html .= "&nbsp;<b>" . _('Resolution') . ":</b> $interval_length " . __('seconds'); $html .= "&nbsp;<b>" . _('Resolution') . ":</b> $interval_length " . __('seconds');
} }
$html .= graph_netflow_aggregate_area ($data, $interval, 850, 320, netflow_format_unit ($unit), 2, true); $html .= graph_netflow_aggregate_area ($data, $interval, $width, $height, netflow_format_unit ($unit), 2, true);
return $html; return $html;
} }
else if ($output == 'XML') { else if ($output == 'XML') {

25
pandora_console/operation/netflow/nf_live_view.php
View File

@ -90,6 +90,7 @@ $time = get_parameter_post ('time', date (TIME_FORMAT, get_system_time ()));
$connection_name = get_parameter('connection_name', ''); $connection_name = get_parameter('connection_name', '');
$interval_length = (int) get_parameter('interval_length', 300); $interval_length = (int) get_parameter('interval_length', 300);
$address_resolution = (int) get_parameter('address_resolution', $config['netflow_get_ip_hostname']); $address_resolution = (int) get_parameter('address_resolution', $config['netflow_get_ip_hostname']);
$filter_selected = (int) get_parameter('filter_selected', 0);
// Read buttons // Read buttons
$draw = get_parameter('draw_button', ''); $draw = get_parameter('draw_button', '');
@ -301,8 +302,9 @@ echo '<form method="post" action="' . $config['homeurl'] . 'index.php?sec=netf&s
$sql = "SELECT * $sql = "SELECT *
FROM tnetflow_filter FROM tnetflow_filter
WHERE id_group IN (".implode(',', array_keys ($user_groups)).")"; WHERE id_group IN (".implode(',', array_keys ($user_groups)).")";
echo "<td colspan='3'>" . html_print_select_from_sql ($sql, 'filter_id', $filter_id, '', __('none'), 0, true) . "</td>"; echo "<td colspan='3'>" . html_print_select_from_sql ($sql, 'filter_id', $filter_id, '', __('Select a filter'), 0, true);
html_print_input_hidden("filter_selected", $filter_selected, false);
echo "</td>";
echo "</tr>"; echo "</tr>";
@ -351,8 +353,13 @@ echo '<form method="post" action="' . $config['homeurl'] . 'index.php?sec=netf&s
echo "</tr>"; echo "</tr>";
echo "<tr class='filter_advance' style='display: none;'>"; echo "<tr class='filter_advance' style='display: none;'>";
echo "<td>" . ui_print_help_icon ('pcap_filter', true, ui_get_full_url(false, false, false, false)) . "</td>"; if ($netflow_disable_custom_lvfilters) {
echo "<td colspan='5'>" . html_print_textarea ('advanced_filter', 4, 40, $filter['advanced_filter'], "style='min-height: 0px; width: 90%;'", true) . "</td>"; echo "<td></td>";
echo "<td></td>";
} else {
echo "<td>" . ui_print_help_icon ('pcap_filter', true, ui_get_full_url(false, false, false, false)) . "</td>";
echo "<td colspan='5'>" . html_print_textarea ('advanced_filter', 4, 40, $filter['advanced_filter'], "style='min-height: 0px; width: 90%;'", true) . "</td>";
}
echo "</tr>"; echo "</tr>";
echo "<tr>"; echo "<tr>";
@ -395,9 +402,17 @@ echo'</form>';
if ($draw != '') { if ($draw != '') {
// Draw // Draw
echo "<br/>"; echo "<br/>";
// No filter selected
if ($netflow_disable_custom_lvfilters && $filter_selected == 0) {
ui_print_error_message(__('No filter selected'));
}
// Draw the netflow chart
else {
echo netflow_draw_item ($start_date, $end_date, echo netflow_draw_item ($start_date, $end_date,
$interval_length, $chart_type, $filter, $interval_length, $chart_type, $filter,
$max_aggregates, $connection_name, 'HTML', $address_resolution); $max_aggregates, $connection_name, 'HTML', $address_resolution);
}
} }
enterprise_hook('close_meta_frame'); enterprise_hook('close_meta_frame');
@ -466,6 +481,7 @@ ui_include_time_picker();
// Check right filter type // Check right filter type
$("#radiobtn0001").attr("checked", "checked"); $("#radiobtn0001").attr("checked", "checked");
$("#hidden-filter_selected").val(0);
$("#text-ip_dst").val(''); $("#text-ip_dst").val('');
$("#text-ip_src").val(''); $("#text-ip_src").val('');
$("#text-dst_port").val(''); $("#text-dst_port").val('');
@ -480,6 +496,7 @@ ui_include_time_picker();
} }
else { else {
// Load fields from DB // Load fields from DB
$("#hidden-filter_selected").val(1);
// Get filter type // Get filter type
<?php <?php