* general/header.php: Added alt tags to images
* include/functions_db.php: Fixed get_agent_modules function
* include/functions_html.php: Fixed print_image and print_table to conform
to standards
* index.php: Removed extra closing div that shouldn't be there and conform
to standards
* godmode/agentes/alert_manager.php: Fixed JavaScript messyness for XHTML
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1430 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* general/links_menu.php: Added classes to links. Style correction.
* general/main_menu.php: Fixed an error when the selected option was
the last one in a submenu.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1426 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* general/main_menu.php: The menu has been rewritten to be more
usable, bright and colorful. It's similar to Wordpress administration
menu. It requires a bit of javascript, but can still works without it.
Besides, Pandora can remember the menus positions using cookies.
* include/javascript/jquery.pandora.js: Added javascript code for
menu handling. Added cookie plugin.
* include/styles/menu.css: Rewritten to be adapted to new menu system.
* include/styles/images/toggle.gif: Added to repository.
* include/styles/pandora.css: Set align-top to agent list table under
Manage agents.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1423 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* general/login_page.php: Removed width of login error.
* godmode/agentes/agent_manager.php,
godmode/agentes/configurar_agente.php: Fixed various errors when
creating an agent.
* godmode/agentes/alert_manager.php: Typo error on em closing element.
Use invisible class instead of style attribute.
* godmode/agentes/modificar_agente.php: Style correction. Improved a
bit the interface so the user can go directly to any tab. Fixed agent
creation parameter.
* pandoradb.sql: Make disabled field on tagente_modulo not null. It
could cause some server side errors.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1422 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandoradb_migrate_20_to_21.sql, pandoradb.sql: Added user table updates
You'll have to do the alter tables before upgrading to the latest version
but it adds functionality and enforces unique usernames
* general/header.php: Don't rely on session variables
* include/auth/dev.php, include/functions_ui.php: Minimal changes to
comply with guidelines and new links
* include/auth/mysql.php, include/auth/ldap.php: Added functions and
removed bugs.
* include/functions_db.php: Added some functions for profile handling
* include/functions_html.php: Text input is now readonly instead of
disabled. This allows copying data from the textbox.
* include/styles/tip.css: Set min-width instead of fixed width for tip
that way we can have bigger tips without overflowing
* operation/reporting/reporting_xml.php: Added auth there as well
* operation/users/user.php, operation/users/user_edit.php,
operation/users/user_statistics.php: New auth functions, better look
* index.php: Process_user_contact sits in logon_db. Saves a query
* godmode/users/configure_user.php, godmode/users/user_list.php: New
auth functions, better look.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1390 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* install.php: Added ldap module dep.
* include/functions_reporting.php, operation/agentes/status_monitor.php
operation/agentes/tactical.php, general/logon_ok.php: New filter options for
warning/critical, removed old data stats and improved filters in module view
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1369 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandoradb.sql: Added new field to talert_templates to specify if the
alert should fire when on match or mismatch of the values.
* general/header.php: Fixed the columns width. Added a control when
the autorefresh is clicked so the user can select the refresh time. A
countdown is also shown when the page is set to refresh.
* godmode/alerts/configure_alert_template.php: Control the new flag on
templates. Added an explanation to explain when the alert is going to
fire.
* include/javascript/jquery.js: Updated to v1.3. It promise to be
quicker in a lot of situations.
* include/javascript/jquery.countdown.js: Updated to latest version.
* include/styles/pandora.css: Fixed duplicated input.ok. Style
correction. Added invisible class and a style for alert templates
page.
* include/functions_alerts.php: Fixed a notice error on
clean_alert_template_values().
* operation/visual_console/render_view.php: Removed jquery inclusion
because it's already done in the index page.
* general/main_menu.php: Do not add refr if it's zero.
* index.php: Avoid the recursive addition of 1=1 when autorefresh is
set.
* pandoradb_migrate_20_to_21.sql: Added new fields on the tables.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1350 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* operation/servers/view_server_detail.php: Fixed missing parameter.
Probably because function interface change.
* pandoradb_migrate_20_to_21.sql: Added some ALTER table sentences
was missing.
* general/login_page.php: Fixed typo.
* godmode/menu.php: Bad page rendered for module manage. Fixed.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1343 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* general/footer.php, operation/agentes/sla_view.php,
operation/agentes/estado_ultimopaquete.php: Replaced time
function with get_system_time
* operation/reporting/reporting_viewer.php,
operation/reporting/reporting_xml.php, reporting/stat_win.php,
godmode/agentes/configurar_agente.php: Function renaming
* include/functions_reporting.php, include/functions_db.php,
operation/agentes/exportdata.php,
operation/agentes/estado_generalagente.php, reporting/fgraph.php,
godmode/db/db_info.php, godmode/db/db_purge.php,
godmode/agentes/modificar_agente.php: Made tagente_datos.id_agente
redundant by using the internal functions and separate queries.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1324 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* general/footer.php: Made image link relative. It wasn't working for me.
* include/functions.php, include/functions_exportserver.php,
include/functions_incidents.php, include/functions_visual_map.php,
include/functions_db.php, include/functions_extensions.php,
include/functions_reporting.php, include/functions_events.php,
include/functions_html.php, include/functions_ui.php:
Updated documentation to adhere to PHPDoc and parses without errors
* include/functions.php: Removed unsafe_string function (magic_quotes)
Made pagination possible to return instead of print
* include/functions_db.php: Removed give_modulecategory_name
(Module types etc. are now in database). Was unused.
* reporting/fgraph.php: Removed unsafe_string usage
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1323 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* include/functions_ui.php: Added to repository. Functions that prints
UI elements for Pandora. Let's make functions_html.php a single HTML
library instead of mixing it up with Pandora specific elements.
* include/functions.php: Fixed inline doc. Added functions_ui.php.
* include/functions_html.php: Functions moved to functions_ui.php.
Fixed checkbox ids in print_checkbox_extended().
* general/main_menu.php: Make refr attribute optional. Do not print
class attribut tag if no class was given.
* general/login_page.php: Show login error message if login fails.
Put POST values into the form instead of the URL.
* index.php: Cleaned up login code to become easier.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1319 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* index.php: Cleaned up some old stuff and fixed the order of GET/POST
* general/header.php: Added tags for custom branding and todo
* general/login_page.php: Cleaned up some old stuff and fixed always
redirecting the user to the overview if they followed a link.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1306 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* general/footer.php: Updated print_timestamp to always print full.
Removed the center tag (deprecated in HTML 4.01)
* general/header.php: Fixed some CSS.
* general/links_menu.php: Rewritten for new css style
* general/main_menu.php: Rewritten for new css style and to avoid
repetition in writing tags uses an array and functions
* godmode/menu.php: Rewritten for new css style and to avoid repetition
writing tags
* include/functions_html.php: Added option to override prominent time
* include/styles/link.css: Rewritten the whole CSS. Now all menu options
are directly available through slide-outs (pure CSS, no JS) and avoids div
for each single item. The pages renders quite a bit faster too.
* include/styles/pandora.css: Fixed some bad tags and removed stuff that
was for the rewritten menu.
* index.php: Added to div. IE will in some situations not render
empty divs.
* operation/menu.php: Rewritten for new CSS style
* include/styles/god.css, include/styles/op.css:
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1297 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandoradb_data.sql, pandoradb.sql: removed extra '-' which made the
file invalid for mysql population.
* include/languages/es.po, include/languages/es.mo: Updated Spanish
translation.
* include/languages/index.pot: Updated po template.
* general/footer.php: changed format_datetime to print_timestamp.
* godmode/setup/setup.php: moved the enterprise hook so the table
fields show properly in both versions.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1296 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* general/logon_ok.php, godmode/agentes/modificar_agente.php,
godmode/agentes/planned_downtime.php,
godmode/agentes/manage_recontask.php, godmode/setup/news.php,
operation/agentes/datos_agente.php, operation/agentes/estado_agente.php,
operation/agentes/status_events.php, operation/agentes/tactical.php,
operation/events/events.php, operation/incidents/incidents.php,
operation/incidents/incident_detail.php, operation/messages/message.php:
Function updates and new function definitions
* include/functions.php: safe_input used utf_decode which gives problems
with foreign chars since everything else is (or should be UTF-8) fixed.
format_datetime is no longer necessary - use print_timestamp for output.
Extended multibyte wrapper functions.
* include/functions_db.php: give_server_name is now get_server_name;
dame_so_name is now get_os_name; dame_so_icon is now print_os_icon;
show_icon_group is now print_group_icon; give_network_profile_name is now
get_networkprofile_name; smal_event_table is now print_events_table
* include/functions_events.php: print_events_table was moved here and
fixed. Now calculates the cutoff of event and agent text.
* include/functions_html.php: Added title to print_table function and
updated documentation. print_timestamp now uses the new function
definitions (array) and handles 0-dates better. print_group_icon and
print_os_icon added and extended. Added print_agent_name. This function
fixes issues that show up when cutting off agent names with multibyte char
* operation/servers/view_server.php: Rewrite with new functions
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1295 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* operation/servers/view_server.php: Small language fix
* operation/agentes/tactical.php: Rewrite using new functions and
cleaner html. More understandable and outsourced calculations to
get_group_stats
* include/styles/pandora.css: Clean up CSS deprecated in other files
* include/javascript/pandora.js: Noticed a small style difference
* include/help/en/help_serverlag.php: Hopefully this makes server lag
somewhat more understandable (I didn't know what it was)
* include/functions_reporting.php: Renamed general_stats to
get_group_stats and made it accept arrays. Also added ACL check and
an easier output format. All calculations are now done here.
* include/functions_html.php: print_table would always reset
cellpaddings and cellspacing from 0 to 4. Fixed it
* include/functions_db.php: Deprecated server_status for
get_server_info. Added get_server_info which accepts single values or
arrays of servers to be checked.
* include/functions.php: Removed clean_output_breaks. Use built-in
function nl2br() for that instead. They're faster and cross-platform
* general/logon_ok.php: Same as tactical.php (both had to be updated)
* ChangeLog: Somebody started using spaces instead of tabs?
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1241 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* images/firefox.png: Moved from .gif to .png. WE SHOLDN'T USE .gif FILES!
* general/footer.php: Added year header. Changed image link to .png
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1144 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* ajax.php: removed carriage return from EOF.
* index.php: Updated final version variable (YES!)
* config_process: Updated final version variable (YES!)
* libupdate_manager_client.php: Do not raise a notice (probably be hidden
for user). Show error details with a simple echo.
* footer.php: Bad reference to image, in help don't show properly fixed.
* pandora_help.php: Fancy layout :)
* manage_config.php: Now works fine. If target agents not defined used
source agent. Module mass delete now works. Added help and better deletion
of agents. Fixed bug #2157135.
* pandora_textlogo.png: Added new icon for help header.
* functions_db.php: Added delete_agent() used in manage_config.
* help_alert_validation.php, help_manageconfig.php, help_planned_downtime.php:
New help files (english only!).
* datos_agente.php: Stupid bug that don't allow to delete string data.
* estado_alertas.php: Added help to alert ACK button.
* reporting_viewer.php: Added SLA legend label (limit) and fixed render of
invalid SLA (was swapped bad for good). Combined graphs dimensions are used
now on reports.
* reporting_xml.php:; Fixed a small problem that renders header after contents.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1139 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* include/functions_db.php: Fixed a small bug in get_db_value and fixed
check_server_status () to return an int at all times
* general/header.php: Removed my old table code. Fixed bug #2119102.
* ChangeLog: Made Jorge's entry use tab instead of spaces
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1112 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* reporting/fgraph.php: URL passed should don't get slashes or
don't work, used unsafe_string() to remove it.
* datos_agente.php: was not showing async string data. Now it
uses a regexp to search for string types.
* logon_ok.php: Was using a wrong variable on message counter.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1079 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* include/functions.php: Style correction.
* general/footer.php: Fixed link to Firefox and make it
translatable.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1070 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* functions.php: Added function to clean SQL string.
* setup/news.php: Fixed problem adding new news.
* setup/link.php: Added mysql recheck to input var.
* login_page.php: Removed "Welcome", added a blank line before title.
* logon_failed.php: Was rending bad in IE.
* footer.php: Added Firefox button and tooltip about best view in Firefox.
* header.php: Old rendering was crazy in IE. New code to set render exactly
equal on IE and Firefox. PLEASE DO NOT USE TABULAR phpp functions here, this is
pure HTML formatting.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1069 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandora_logo.png: White background for IE6 users.
* index.php: Updated version and develop bypass.
* header.php, pandora.css: Better view in IE6.
* estado_ultimopaquete.php: Fixes bad render for big numbers.
* snmp_view.php: Fixes problems with IE6 render. Better view
of custom OID (shortened and as tooltip).
* stat_win.php: Fixed problem with slicer in IE6.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1053 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandoradb_data.sql: Removed data for locale, added for new
date string format.
* include/functions_html.php: Deletion of table properties
after calling it makes a bad render on several pages that uses
some properties for other things (width).
* include/functions_reporting.php: Added several checks to avoid
notices.
* include/config_process.php: Removed locale code. Added code for
new datetime string format.
* include/locale.class.php: Removed.
* include/functions.php: pandora_help() was not returning correct output.
Added format_datetime() function to render date / time strings in user
defined format.
* include/functions_db.php: Added check in get_monitors_down() to avoid
notice in void foreach.
* operation/incidents/incident_detail.php: Solved problem with attachments.
* operation/users/user.php: Solved problem with old help_lang[] array.
* operation/messages/message.php: Sime minor fixes and style improvements.
* operation/servers/view_server.php: Remove description.
* operation/servers/view_server_detail.php: Removed bad field retrieval
from database and added format_datetime().
* reporting/fgraph.php: Fixed small problem in monitors_health_pipe().
(changed parameters).
* general/footer.php: Updated use of new functions.
* general/header.php: Added blank spaces between icons and texts.
* godmode/setup/setup.php: Management of new string format for datetime.
* godmode/profiles/profile_list.php: Submit button now uses div instead
tables.
* godmode/reporting/reporting_builder.php: Added check before foreach() to
avoid notice warnings. Changed div for buttons.
* godmode/reporting/map_builder.php: Fixed div for submit button.
* godmode/servers/modificar_server.php: Fixed typo in SQL sentence.
Removed usage of not-used-now locale format functions. Alter legend to use
a plain-formatted table to avoid background color in legend.
* /en/help_date_format.php: Added help for date format string.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1023 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* index.php: Update HTML for unclosed tags and put everything in PHP
Updated the HTTPS detection. Made sure the password doesn't get
passed to other scripts (like 'evil' plugins)
* include/functions_html.php: Added print_input_password_extended()
* general/main_menu.php: Removed old code and header
* general/login_page.php: Tried putting it in functions_html code but
that didn't work (rowspan), so I just ended up with a smaller file and
the input boxes getting printed
* general/header.php: Updated to use functions_html
* general/footer.php: Updated header and develop_bypass for the query
counter
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1020 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* include/locale.class.php: Locale class for number, time and money
formatting. Latest version, much corrections.
* include/functions_db.php: HTML corrections (close tags)
* include/config_process.php: Process $config['locale'] and init LOCALE
class. Still needs to be implemented in a "userspace" function
* general/footer.php: Updated footer to use locale class (not function)
to display the date and number. Just an example of the possibility
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1011 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* index.php: Set id_user in config array when login. This fixes errors
and notices on login screen.
* operation/menu.php: Replaced use of id_user on SESSION array with
config.
* general/logon_ok.php: Replaced lang_label with lang_string(). Use
id_user on config array. Style correction and code cleanup.
* godmode/extensions.php: It was showing main functions of extensions
instead of godmode ones.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@1000 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* include/help/en/help_plugin_definition.php: New help page for
plugin register section.
* include/javascript/pandora.js: Help window now shows scrollbar.
* general/pandora_help.php: Better layout for help system.
* godmode/servers/plugin.php: Fixed position / menu issues and other
menor bugs in plugin editor.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@993 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandoradb.sql: Some changes in structure for new export server. Removed
and extra comma in tplanned_downtime.
* pandoradb_data.sql: Deleted some stuff from Gigabit module templates,
too much.
* logon_ok.php: Header update.
* menu.php: Plugin editor moved under server section.
* modificar_agente.php: Added icon to agent config editor from manage
agents view.
* links.php: Some code cleanup.
* pandora.ico: New .ICO file for web, this will be official one for
2.0 version.
* functions_db.php: Fixed a problem in audit_db() where parameters
was not properly cleaned and with ' chars this makes an SQL error.
Fixed BUG #2032885, in function get_monitors_in_agent () where a
bad SQL forced an error in report.
* estado_agente.php, estado_generalagente.php: Added link to group
view from group icon.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@988 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandoradb.sql: Updated schema for tplanned_downtime
* include/functions_db.php: Small bug that gave a warning in case there were no events for an agent
* godmode/agentes/planned_downtime.php: You can now create planned downtime schedules. This
won't work yet as the server doesn't support it yet. So I didn't integrate it in the menu either, but it can be.
* general/links_menu.php: The first link will also show up. It wasn't showing up because the mysql function
that was used moved the internal pointer ahead while checking if it existed. Used new functions.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@987 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* functions_db.php: Style changes, updated process_sql so it can return other
interesting stuff on INSERT. No functions have direct mysql functions anymore
* logon_ok.php: Style changes. Made it use the DB functions
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@981 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandora_console/general/logon_ok.php: Fixed bug, the latest update failed in the middle (SourceForge SVN problems) and didn't include this file.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@963 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandora_console/general/logon_ok.php: Made the query use sprintf (for security purposes)
* pandora_console/include/functions_db.php: Made all the database queries relying on a single query function for simpler management
Also made sure that no functions returned NULL because NULL is a valid database value. It will return an empty value or something
Also made a simple query cache array so that duplicate queries to generate a single page won't be repeated (ACL queries)
Also updated some other queries and functions (see the diff) and removed some old code
* pandora_console/estado_grupo.php: Now with working agents counter!
* pandora_console/general/footer.php: Just made a fancy counter that displays how much queries weren't duplicated (90 on some pages!!)
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@953 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* pandora_console/operation/agentes/networkmap.php: Some minor bugfixes introduced with my changes yesterday
* pandora_console/general/links_menu.php: 2 queries for a menu? Changed it to a single query. This list will likely never be empty - if it is, Links section won't be generated
* pandora_console/general/logon_ok.php: Updated the queries to go faster. Changed the timestamp calculation to an indexed query using utimestamp and UNIXTIME(NOW())-604800
* pandora_console/images/networkmap/8.png: Added the Mac OS X icon.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@952 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
* include/styles/pandora_red.css: Updated.
* include/styles/pandora_black.css: New style with BLACK blackground.
* include/styles/pandora.css: Updated.
* include/functions_db.php: Added auto order combos and queries.
* include/functions_visual_map.php: Added overlap on down elements if
there are more than one in the same position (This could allow to cluster
elements to shown the down status first). Removed unused code.
* operation/events/events.php: Added tooltip for group name.
* operation/visual_console/render_view.php: Adjusted controls position.
* operation/agentes/status_monitor.php: Added status for unknown monitors.
Added some database search improvement.
* operation/agentes/sla_view.php: Sorted list of items.
* operation/agentes/ver_agente.php: Updated AJAX code for network map
detail view of an agent. Added alert data.
* operation/agentes/tactical.php: Removed 'fixed' styles, now using CSS.
* operation/agentes/networkmap.php: Added ransep and font selectors.
Added alert under yellow color. Minor improvements.
* operation/reporting/graph_viewer.php: Style update.
* operation/menu.php: Visual console maps sort by name
* images/background-li.gif: This sould replace <li> image.
* general/login_page.php: Added build version on develop mode.
* godmode/reporting/map_builder.php: Sorted lists, and shown module name
instead description.
git-svn-id: https://svn.code.sf.net/p/pandora/code/trunk@949 c3f86ba8-e40f-0410-aaad-9ba5e7f4b01f
guruevi
Esteban Sanchez
slerena
jorgonzalez
Ramon Novoa