Update queryFunc()

* Allow scanList() to search files using a wildcard by removing quotes wrapped around `${list}`
* scanList() will not provide a domain ouput on each string if exact is specified (`grep -l`)
* Remove unused processWildcards() function
* Return a message if no domain is specified
* IDN domains are converted to punycode when running a `pihole -q` search if the `python` package is available, otherwise will revert to current behaviour
* Scan Blacklist & Wildcards first, exiting from search if a match is found (Fixes #1330)
* Use one `grep` subshell to search for all "*.domains" lists at once (opposed to looping to get every matching file name, and then spawning a `grep` instance for every matching file)
* queryFunc() will not return "(0 results)" output from files where no match is found
* Sort results based off list number
* Return a message if no results are found

pihole

@@ -84,62 +84,45 @@ scanList(){
   domain="${1}"
   list="${2}"
   method="${3}"
-  if [[ ${method} == "-exact" ]] ; then
-    grep -i -E "(^|\s)${domain}($|\s)" "${list}"
-  else
-    grep -i "${domain}" "${list}"
-  fi
-}
 
-processWildcards() {
+  if [[ ${method} == "-exact" ]]; then
-  IFS="." read -r -a array <<< "${1}"
+    grep -i -E -l "(^|\/)${domain}($|\/)" ${list}
-  for (( i=${#array[@]}-1; i>=0; i-- )); do
-    ar=""
-    for (( j=${#array[@]}-1; j>${#array[@]}-i-2; j-- )); do
-      if [[ $j == $((${#array[@]}-1)) ]]; then
-        ar="${array[$j]}"
   else
-        ar="${array[$j]}.${ar}"
+    grep -i "${domain}" ${list}
   fi
-    done
-    echo "${ar}"
-  done
 }
 
 queryFunc() {
-  domain="${2}"
   method="${3}"
-  lists=( /etc/pihole/list.* /etc/pihole/blacklist.txt)
-  for list in ${lists[@]}; do
-    if [ -e "${list}" ]; then
-      result=$(scanList ${domain} ${list} ${method})
-      # Remove empty lines before couting number of results
-      count=$(sed '/^\s*$/d' <<< "$result" | wc -l)
-      echo "::: ${list} (${count} results)"
-      if [[ ${count} > 0 ]]; then
-        echo "${result}"
-      fi
-      echo ""
-    else
-      echo "::: ${list} does not exist"
-      echo ""
-    fi
-  done
   
-  # Scan for possible wildcard matches
+  # If domain contains non ASCII characters, convert domain to punycode if python exists
-  if [ -e "${wildcardlist}" ]; then
+  # Cr: https://serverfault.com/a/335079
-    local wildcards=($(processWildcards "${domain}"))
+  if [ -z "${2}" ]; then
-    for domain in ${wildcards[@]}; do
+    echo "::: No domain specified"
-      result=$(scanList "\/${domain}\/" ${wildcardlist})
+    exit 1
-      # Remove empty lines before couting number of results
+  elif [[ ${2} = *[![:ascii:]]* ]]; then
-      count=$(sed '/^\s*$/d' <<< "$result" | wc -l)
+    [ `which python` ] && domain=$(python -c 'import sys;print sys.argv[1].decode("utf-8").encode("idna")' "${2}")
-      if [[ ${count} > 0 ]]; then
+  else
-        echo "::: Wildcard blocking ${domain} (${count} results)"
+    domain="${2}"
-        echo "${result}"
-        echo ""
   fi
-    done
+  
+  # Scan Blacklist and Wildcards
+  lists="/etc/pihole/blacklist.txt $wildcardlist"
+  result=$(scanList ${domain} "${lists}" ${method})
+  if [ -n "$result" ]; then
+    echo "$result"
+    exit 0
   fi
+
+  # Scan Domains lists
+  result=$(scanList ${domain} "/etc/pihole/*.domains" ${method})
+  if [ -n "$result" ]; then
+    sort -t . -k 2 -g <<< "$result"
+  else
+    [ -n "$method" ] && exact="exact "
+    echo "::: No ${exact}results found for ${domain}"
+  fi
+  
   exit 0
 }