From e3c6f162d84a3cf78e6e50969424b1e6cebe742f Mon Sep 17 00:00:00 2001 From: DL6ER Date: Tue, 7 Nov 2023 08:57:56 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Adam Warner Co-authored-by: RD WebDesign Signed-off-by: DL6ER --- automated install/basic-install.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh index 704a736d..e743a071 100755 --- a/automated install/basic-install.sh +++ b/automated install/basic-install.sh @@ -2087,8 +2087,8 @@ migrate_dnsmasq_configs() { # Create target directory /etc/pihole/migration_backup_v6 # and make it owned by pihole:pihole - mkdir -p "${V6_CONF_MIGRATION_DIR} - chown pihole:pihole "${V6_CONF_MIGRATION_DIR} + mkdir -p "${V6_CONF_MIGRATION_DIR}" + chown pihole:pihole "${V6_CONF_MIGRATION_DIR}" # Move all conf files originally created by Pi-hole into this directory # - 01-pihole.conf @@ -2097,8 +2097,8 @@ migrate_dnsmasq_configs() { # - 05-pihole-custom-cname.conf # - 06-rfc6761.conf - mv /etc/dnsmasq.d/0{1,2,4,5}-pihole*.conf "${V6_MIGRATION_DIR}/ CONF_2>/dev/null || true - mv /etc/dnsmasq.d/06-rfc6761.conf "${V6_MIGRATION_DIR}/ CONF_2>/dev/null || true + mv /etc/dnsmasq.d/0{1,2,4,5}-pihole*.conf "${V6_CONF_MIGRATION_DIR}/" 2>/dev/null || true + mv /etc/dnsmasq.d/06-rfc6761.conf "${V6_MIGRATION_DIR}/" 2>/dev/null || true } main() {