Add hide_domain argument to common.env.user segment

If true, this argument hides `@` and the following characters from the user
name.

Fixes #1420
Closes #1426
This commit is contained in:
= 2015-08-07 10:43:10 -05:00 committed by Foo
parent ddfbb20eba
commit e0a62f9cf7
2 changed files with 19 additions and 6 deletions

View File

@ -148,11 +148,13 @@ username = False
_geteuid = getattr(os, 'geteuid', lambda: 1) _geteuid = getattr(os, 'geteuid', lambda: 1)
def user(pl, hide_user=None): def user(pl, hide_user=None, hide_domain=False):
'''Return the current user. '''Return the current user.
:param str hide_user: :param str hide_user:
Omit showing segment for users with names equal to this string. Omit showing segment for users with names equal to this string.
:param bool hide_domain:
Drop domain component if it exists in a username (delimited by '@').
Highlights the user with the ``superuser`` if the effective user ID is 0. Highlights the user with the ``superuser`` if the effective user ID is 0.
@ -166,6 +168,11 @@ def user(pl, hide_user=None):
return None return None
if username == hide_user: if username == hide_user:
return None return None
if hide_domain:
try:
username = username[:username.index('@')]
except ValueError:
pass
euid = _geteuid() euid = _geteuid()
return [{ return [{
'contents': username, 'contents': username,

View File

@ -496,15 +496,15 @@ class TestEnv(TestCommon):
pass pass
def username(self): def username(self):
return 'def' return 'def@DOMAIN.COM'
if hasattr(self.module, 'psutil') and not callable(self.module.psutil.Process.username): if hasattr(self.module, 'psutil') and not callable(self.module.psutil.Process.username):
username = property(username) username = property(username)
struct_passwd = namedtuple('struct_passwd', ('pw_name',)) struct_passwd = namedtuple('struct_passwd', ('pw_name',))
new_psutil = new_module('psutil', Process=Process) new_psutil = new_module('psutil', Process=Process)
new_pwd = new_module('pwd', getpwuid=lambda uid: struct_passwd(pw_name='def')) new_pwd = new_module('pwd', getpwuid=lambda uid: struct_passwd(pw_name='def@DOMAIN.COM'))
new_getpass = new_module('getpass', getuser=lambda: 'def') new_getpass = new_module('getpass', getuser=lambda: 'def@DOMAIN.COM')
pl = Pl() pl = Pl()
with replace_attr(self.module, 'pwd', new_pwd): with replace_attr(self.module, 'pwd', new_pwd):
with replace_attr(self.module, 'getpass', new_getpass): with replace_attr(self.module, 'getpass', new_getpass):
@ -512,12 +512,18 @@ class TestEnv(TestCommon):
with replace_attr(self.module, 'psutil', new_psutil): with replace_attr(self.module, 'psutil', new_psutil):
with replace_attr(self.module, '_geteuid', lambda: 5): with replace_attr(self.module, '_geteuid', lambda: 5):
self.assertEqual(self.module.user(pl=pl), [ self.assertEqual(self.module.user(pl=pl), [
{'contents': 'def', 'highlight_groups': ['user']} {'contents': 'def@DOMAIN.COM', 'highlight_groups': ['user']}
]) ])
self.assertEqual(self.module.user(pl=pl, hide_user='abc'), [ self.assertEqual(self.module.user(pl=pl, hide_user='abc'), [
{'contents': 'def@DOMAIN.COM', 'highlight_groups': ['user']}
])
self.assertEqual(self.module.user(pl=pl, hide_domain=False), [
{'contents': 'def@DOMAIN.COM', 'highlight_groups': ['user']}
])
self.assertEqual(self.module.user(pl=pl, hide_user='def@DOMAIN.COM'), None)
self.assertEqual(self.module.user(pl=pl, hide_domain=True), [
{'contents': 'def', 'highlight_groups': ['user']} {'contents': 'def', 'highlight_groups': ['user']}
]) ])
self.assertEqual(self.module.user(pl=pl, hide_user='def'), None)
with replace_attr(self.module, '_geteuid', lambda: 0): with replace_attr(self.module, '_geteuid', lambda: 0):
self.assertEqual(self.module.user(pl=pl), [ self.assertEqual(self.module.user(pl=pl), [
{'contents': 'def', 'highlight_groups': ['superuser', 'user']} {'contents': 'def', 'highlight_groups': ['superuser', 'user']}