tyler.durden/snappy-java
1
0
Fork 0
mirror of https://github.com/xerial/snappy-java.git synced 2025-07-26 07:24:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong comments

Browse Source
This commit is contained in:
Takeshi YAMAMURO 2017-01-26 10:19:03 +09:00
parent 23f528095c
commit 6f798c6a9d
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/org/xerial/snappy/BitShuffle.java
View File

@ -53,7 +53,7 @@ public class BitShuffle
* @param shuffled output of the shuffled data. Uses range [pos()..]. * @param shuffled output of the shuffled data. Uses range [pos()..].
* @return byte size of the shuffled data. * @return byte size of the shuffled data.
* @throws SnappyError when the input is not a direct buffer * @throws SnappyError when the input is not a direct buffer
* @throws IllegalArgumentException when the input length is not a multiple of a given type size * @throws IllegalArgumentException when the input length is not a multiple of the given type size
*/ */
public static int bitShuffle(ByteBuffer input, BitShuffleType type, ByteBuffer shuffled) throws IOException { public static int bitShuffle(ByteBuffer input, BitShuffleType type, ByteBuffer shuffled) throws IOException {
if (!input.isDirect()) { if (!input.isDirect()) {
@ -69,7 +69,7 @@ public class BitShuffle
int uLen = input.remaining(); int uLen = input.remaining();
int typeSize = type.getTypeSize(); int typeSize = type.getTypeSize();
if (uLen % typeSize != 0) { if (uLen % typeSize != 0) {
throw new IllegalArgumentException("input length must be a multiple of a given type size"); throw new IllegalArgumentException("input length must be a multiple of the given type size: " + typeSize);
} }
if (shuffled.remaining() < uLen) { if (shuffled.remaining() < uLen) {
throw new IllegalArgumentException("not enough space for output"); throw new IllegalArgumentException("not enough space for output");
@ -163,7 +163,7 @@ public class BitShuffle
* @return byte size of the unshuffled data. * @return byte size of the unshuffled data.
* @throws IOException when failed to unshuffle the given input * @throws IOException when failed to unshuffle the given input
* @throws SnappyError when the input is not a direct buffer * @throws SnappyError when the input is not a direct buffer
* @throws IllegalArgumentException when the length of input shuffled data is not a multiple of a given type size * @throws IllegalArgumentException when the length of input shuffled data is not a multiple of the given type size
*/ */
public static int bitUnShuffle(ByteBuffer shuffled, BitShuffleType type, ByteBuffer output) throws IOException { public static int bitUnShuffle(ByteBuffer shuffled, BitShuffleType type, ByteBuffer output) throws IOException {
if (!shuffled.isDirect()) { if (!shuffled.isDirect()) {
@ -179,7 +179,7 @@ public class BitShuffle
int uLen = shuffled.remaining(); int uLen = shuffled.remaining();
int typeSize = type.getTypeSize(); int typeSize = type.getTypeSize();
if (uLen % typeSize != 0) { if (uLen % typeSize != 0) {
throw new IllegalArgumentException("length of input shuffled data must be a multiple of a given type size"); throw new IllegalArgumentException("length of input shuffled data must be a multiple of the given type size: " + typeSize);
} }
if (output.remaining() < uLen) { if (output.remaining() < uLen) {
throw new IllegalArgumentException("not enough space for output"); throw new IllegalArgumentException("not enough space for output");

4
src/test/java/org/xerial/snappy/BitShuffleTest.java
View File

@ -88,13 +88,13 @@ public class BitShuffleTest {
BitShuffle.bitShuffle(inputBuf, BitShuffleType.INT, outputBuf); BitShuffle.bitShuffle(inputBuf, BitShuffleType.INT, outputBuf);
fail("no expected exception happened"); fail("no expected exception happened");
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
Assert.assertTrue(e.getMessage().equals("input length must be a multiple of a given type size")); Assert.assertTrue(e.getMessage().startsWith("input length must be a multiple of the given type size"));
} }
try { try {
BitShuffle.bitUnShuffle(inputBuf, BitShuffleType.INT, outputBuf); BitShuffle.bitUnShuffle(inputBuf, BitShuffleType.INT, outputBuf);
fail("no expected exception happened"); fail("no expected exception happened");
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
Assert.assertTrue(e.getMessage().equals("length of input shuffled data must be a multiple of a given type size")); Assert.assertTrue(e.getMessage().startsWith("length of input shuffled data must be a multiple of the given type size"));
} }
} }