internal: let ByteBuffer read 4 bytes as int in single call (#594)

This commit is contained in:
Brett Okken 2024-09-10 14:22:47 -05:00 committed by GitHub
parent 1af05fee67
commit da1af8b260
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 12 deletions

View File

@ -16,6 +16,7 @@ import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import java.nio.ByteBuffer; import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.nio.channels.Channels; import java.nio.channels.Channels;
import java.nio.channels.ClosedChannelException; import java.nio.channels.ClosedChannelException;
import java.nio.channels.ReadableByteChannel; import java.nio.channels.ReadableByteChannel;
@ -669,17 +670,9 @@ public final class SnappyFramedInputStream
private FrameData getFrameData(ByteBuffer content) private FrameData getFrameData(ByteBuffer content)
throws IOException throws IOException
{ {
return new FrameData(getCrc32c(content), 4); // the first 4 bytes are the crc32c value in little endian order
} content.order(ByteOrder.LITTLE_ENDIAN);
final int crc32c = content.getInt(content.position());
private int getCrc32c(ByteBuffer content) return new FrameData(crc32c, 4);
{
final int position = content.position();
return ((content.get(position + 3) & 0xFF) << 24)
| ((content.get(position + 2) & 0xFF) << 16)
| ((content.get(position + 1) & 0xFF) << 8)
| (content.get(position) & 0xFF);
} }
} }