tyler.durden
/
test262
mirror of https://github.com/tc39/test262.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
test262/tools/lint/lib/checks/negative.py

42 lines
1.5 KiB
Python
Raw Normal View History

Enforce use of `throw` stmt in early error tests Previously, test consumers were encouraged to insert a `throw` statement as the first statement of tests for early errors. This recommendation made tests harder to consume, and as an optional transformation, consumers may have ignored it or simply been unaware it was made. By explicitly including such a `throw` statement, the tests become more literal, making them easier to consume and more transparent in their expectations. Document expectation for all tests for early errors to include an explicit `throw` statement. Extend linting script to verify that contributors are automatically notified of violations and to ensure that future contributions satisfy this expectation.
2017-04-29 21:33:06 +02:00
import re
from ..check import Check
_THROW_STMT = re.compile(
Rename to $DONOTEVALUATE per @leobalter's suggestion
2018-10-11 16:59:24 +02:00
r'^\$DONOTEVALUATE\(\);$',
Enforce use of `throw` stmt in early error tests Previously, test consumers were encouraged to insert a `throw` statement as the first statement of tests for early errors. This recommendation made tests harder to consume, and as an optional transformation, consumers may have ignored it or simply been unaware it was made. By explicitly including such a `throw` statement, the tests become more literal, making them easier to consume and more transparent in their expectations. Document expectation for all tests for early errors to include an explicit `throw` statement. Extend linting script to verify that contributors are automatically notified of violations and to ensure that future contributions satisfy this expectation.
2017-04-29 21:33:06 +02:00
re.MULTILINE)
Lint: Rename _THROW_STMT_LEGACY to _THROW_STMT_RAW. 'Legacy' implies (to me) that it should no longer be allowed, but the lint explicitly checks for its presence (in the 'raw' case).
2019-08-09 15:52:40 +02:00
_THROW_STMT_RAW = re.compile(
Linter should require direct throw statement for raw tests instead of DONOTEVALUATE
2019-02-05 21:32:34 +01:00
r'^throw "Test262: This statement should not be evaluated\.";$',
re.MULTILINE)
Enforce use of `throw` stmt in early error tests Previously, test consumers were encouraged to insert a `throw` statement as the first statement of tests for early errors. This recommendation made tests harder to consume, and as an optional transformation, consumers may have ignored it or simply been unaware it was made. By explicitly including such a `throw` statement, the tests become more literal, making them easier to consume and more transparent in their expectations. Document expectation for all tests for early errors to include an explicit `throw` statement. Extend linting script to verify that contributors are automatically notified of violations and to ensure that future contributions satisfy this expectation.
2017-04-29 21:33:06 +02:00
class CheckNegative(Check):
'''Ensure tests have the expected YAML-formatted metadata.'''
ID = 'NEGATIVE'
def run(self, name, meta, source):
if meta is None or meta.get('negative') is None:
return
negative = meta['negative']
if not isinstance(negative, dict):
return '"negative" must be a dictionary with fields "type" and "phase"'
if not 'type' in negative:
return '"negative" must specify a "type" field'
if not 'phase' in negative:
return '"negative" must specify a "phase" field'
lint: disallow extra fields in "negative" metadata (#3009)
2021-06-24 19:37:55 +02:00
if len(negative.keys()) > 2:
return '"negative" must specify only "type" and "phase" fields'
Fix existing linting errors, update error phase, and add a new flags linter (#2086)
2019-03-06 18:24:44 +01:00
if negative["phase"] not in ["parse", "resolution", "runtime"]:
return '"phase" must be one of ["parse", "resolution", "runtime"]'
Linter should require direct throw statement for raw tests instead of DONOTEVALUATE
2019-02-05 21:32:34 +01:00
if negative["phase"] in ["parse", "resolution"]:
if meta.get('flags') and 'raw' in meta['flags']:
Lint: Rename _THROW_STMT_LEGACY to _THROW_STMT_RAW. 'Legacy' implies (to me) that it should no longer be allowed, but the lint explicitly checks for its presence (in the 'raw' case).
2019-08-09 15:52:40 +02:00
if not _THROW_STMT_RAW.search(source):
Linter should require direct throw statement for raw tests instead of DONOTEVALUATE
2019-02-05 21:32:34 +01:00
return 'Negative tests of type "early" must include a `throw` statement'
elif not _THROW_STMT.search(source):
return 'Negative tests of type "early" must include a $DONOTEVALUATE() call'