feat: regression tests for optional call (#2429)

* feat: regression tests for optional call

* chore: address code review

* chore: fix assertion

* chore: set context rather than return context
This commit is contained in:
Benjamin E. Coe 2019-12-18 11:35:28 -05:00 committed by Leo Balter
parent a3370bfca5
commit 0ea69c7864
2 changed files with 61 additions and 0 deletions

View File

@ -0,0 +1,31 @@
// Copyright 2019 Google, LLC. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: prod-OptionalExpression
description: >
optional call invoked on new.target should be equivalent to call
info: |
OptionalExpression
MemberExpression OptionalChain
NewTarget OptionalChain
features: [optional-chaining]
includes: [fnGlobalObject.js]
---*/
const newTargetContext = (function() { return this; })();
let called = false;
// should be set to 'undefined' or global context, depending on whether
// mode is strict or sloppy.
let context = null;
function Base() {
called = true;
context = this;
}
function Foo(blerg) {
new.target?.();
}
Reflect.construct(Foo, [], Base);
assert(context === newTargetContext);
assert.sameValue(called, true);

View File

@ -0,0 +1,30 @@
// Copyright 2019 Google, LLC. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: prod-OptionalExpression
description: >
optional call invoked on super method should be equivalent to call
info: |
OptionalExpression
MemberExpression OptionalChain
SuperProperty OptionalChain
features: [optional-chaining]
---*/
let called = false;
let context;
class Base {
method() {
called = true;
context = this;
}
}
class Foo extends Base {
method() {
super.method?.();
}
}
const foo = new Foo();
foo.method();
assert(foo === context);
assert.sameValue(called, true);