From 0fe508c5f066dcd2fecd957a61f8423bf42982eb Mon Sep 17 00:00:00 2001 From: Frank Yung-Fong Tang Date: Thu, 6 Jan 2022 09:55:45 -0800 Subject: [PATCH] change notation to "standard" I do not believe this setup is correct if we use notation: "compact". in https://tc39.es/proposal-intl-numberformat-v3/out/numberformat/diff.html#sec-setnfdigitoptions notation is "compact" mnsd is undefined mxsd is undefined mnfd is undefined mxfd is undefined hasSd is false hasFd is false needSd is false needFd is false so step 23 else block will be run Set intlObj.[[RoundingType]] to morePrecision. then in step 23 of https://tc39.es/proposal-intl-numberformat-v3/out/numberformat/diff.html#sec-initializenumberformat ``` If roundingIncrement is not 1 and numberFormat.[[RoundingType]] is not fractionDigits, throw a RangeError exception. ``` --- test/intl402/NumberFormat/constructor-roundingIncrement.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/intl402/NumberFormat/constructor-roundingIncrement.js b/test/intl402/NumberFormat/constructor-roundingIncrement.js index e0f553e396..ed2637edac 100644 --- a/test/intl402/NumberFormat/constructor-roundingIncrement.js +++ b/test/intl402/NumberFormat/constructor-roundingIncrement.js @@ -34,7 +34,7 @@ for (const [value, expected] of values) { const nf = new Intl.NumberFormat([], { get notation() { callOrder.push("notation"); - return "compact"; + return "standard"; }, get roundingIncrement() { callOrder.push("roundingIncrement");