From 116bc2cc47d457c1b1037ff6bc5e6a8d9442bae8 Mon Sep 17 00:00:00 2001 From: Philip Chimento Date: Wed, 2 Oct 2024 13:50:06 -0700 Subject: [PATCH] =?UTF-8?q?Temporal:=20Move=20UTC=20offset=20=C2=B124:00?= =?UTF-8?q?=20into=20invalid=20string=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was in the "limits of representable range" tests, but it is invalid syntax, so it belongs somewhere else. --- .../Temporal/Instant/compare/argument-string-invalid.js | 2 ++ .../built-ins/Temporal/Instant/compare/instant-string-limits.js | 2 -- test/built-ins/Temporal/Instant/from/argument-string-invalid.js | 2 ++ test/built-ins/Temporal/Instant/from/instant-string-limits.js | 2 -- .../Instant/prototype/equals/argument-string-invalid.js | 2 ++ .../Temporal/Instant/prototype/equals/instant-string-limits.js | 2 -- .../Temporal/Instant/prototype/since/argument-string-invalid.js | 2 ++ .../Temporal/Instant/prototype/since/instant-string-limits.js | 2 -- .../Temporal/Instant/prototype/until/argument-string-invalid.js | 2 ++ .../Temporal/Instant/prototype/until/instant-string-limits.js | 2 -- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/test/built-ins/Temporal/Instant/compare/argument-string-invalid.js b/test/built-ins/Temporal/Instant/compare/argument-string-invalid.js index 1687124307..403087ff63 100644 --- a/test/built-ins/Temporal/Instant/compare/argument-string-invalid.js +++ b/test/built-ins/Temporal/Instant/compare/argument-string-invalid.js @@ -35,6 +35,8 @@ const invalidStrings = [ "2020-01-01T001Z", "2020-01-01T01:001Z", "2020-01-01T01:01:001Z", + "2020-01-01T00:00-24:00", + "2020-01-01T00:00+24:00", // valid, but forms not supported in Temporal: "2020-W01-1T00:00Z", "2020-001T00:00Z", diff --git a/test/built-ins/Temporal/Instant/compare/instant-string-limits.js b/test/built-ins/Temporal/Instant/compare/instant-string-limits.js index a664a3fcbf..569b59025b 100644 --- a/test/built-ins/Temporal/Instant/compare/instant-string-limits.js +++ b/test/built-ins/Temporal/Instant/compare/instant-string-limits.js @@ -35,11 +35,9 @@ const outOfRangeInstantStrings = [ "-271821-04-19T23:59:59.999999999Z", "-271821-04-19T23:00-00:59:59.999999999", "-271821-04-19T00:00:00-23:59:59.999999999", - "-271821-04-19T00:00:00-24:00", "+275760-09-13T00:00:00.000000001Z", "+275760-09-13T01:00+00:59:59.999999999", "+275760-09-14T00:00+23:59:59.999999999", - "+275760-09-14T00:00+24:00", ]; for (const str of outOfRangeInstantStrings) { diff --git a/test/built-ins/Temporal/Instant/from/argument-string-invalid.js b/test/built-ins/Temporal/Instant/from/argument-string-invalid.js index 8797b8ed01..967db6ae7c 100644 --- a/test/built-ins/Temporal/Instant/from/argument-string-invalid.js +++ b/test/built-ins/Temporal/Instant/from/argument-string-invalid.js @@ -35,6 +35,8 @@ const invalidStrings = [ "2020-01-01T001Z", "2020-01-01T01:001Z", "2020-01-01T01:01:001Z", + "2020-01-01T00:00-24:00", + "2020-01-01T00:00+24:00", // valid, but forms not supported in Temporal: "2020-W01-1T00:00Z", "2020-001T00:00Z", diff --git a/test/built-ins/Temporal/Instant/from/instant-string-limits.js b/test/built-ins/Temporal/Instant/from/instant-string-limits.js index 414c505aa4..7dfbe6ae80 100644 --- a/test/built-ins/Temporal/Instant/from/instant-string-limits.js +++ b/test/built-ins/Temporal/Instant/from/instant-string-limits.js @@ -33,11 +33,9 @@ const outOfRangeInstantStrings = [ "-271821-04-19T23:59:59.999999999Z", "-271821-04-19T23:00-00:59:59.999999999", "-271821-04-19T00:00:00-23:59:59.999999999", - "-271821-04-19T00:00:00-24:00", "+275760-09-13T00:00:00.000000001Z", "+275760-09-13T01:00+00:59:59.999999999", "+275760-09-14T00:00+23:59:59.999999999", - "+275760-09-14T00:00+24:00", ]; for (const str of outOfRangeInstantStrings) { diff --git a/test/built-ins/Temporal/Instant/prototype/equals/argument-string-invalid.js b/test/built-ins/Temporal/Instant/prototype/equals/argument-string-invalid.js index 581de1c51b..2c1c372037 100644 --- a/test/built-ins/Temporal/Instant/prototype/equals/argument-string-invalid.js +++ b/test/built-ins/Temporal/Instant/prototype/equals/argument-string-invalid.js @@ -35,6 +35,8 @@ const invalidStrings = [ "2020-01-01T001Z", "2020-01-01T01:001Z", "2020-01-01T01:01:001Z", + "2020-01-01T00:00-24:00", + "2020-01-01T00:00+24:00", // valid, but forms not supported in Temporal: "2020-W01-1T00:00Z", "2020-001T00:00Z", diff --git a/test/built-ins/Temporal/Instant/prototype/equals/instant-string-limits.js b/test/built-ins/Temporal/Instant/prototype/equals/instant-string-limits.js index d64d14f1d3..c02f026bbd 100644 --- a/test/built-ins/Temporal/Instant/prototype/equals/instant-string-limits.js +++ b/test/built-ins/Temporal/Instant/prototype/equals/instant-string-limits.js @@ -33,11 +33,9 @@ const outOfRangeInstantStrings = [ "-271821-04-19T23:59:59.999999999Z", "-271821-04-19T23:00-00:59:59.999999999", "-271821-04-19T00:00:00-23:59:59.999999999", - "-271821-04-19T00:00:00-24:00", "+275760-09-13T00:00:00.000000001Z", "+275760-09-13T01:00+00:59:59.999999999", "+275760-09-14T00:00+23:59:59.999999999", - "+275760-09-14T00:00+24:00", ]; for (const str of outOfRangeInstantStrings) { diff --git a/test/built-ins/Temporal/Instant/prototype/since/argument-string-invalid.js b/test/built-ins/Temporal/Instant/prototype/since/argument-string-invalid.js index 9ce112b73f..2f5aae257d 100644 --- a/test/built-ins/Temporal/Instant/prototype/since/argument-string-invalid.js +++ b/test/built-ins/Temporal/Instant/prototype/since/argument-string-invalid.js @@ -35,6 +35,8 @@ const invalidStrings = [ "2020-01-01T001Z", "2020-01-01T01:001Z", "2020-01-01T01:01:001Z", + "2020-01-01T00:00-24:00", + "2020-01-01T00:00+24:00", // valid, but forms not supported in Temporal: "2020-W01-1T00:00Z", "2020-001T00:00Z", diff --git a/test/built-ins/Temporal/Instant/prototype/since/instant-string-limits.js b/test/built-ins/Temporal/Instant/prototype/since/instant-string-limits.js index 8cedce299e..860599bbce 100644 --- a/test/built-ins/Temporal/Instant/prototype/since/instant-string-limits.js +++ b/test/built-ins/Temporal/Instant/prototype/since/instant-string-limits.js @@ -34,11 +34,9 @@ const outOfRangeInstantStrings = [ "-271821-04-19T23:59:59.999999999Z", "-271821-04-19T23:00-00:59:59.999999999", "-271821-04-19T00:00:00-23:59:59.999999999", - "-271821-04-19T00:00:00-24:00", "+275760-09-13T00:00:00.000000001Z", "+275760-09-13T01:00+00:59:59.999999999", "+275760-09-14T00:00+23:59:59.999999999", - "+275760-09-14T00:00+24:00", ]; for (const str of outOfRangeInstantStrings) { diff --git a/test/built-ins/Temporal/Instant/prototype/until/argument-string-invalid.js b/test/built-ins/Temporal/Instant/prototype/until/argument-string-invalid.js index 96585258d7..a83633d968 100644 --- a/test/built-ins/Temporal/Instant/prototype/until/argument-string-invalid.js +++ b/test/built-ins/Temporal/Instant/prototype/until/argument-string-invalid.js @@ -35,6 +35,8 @@ const invalidStrings = [ "2020-01-01T001Z", "2020-01-01T01:001Z", "2020-01-01T01:01:001Z", + "2020-01-01T00:00-24:00", + "2020-01-01T00:00+24:00", // valid, but forms not supported in Temporal: "2020-W01-1T00:00Z", "2020-001T00:00Z", diff --git a/test/built-ins/Temporal/Instant/prototype/until/instant-string-limits.js b/test/built-ins/Temporal/Instant/prototype/until/instant-string-limits.js index 0fb0902a9a..1c96e3d6a7 100644 --- a/test/built-ins/Temporal/Instant/prototype/until/instant-string-limits.js +++ b/test/built-ins/Temporal/Instant/prototype/until/instant-string-limits.js @@ -34,11 +34,9 @@ const outOfRangeInstantStrings = [ "-271821-04-19T23:59:59.999999999Z", "-271821-04-19T23:00-00:59:59.999999999", "-271821-04-19T00:00:00-23:59:59.999999999", - "-271821-04-19T00:00:00-24:00", "+275760-09-13T00:00:00.000000001Z", "+275760-09-13T01:00+00:59:59.999999999", "+275760-09-14T00:00+23:59:59.999999999", - "+275760-09-14T00:00+24:00", ]; for (const str of outOfRangeInstantStrings) {