Merge pull request #2282 from caiolima/static-fields-usage

Tests to cover simple declaration of static fields.
This commit is contained in:
Leo Balter 2019-08-13 00:16:40 -04:00 committed by GitHub
commit 134652ea3c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 351 additions and 0 deletions

View File

@ -0,0 +1,115 @@
// Copyright (C) 2019 Caio Lima (Igalia SL). All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
desc: Static fields are defined using DefineField
info: |
Updated Productions
ClassElement :
...
static FieldDefinition ;
FieldDefinition :
ClassElementName Initializer_opt
ClassElementName :
PropertyName
PropertyName :
LiteralPropertyName
ComputedPropertyName
LiteralPropertyName :
IdentifierName
StringLiteral
NumericLiteral
ClassDefinitionEvaluation:
...
27. Let staticFields be a new empty List.
28. For each ClassElement e in order from elements,
a. If IsStatic of e is false, then
...
b. Else,
i. Let field be the result of performing PropertyDefinitionEvaluation for mClassElementEvaluation for e with arguments F and false.
c. If field is an abrupt completion, then
...
d. If field is not empty,
i. If IsStatic of e is false, append field to instanceFields.
ii. Otherwise, append field to staticFields.
34. For each item fieldRecord in order from staticFields,
a. Perform ? DefineField(F, field).
...
DefineField(receiver, fieldRecord)
1. Assert: Type(receiver) is Object.
2. Assert: fieldRecord is a Record as created by ClassFieldDefinitionEvaluation.
3. Let name be fieldRecord.[[Name]].
4. Let initializer be fieldRecord.[[Initializer]].
5. If initializer is not empty, then
a. Let initValue be ? Call(initializer, receiver).
6. Else, let initValue be undefined.
7. If fieldRecord.[[IsAnonymousFunctionDefinition]] is true, then
a. Let hasNameProperty be ? HasOwnProperty(initValue, "name").
b. If hasNameProperty is false, perform SetFunctionName(initValue, fieldName).
8. If fieldName is a Private Name,
a. Perform ? PrivateFieldAdd(fieldName, receiver, initValue).
9. Else,
a. Assert: IsPropertyKey(fieldName) is true.
b. Perform ? CreateDataPropertyOrThrow(receiver, fieldName, initValue).
10. Return.
template: default
includes: [propertyHelper.js]
features: [class-static-fields-public]
---*/
//- setup
var computed = 'h';
//- elements
static f = 'test262';
static 'g';
static 0 = 'bar';
static [computed];
//- assertions
let c = new C();
assert.sameValue(c.f, undefined);
assert.sameValue(c.g, undefined);
assert.sameValue(c.h, undefined);
assert.sameValue(c[0], undefined);
assert.sameValue(Object.hasOwnProperty.call(c, 'f'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 'g'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 'h'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 0), false);
verifyProperty(C, 'f', {
value: 'test262',
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 'g', {
value: undefined,
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 0, {
value: 'bar',
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 'h', {
value: undefined,
enumerable: true,
writable: true,
configurable: true
});

View File

@ -0,0 +1,118 @@
// This file was procedurally generated from the following sources:
// - src/class-elements/static-field-declaration.case
// - src/class-elements/default/cls-expr.template
/*---
description: Static fields are defined using DefineField (field definitions in a class expression)
esid: prod-FieldDefinition
features: [class-static-fields-public, class]
flags: [generated]
includes: [propertyHelper.js]
info: |
Updated Productions
ClassElement :
...
static FieldDefinition ;
FieldDefinition :
ClassElementName Initializer_opt
ClassElementName :
PropertyName
PropertyName :
LiteralPropertyName
ComputedPropertyName
LiteralPropertyName :
IdentifierName
StringLiteral
NumericLiteral
ClassDefinitionEvaluation:
...
27. Let staticFields be a new empty List.
28. For each ClassElement e in order from elements,
a. If IsStatic of e is false, then
...
b. Else,
i. Let field be the result of performing PropertyDefinitionEvaluation for mClassElementEvaluation for e with arguments F and false.
c. If field is an abrupt completion, then
...
d. If field is not empty,
i. If IsStatic of e is false, append field to instanceFields.
ii. Otherwise, append field to staticFields.
34. For each item fieldRecord in order from staticFields,
a. Perform ? DefineField(F, field).
...
DefineField(receiver, fieldRecord)
1. Assert: Type(receiver) is Object.
2. Assert: fieldRecord is a Record as created by ClassFieldDefinitionEvaluation.
3. Let name be fieldRecord.[[Name]].
4. Let initializer be fieldRecord.[[Initializer]].
5. If initializer is not empty, then
a. Let initValue be ? Call(initializer, receiver).
6. Else, let initValue be undefined.
7. If fieldRecord.[[IsAnonymousFunctionDefinition]] is true, then
a. Let hasNameProperty be ? HasOwnProperty(initValue, "name").
b. If hasNameProperty is false, perform SetFunctionName(initValue, fieldName).
8. If fieldName is a Private Name,
a. Perform ? PrivateFieldAdd(fieldName, receiver, initValue).
9. Else,
a. Assert: IsPropertyKey(fieldName) is true.
b. Perform ? CreateDataPropertyOrThrow(receiver, fieldName, initValue).
10. Return.
---*/
var computed = 'h';
var C = class {
static f = 'test262';
static 'g';
static 0 = 'bar';
static [computed];
}
let c = new C();
assert.sameValue(c.f, undefined);
assert.sameValue(c.g, undefined);
assert.sameValue(c.h, undefined);
assert.sameValue(c[0], undefined);
assert.sameValue(Object.hasOwnProperty.call(c, 'f'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 'g'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 'h'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 0), false);
verifyProperty(C, 'f', {
value: 'test262',
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 'g', {
value: undefined,
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 0, {
value: 'bar',
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 'h', {
value: undefined,
enumerable: true,
writable: true,
configurable: true
});

View File

@ -0,0 +1,118 @@
// This file was procedurally generated from the following sources:
// - src/class-elements/static-field-declaration.case
// - src/class-elements/default/cls-decl.template
/*---
description: Static fields are defined using DefineField (field definitions in a class declaration)
esid: prod-FieldDefinition
features: [class-static-fields-public, class]
flags: [generated]
includes: [propertyHelper.js]
info: |
Updated Productions
ClassElement :
...
static FieldDefinition ;
FieldDefinition :
ClassElementName Initializer_opt
ClassElementName :
PropertyName
PropertyName :
LiteralPropertyName
ComputedPropertyName
LiteralPropertyName :
IdentifierName
StringLiteral
NumericLiteral
ClassDefinitionEvaluation:
...
27. Let staticFields be a new empty List.
28. For each ClassElement e in order from elements,
a. If IsStatic of e is false, then
...
b. Else,
i. Let field be the result of performing PropertyDefinitionEvaluation for mClassElementEvaluation for e with arguments F and false.
c. If field is an abrupt completion, then
...
d. If field is not empty,
i. If IsStatic of e is false, append field to instanceFields.
ii. Otherwise, append field to staticFields.
34. For each item fieldRecord in order from staticFields,
a. Perform ? DefineField(F, field).
...
DefineField(receiver, fieldRecord)
1. Assert: Type(receiver) is Object.
2. Assert: fieldRecord is a Record as created by ClassFieldDefinitionEvaluation.
3. Let name be fieldRecord.[[Name]].
4. Let initializer be fieldRecord.[[Initializer]].
5. If initializer is not empty, then
a. Let initValue be ? Call(initializer, receiver).
6. Else, let initValue be undefined.
7. If fieldRecord.[[IsAnonymousFunctionDefinition]] is true, then
a. Let hasNameProperty be ? HasOwnProperty(initValue, "name").
b. If hasNameProperty is false, perform SetFunctionName(initValue, fieldName).
8. If fieldName is a Private Name,
a. Perform ? PrivateFieldAdd(fieldName, receiver, initValue).
9. Else,
a. Assert: IsPropertyKey(fieldName) is true.
b. Perform ? CreateDataPropertyOrThrow(receiver, fieldName, initValue).
10. Return.
---*/
var computed = 'h';
class C {
static f = 'test262';
static 'g';
static 0 = 'bar';
static [computed];
}
let c = new C();
assert.sameValue(c.f, undefined);
assert.sameValue(c.g, undefined);
assert.sameValue(c.h, undefined);
assert.sameValue(c[0], undefined);
assert.sameValue(Object.hasOwnProperty.call(c, 'f'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 'g'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 'h'), false);
assert.sameValue(Object.hasOwnProperty.call(c, 0), false);
verifyProperty(C, 'f', {
value: 'test262',
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 'g', {
value: undefined,
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 0, {
value: 'bar',
enumerable: true,
writable: true,
configurable: true
});
verifyProperty(C, 'h', {
value: undefined,
enumerable: true,
writable: true,
configurable: true
});