From 142a6a6fbeb062f39bb0ca5cb73e9489de2b906d Mon Sep 17 00:00:00 2001 From: Ross Kirsling Date: Sat, 13 Apr 2024 03:59:40 +0900 Subject: [PATCH] Update test for o[p] = f() (#4052) * Update test for o[p] = f() Update S11.13.1_A7_T3.js now that consensus has been reached on https://github.com/tc39/ecma262/pull/3307. * Rename test and add an analogous one for super. --- .../expressions/assignment/S11.13.1_A7_T3.js | 26 ---------- .../target-member-computed-reference.js | 40 ++++++++++++++++ .../target-super-computed-reference.js | 47 +++++++++++++++++++ 3 files changed, 87 insertions(+), 26 deletions(-) delete mode 100644 test/language/expressions/assignment/S11.13.1_A7_T3.js create mode 100644 test/language/expressions/assignment/target-member-computed-reference.js create mode 100644 test/language/expressions/assignment/target-super-computed-reference.js diff --git a/test/language/expressions/assignment/S11.13.1_A7_T3.js b/test/language/expressions/assignment/S11.13.1_A7_T3.js deleted file mode 100644 index 6b979bf04d..0000000000 --- a/test/language/expressions/assignment/S11.13.1_A7_T3.js +++ /dev/null @@ -1,26 +0,0 @@ -// Copyright (C) 2015 André Bargull. All rights reserved. -// This code is governed by the BSD license found in the LICENSE file. - -/*--- -info: Assignment Operator evaluates its operands from left to right. -description: > - The left-hand side expression is evaluated before the right-hand side. - Left-hand side expression is MemberExpression: base[prop]. Evaluating - ToPropertyKey(prop) throws an error. ----*/ - -function DummyError() { } - -assert.throws(DummyError, function() { - var base = {}; - var prop = { - toString: function() { - throw new DummyError(); - } - }; - var expr = function() { - throw new Test262Error("right-hand side expression evaluated"); - }; - - base[prop] = expr(); -}); diff --git a/test/language/expressions/assignment/target-member-computed-reference.js b/test/language/expressions/assignment/target-member-computed-reference.js new file mode 100644 index 0000000000..6046f4dc41 --- /dev/null +++ b/test/language/expressions/assignment/target-member-computed-reference.js @@ -0,0 +1,40 @@ +// Copyright (C) 2015 André Bargull. All rights reserved. +// Copyright (C) 2024 Sony Interactive Entertainment Inc. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-assignment-operators +description: Assignment Operator evaluates its operands from left to right (formerly S11.13.1_A7_T3) +info: | + The left-hand side expression is evaluated before the right-hand side. + Left-hand side expression is MemberExpression: base[prop]. + ToPropertyKey(prop) occurs after both sides are evaluated. +---*/ + +function DummyError() { } + +assert.throws(DummyError, function() { + var base = {}; + var prop = function() { + throw new DummyError(); + }; + var expr = function() { + throw new Test262Error("right-hand side expression evaluated"); + }; + + base[prop()] = expr(); +}); + +assert.throws(DummyError, function() { + var base = {}; + var prop = { + toString: function() { + throw new Test262Error("property key evaluated"); + } + }; + var expr = function() { + throw new DummyError(); + }; + + base[prop] = expr(); +}); diff --git a/test/language/expressions/assignment/target-super-computed-reference.js b/test/language/expressions/assignment/target-super-computed-reference.js new file mode 100644 index 0000000000..fc788694fc --- /dev/null +++ b/test/language/expressions/assignment/target-super-computed-reference.js @@ -0,0 +1,47 @@ +// Copyright (C) 2024 Sony Interactive Entertainment Inc. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-assignment-operators +description: Assignment Operator evaluates its operands from left to right +info: | + The left-hand side expression is evaluated before the right-hand side. + Left-hand side expression is MemberExpression: super[prop]. + ToPropertyKey(prop) occurs after both sides are evaluated. +---*/ + +assert.throws(DummyError, function() { + var prop = function() { + throw new DummyError(); + }; + var expr = function() { + throw new Test262Error("right-hand side expression evaluated"); + }; + + class C extends class {} { + m() { + super[prop()] = expr(); + } + } + + (new C()).m(); +}); + +assert.throws(DummyError, function() { + var prop = { + toString: function() { + throw new Test262Error("property key evaluated"); + } + }; + var expr = function() { + throw new DummyError(); + }; + + class C extends class {} { + m() { + super[prop] = expr(); + } + } + + (new C()).m(); +});