tyler.durden
/
test262
mirror of https://github.com/tc39/test262.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Intl.NumberFormat useGrouping value tests 

After Intl.NumberFormat v3, default useGrouping is "auto".
We also fix test/intl402/NumberFormat/test-option-useGrouping.js. After v3,
it accepts string and boolean.
This commit is contained in:
Yusuke Suzuki 2022-01-10 22:56:30 -08:00 committed by Rick Waldron
parent 91356f52f9
commit 1935e1b410
2 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/intl402/NumberFormat/prototype/resolvedOptions/basic.js vendored
View File

@ -1,4 +1,5 @@
// Copyright 2012 Mozilla Corporation. All rights reserved. // Copyright 2012 Mozilla Corporation. All rights reserved.
// Copyright 2022 Apple Inc. All rights reserved.
// This code is governed by the license found in the LICENSE file. // This code is governed by the license found in the LICENSE file.
/*--- /*---
@ -9,6 +10,7 @@ description: >
properties. properties.
author: Norbert Lindenberg author: Norbert Lindenberg
includes: [testIntl.js, propertyHelper.js] includes: [testIntl.js, propertyHelper.js]
features: [Intl.NumberFormat-v3]
---*/ ---*/
var actual = new Intl.NumberFormat().resolvedOptions(); var actual = new Intl.NumberFormat().resolvedOptions();
@ -25,7 +27,7 @@ assert.sameValue(actual.style, "decimal");
assert.sameValue(actual.minimumIntegerDigits, 1); assert.sameValue(actual.minimumIntegerDigits, 1);
assert.sameValue(actual.minimumFractionDigits, 0); assert.sameValue(actual.minimumFractionDigits, 0);
assert.sameValue(actual.maximumFractionDigits, 3); assert.sameValue(actual.maximumFractionDigits, 3);
assert.sameValue(actual.useGrouping, true); assert.sameValue(actual.useGrouping, "auto");
var dataPropertyDesc = { writable: true, enumerable: true, configurable: true }; var dataPropertyDesc = { writable: true, enumerable: true, configurable: true };
verifyProperty(actual, "locale", dataPropertyDesc); verifyProperty(actual, "locale", dataPropertyDesc);

23
test/intl402/NumberFormat/test-option-useGrouping.js
View File

@ -1,4 +1,5 @@
// Copyright 2012 Mozilla Corporation. All rights reserved. // Copyright 2012 Mozilla Corporation. All rights reserved.
// Copyright 2022 Apple Inc. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file. // This code is governed by the BSD license found in the LICENSE file.
/*--- /*---
@ -11,7 +12,25 @@ info: |
published standard (when the tests' discrepancies can be resolved), published standard (when the tests' discrepancies can be resolved),
implementations should only expect to pass one of these two tests. implementations should only expect to pass one of these two tests.
author: Norbert Lindenberg author: Norbert Lindenberg
includes: [testIntl.js] features: [Intl.NumberFormat-v3]
---*/ ---*/
testOption(Intl.NumberFormat, "useGrouping", "boolean", undefined, true); function resolveUseGrouping(option) {
return new Intl.NumberFormat(undefined, { useGrouping: option }).resolvedOptions().useGrouping;
}
for (let string of ["min2", "auto", "always"]) {
assert.sameValue(resolveUseGrouping(string), string);
}
assert.sameValue(resolveUseGrouping(true), "always");
assert.sameValue(resolveUseGrouping(false), false);
assert.sameValue(resolveUseGrouping(undefined), "auto");
for (let falsy of [0, null, ""]) {
assert.sameValue(resolveUseGrouping(falsy), false);
}
for (let truthy of [42, "MIN2", {}]) {
assert.throws(RangeError, () => { resolveUseGrouping(truthy); }, "Invalid truthy value");
}