From 1ad9bb7626a0836708ef4601668aa54af272e17d Mon Sep 17 00:00:00 2001 From: Mike Pennisi Date: Fri, 15 Oct 2021 18:33:50 -0400 Subject: [PATCH] Improve errors in NumberFormat#formatToParts tests Specify a descriptive value for the previously-unused third parameter of the `verifyFormatParts` function in order to disambiguate error messages. This patch was generated with the following command: sed -i 's/\(verifyFormatParts([^,]\+, \)\([^,]\+\))/\1\2, "\2")/g' \ test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-* --- .../formatToParts/signDisplay-currency-de-DE.js | 12 ++++++------ .../formatToParts/signDisplay-currency-en-US.js | 12 ++++++------ .../formatToParts/signDisplay-currency-ja-JP.js | 12 ++++++------ .../formatToParts/signDisplay-currency-ko-KR.js | 12 ++++++------ .../formatToParts/signDisplay-currency-zh-TW.js | 12 ++++++------ 5 files changed, 30 insertions(+), 30 deletions(-) diff --git a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-de-DE.js b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-de-DE.js index 345fab4f85..783a5acb9a 100644 --- a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-de-DE.js +++ b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-de-DE.js @@ -60,11 +60,11 @@ const tests = [ for (const [signDisplay, negative, negativeNearZero, negativeZero, zero, positiveNearZero, positive] of tests) { const nf = new Intl.NumberFormat("de-DE", { style: "currency", currency: "USD", currencySign: "accounting", signDisplay }); - verifyFormatParts(nf.formatToParts(-987), negative); - verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero); - verifyFormatParts(nf.formatToParts(-0), negativeZero); - verifyFormatParts(nf.formatToParts(0), zero); - verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero); - verifyFormatParts(nf.formatToParts(987), positive); + verifyFormatParts(nf.formatToParts(-987), negative, "negative"); + verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero, "negativeNearZero"); + verifyFormatParts(nf.formatToParts(-0), negativeZero, "negativeZero"); + verifyFormatParts(nf.formatToParts(0), zero, "zero"); + verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero, "positiveNearZero"); + verifyFormatParts(nf.formatToParts(987), positive, "positive"); } diff --git a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-en-US.js b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-en-US.js index fbc91f3508..9fe8f95000 100644 --- a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-en-US.js +++ b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-en-US.js @@ -60,11 +60,11 @@ const tests = [ for (const [signDisplay, negative, negativeNearZero, negativeZero, zero, positiveNearZero, positive] of tests) { const nf = new Intl.NumberFormat("en-US", { style: "currency", currency: "USD", currencySign: "accounting", signDisplay }); - verifyFormatParts(nf.formatToParts(-987), negative); - verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero); - verifyFormatParts(nf.formatToParts(-0), negativeZero); - verifyFormatParts(nf.formatToParts(0), zero); - verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero); - verifyFormatParts(nf.formatToParts(987), positive); + verifyFormatParts(nf.formatToParts(-987), negative, "negative"); + verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero, "negativeNearZero"); + verifyFormatParts(nf.formatToParts(-0), negativeZero, "negativeZero"); + verifyFormatParts(nf.formatToParts(0), zero, "zero"); + verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero, "positiveNearZero"); + verifyFormatParts(nf.formatToParts(987), positive, "positive"); } diff --git a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ja-JP.js b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ja-JP.js index 49473129fd..df166536a9 100644 --- a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ja-JP.js +++ b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ja-JP.js @@ -60,11 +60,11 @@ const tests = [ for (const [signDisplay, negative, negativeNearZero, negativeZero, zero, positiveNearZero, positive] of tests) { const nf = new Intl.NumberFormat("ja-JP", { style: "currency", currency: "USD", currencySign: "accounting", signDisplay }); - verifyFormatParts(nf.formatToParts(-987), negative); - verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero); - verifyFormatParts(nf.formatToParts(-0), negativeZero); - verifyFormatParts(nf.formatToParts(0), zero); - verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero); - verifyFormatParts(nf.formatToParts(987), positive); + verifyFormatParts(nf.formatToParts(-987), negative, "negative"); + verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero, "negativeNearZero"); + verifyFormatParts(nf.formatToParts(-0), negativeZero, "negativeZero"); + verifyFormatParts(nf.formatToParts(0), zero, "zero"); + verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero, "positiveNearZero"); + verifyFormatParts(nf.formatToParts(987), positive, "positive"); } diff --git a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ko-KR.js b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ko-KR.js index f5e464d985..775d31843c 100644 --- a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ko-KR.js +++ b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ko-KR.js @@ -60,11 +60,11 @@ const tests = [ for (const [signDisplay, negative, negativeNearZero, negativeZero, zero, positiveNearZero, positive] of tests) { const nf = new Intl.NumberFormat("ko-KR", { style: "currency", currency: "USD", currencySign: "accounting", signDisplay }); - verifyFormatParts(nf.formatToParts(-987), negative); - verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero); - verifyFormatParts(nf.formatToParts(-0), negativeZero); - verifyFormatParts(nf.formatToParts(0), zero); - verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero); - verifyFormatParts(nf.formatToParts(987), positive); + verifyFormatParts(nf.formatToParts(-987), negative, "negative"); + verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero, "negativeNearZero"); + verifyFormatParts(nf.formatToParts(-0), negativeZero, "negativeZero"); + verifyFormatParts(nf.formatToParts(0), zero, "zero"); + verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero, "positiveNearZero"); + verifyFormatParts(nf.formatToParts(987), positive, "positive"); } diff --git a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-zh-TW.js b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-zh-TW.js index 25917e03c5..c32c6c2ecc 100644 --- a/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-zh-TW.js +++ b/test/intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-zh-TW.js @@ -60,11 +60,11 @@ const tests = [ for (const [signDisplay, negative, negativeNearZero, negativeZero, zero, positiveNearZero, positive] of tests) { const nf = new Intl.NumberFormat("zh-TW", { style: "currency", currency: "USD", currencySign: "accounting", signDisplay }); - verifyFormatParts(nf.formatToParts(-987), negative); - verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero); - verifyFormatParts(nf.formatToParts(-0), negativeZero); - verifyFormatParts(nf.formatToParts(0), zero); - verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero); - verifyFormatParts(nf.formatToParts(987), positive); + verifyFormatParts(nf.formatToParts(-987), negative, "negative"); + verifyFormatParts(nf.formatToParts(-0.0001), negativeNearZero, "negativeNearZero"); + verifyFormatParts(nf.formatToParts(-0), negativeZero, "negativeZero"); + verifyFormatParts(nf.formatToParts(0), zero, "zero"); + verifyFormatParts(nf.formatToParts(0.0001), positiveNearZero, "positiveNearZero"); + verifyFormatParts(nf.formatToParts(987), positive, "positive"); }