mirror of https://github.com/tc39/test262.git
Add another case for indirect module binding update
Also cases for double failing resolutions
This commit is contained in:
parent
aebfbdd9df
commit
23e9d7d58e
|
@ -0,0 +1,47 @@
|
||||||
|
// Copyright (C) 2018 Leo Balter. All rights reserved.
|
||||||
|
// This code is governed by the BSD license found in the LICENSE file.
|
||||||
|
/*---
|
||||||
|
description: >
|
||||||
|
Re-resolve a poisoned module should be consistent on the failure path
|
||||||
|
esid: sec-finishdynamicimport
|
||||||
|
info: |
|
||||||
|
Runtime Semantics: HostImportModuleDynamically
|
||||||
|
|
||||||
|
Failure path
|
||||||
|
- At some future time, the host environment must perform FinishDynamicImport(referencingScriptOrModule,
|
||||||
|
specifier, promiseCapability, an abrupt completion), with the abrupt completion representing the cause
|
||||||
|
of failure.
|
||||||
|
|
||||||
|
The intent of this specification is to not violate run to completion semantics. The spec-level formalization
|
||||||
|
of this is a work-in-progress.
|
||||||
|
|
||||||
|
Every call to HostImportModuleDynamically with the same referencingScriptOrModule and specifier arguments
|
||||||
|
must conform to the same set of requirements above as previous calls do. That is, if the host environment
|
||||||
|
takes the success path once for a given referencingScriptOrModule, specifier pair, it must always do so,
|
||||||
|
and the same for the failure path.
|
||||||
|
|
||||||
|
Runtime Semantics: FinishDynamicImport ( referencingScriptOrModule, specifier, promiseCapability, completion )
|
||||||
|
|
||||||
|
2. Otherwise,
|
||||||
|
a. Assert: completion is a normal completion and completion.[[Value]] is undefined.
|
||||||
|
b. Let moduleRecord be ! HostResolveImportedModule(referencingScriptOrModule, specifier).
|
||||||
|
c. Assert: Evaluate has already been invoked on moduleRecord and successfully completed.
|
||||||
|
d. Let namespace be GetModuleNamespace(moduleRecord).
|
||||||
|
...
|
||||||
|
f. Otherwise, perform ! Call(promiseCapability.[[Resolve]], undefined, « namespace.[[Value]] »).
|
||||||
|
flags: [async]
|
||||||
|
features: [dynamic-import]
|
||||||
|
includes: [compareArray.js]
|
||||||
|
---*/
|
||||||
|
|
||||||
|
function callImport(name) {
|
||||||
|
return import('./double-error-resolution_FIXTURE.js').catch(error => {
|
||||||
|
assert.sameValue(error, 'foo');
|
||||||
|
return `caught ${name}`;
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
Promise.all([
|
||||||
|
callImport(1),
|
||||||
|
callImport(2)
|
||||||
|
]).then(resolutions => assert.compareArray(resolutions, ['caught 1', 'caught 2'])).then($DONE, $DONE);
|
|
@ -0,0 +1,60 @@
|
||||||
|
// Copyright (C) 2018 Leo Balter. All rights reserved.
|
||||||
|
// This code is governed by the BSD license found in the LICENSE file.
|
||||||
|
/*---
|
||||||
|
description: >
|
||||||
|
Re-resolve a poisoned module should be consistent on the failure path
|
||||||
|
esid: sec-finishdynamicimport
|
||||||
|
info: |
|
||||||
|
Runtime Semantics: HostImportModuleDynamically
|
||||||
|
|
||||||
|
Failure path
|
||||||
|
- At some future time, the host environment must perform FinishDynamicImport(referencingScriptOrModule,
|
||||||
|
specifier, promiseCapability, an abrupt completion), with the abrupt completion representing the cause
|
||||||
|
of failure.
|
||||||
|
|
||||||
|
The intent of this specification is to not violate run to completion semantics. The spec-level formalization
|
||||||
|
of this is a work-in-progress.
|
||||||
|
|
||||||
|
Every call to HostImportModuleDynamically with the same referencingScriptOrModule and specifier arguments
|
||||||
|
must conform to the same set of requirements above as previous calls do. That is, if the host environment
|
||||||
|
takes the success path once for a given referencingScriptOrModule, specifier pair, it must always do so,
|
||||||
|
and the same for the failure path.
|
||||||
|
|
||||||
|
Runtime Semantics: FinishDynamicImport ( referencingScriptOrModule, specifier, promiseCapability, completion )
|
||||||
|
|
||||||
|
2. Otherwise,
|
||||||
|
a. Assert: completion is a normal completion and completion.[[Value]] is undefined.
|
||||||
|
b. Let moduleRecord be ! HostResolveImportedModule(referencingScriptOrModule, specifier).
|
||||||
|
c. Assert: Evaluate has already been invoked on moduleRecord and successfully completed.
|
||||||
|
d. Let namespace be GetModuleNamespace(moduleRecord).
|
||||||
|
...
|
||||||
|
f. Otherwise, perform ! Call(promiseCapability.[[Resolve]], undefined, « namespace.[[Value]] »).
|
||||||
|
flags: [async]
|
||||||
|
features: [dynamic-import]
|
||||||
|
---*/
|
||||||
|
|
||||||
|
async function fn() {
|
||||||
|
let err;
|
||||||
|
let result = Object.create(null);
|
||||||
|
const keep = result;
|
||||||
|
try {
|
||||||
|
result = await import('./double-error-resolution_FIXTURE.js');
|
||||||
|
} catch (error) {
|
||||||
|
err = error;
|
||||||
|
}
|
||||||
|
assert.sameValue(err, 'foo', 'first evaluation should be an abrupt completion');
|
||||||
|
assert.sameValue(result, keep, 'result should not be set');
|
||||||
|
|
||||||
|
err = undefined;
|
||||||
|
|
||||||
|
try {
|
||||||
|
result = await import('./double-error-resolution_FIXTURE.js');
|
||||||
|
} catch (error) {
|
||||||
|
err = error;
|
||||||
|
}
|
||||||
|
|
||||||
|
assert.sameValue(result, keep, 'result should still be the same as keep');
|
||||||
|
assert.sameValue(err, 'foo', 'second evaluation should repeat the same abrupt completion');
|
||||||
|
}
|
||||||
|
|
||||||
|
fn().then($DONE, $DONE);
|
|
@ -0,0 +1,8 @@
|
||||||
|
// Copyright (C) 2018 Leo Balter. All rights reserved.
|
||||||
|
// This code is governed by the BSD license found in the LICENSE file.
|
||||||
|
|
||||||
|
export var x = 42;
|
||||||
|
|
||||||
|
throw 'foo';
|
||||||
|
|
||||||
|
export var y = 1612;
|
|
@ -6,7 +6,7 @@ description: >
|
||||||
esid: sec-finishdynamicimport
|
esid: sec-finishdynamicimport
|
||||||
info: |
|
info: |
|
||||||
Runtime Semantics: FinishDynamicImport ( referencingScriptOrModule, specifier, promiseCapability, completion )
|
Runtime Semantics: FinishDynamicImport ( referencingScriptOrModule, specifier, promiseCapability, completion )
|
||||||
|
|
||||||
2. Otherwise,
|
2. Otherwise,
|
||||||
a. Assert: completion is a normal completion and completion.[[Value]] is undefined.
|
a. Assert: completion is a normal completion and completion.[[Value]] is undefined.
|
||||||
b. Let moduleRecord be ! HostResolveImportedModule(referencingScriptOrModule, specifier).
|
b. Let moduleRecord be ! HostResolveImportedModule(referencingScriptOrModule, specifier).
|
||||||
|
|
|
@ -0,0 +1,8 @@
|
||||||
|
// Copyright (C) 2018 Leo Balter. All rights reserved.
|
||||||
|
// This code is governed by the BSD license found in the LICENSE file.
|
||||||
|
|
||||||
|
var global = Function('return this;')();
|
||||||
|
|
||||||
|
global.test262Update('other');
|
||||||
|
|
||||||
|
export default 42;
|
|
@ -0,0 +1,31 @@
|
||||||
|
// Copyright (C) 2018 Leo Balter. All rights reserved.
|
||||||
|
// This code is governed by the BSD license found in the LICENSE file.
|
||||||
|
/*---
|
||||||
|
description: >
|
||||||
|
Resolve imports after a binding update
|
||||||
|
esid: sec-finishdynamicimport
|
||||||
|
info: |
|
||||||
|
Runtime Semantics: FinishDynamicImport ( referencingScriptOrModule, specifier, promiseCapability, completion )
|
||||||
|
|
||||||
|
2. Otherwise,
|
||||||
|
a. Assert: completion is a normal completion and completion.[[Value]] is undefined.
|
||||||
|
b. Let moduleRecord be ! HostResolveImportedModule(referencingScriptOrModule, specifier).
|
||||||
|
c. Assert: Evaluate has already been invoked on moduleRecord and successfully completed.
|
||||||
|
d. Let namespace be GetModuleNamespace(moduleRecord).
|
||||||
|
...
|
||||||
|
f. Otherwise, perform ! Call(promiseCapability.[[Resolve]], undefined, « namespace.[[Value]] »).
|
||||||
|
flags: [async]
|
||||||
|
features: [dynamic-import]
|
||||||
|
---*/
|
||||||
|
|
||||||
|
async function fn() {
|
||||||
|
const first = await import('update-to-dynamic-import_FIXTURE.js');
|
||||||
|
assert.sameValue(first.x, 'first', 'the other module has not been evaluated yet');
|
||||||
|
|
||||||
|
const other = await first.default();
|
||||||
|
|
||||||
|
assert.sameValue(first.x, 'other', 'the other module is only evaluated after calling import()');
|
||||||
|
assert.sameValue(other.default, 42);
|
||||||
|
}
|
||||||
|
|
||||||
|
fn().then($DONE, $DONE);
|
|
@ -0,0 +1,10 @@
|
||||||
|
// Copyright (C) 2018 Leo Balter. All rights reserved.
|
||||||
|
// This code is governed by the BSD license found in the LICENSE file.
|
||||||
|
|
||||||
|
Function('return this;')().test262Update = name => x = name;
|
||||||
|
|
||||||
|
export default function() {
|
||||||
|
return import('./update-to-dynamic-import-other_FIXTURE.js');
|
||||||
|
}
|
||||||
|
|
||||||
|
export var x = 'first';
|
Loading…
Reference in New Issue