From 255338141b2e22e7047e5591f890e452ddf82aa9 Mon Sep 17 00:00:00 2001 From: Mike Pennisi Date: Sun, 31 Mar 2019 22:15:44 -0400 Subject: [PATCH] Remove redundant tests These tests are syntactically equivalent to `test/language/statements/with/12.10.1-7-s.js` and may therefore be removed without degrading coverage. While `test/language/statements/with/12.10.1-9-s.js` differs slightly in the pattern used to enable strict mode, the relevant behavior of the "use strict" directive prologue is expressly tested via `test/language/directive-prologue/func-expr-inside-func-decl-parse.js`. --- test/language/statements/with/12.10.1-15-s.js | 15 ------------- test/language/statements/with/12.10.1-16-s.js | 15 ------------- test/language/statements/with/12.10.1-9-s.js | 21 ------------------- 3 files changed, 51 deletions(-) delete mode 100644 test/language/statements/with/12.10.1-15-s.js delete mode 100644 test/language/statements/with/12.10.1-16-s.js delete mode 100644 test/language/statements/with/12.10.1-9-s.js diff --git a/test/language/statements/with/12.10.1-15-s.js b/test/language/statements/with/12.10.1-15-s.js deleted file mode 100644 index b552a9a762..0000000000 --- a/test/language/statements/with/12.10.1-15-s.js +++ /dev/null @@ -1,15 +0,0 @@ -// Copyright (c) 2012 Ecma International. All rights reserved. -// This code is governed by the BSD license found in the LICENSE file. - -/*--- -es5id: 12.10.1-15-s -description: > - Strict Mode - SyntaxError is thrown when the RHS of a dot property - assignment utilizes WithStatement -flags: [onlyStrict] ----*/ - - -assert.throws(SyntaxError, function() { - eval("var obj = {}; obj.get = function (a) { with(a){} }; "); -}); diff --git a/test/language/statements/with/12.10.1-16-s.js b/test/language/statements/with/12.10.1-16-s.js deleted file mode 100644 index 5fe63c58fa..0000000000 --- a/test/language/statements/with/12.10.1-16-s.js +++ /dev/null @@ -1,15 +0,0 @@ -// Copyright (c) 2012 Ecma International. All rights reserved. -// This code is governed by the BSD license found in the LICENSE file. - -/*--- -es5id: 12.10.1-16-s -description: > - Strict Mode - SyntaxError is thrown when the RHS of an object - indexer assignment utilizes WithStatement -flags: [onlyStrict] ----*/ - - -assert.throws(SyntaxError, function() { - eval("var obj = {}; obj['get'] = function (a) { with(a){} }; "); -}); diff --git a/test/language/statements/with/12.10.1-9-s.js b/test/language/statements/with/12.10.1-9-s.js deleted file mode 100644 index 614c0d6439..0000000000 --- a/test/language/statements/with/12.10.1-9-s.js +++ /dev/null @@ -1,21 +0,0 @@ -// Copyright (c) 2012 Ecma International. All rights reserved. -// This code is governed by the BSD license found in the LICENSE file. - -/*--- -es5id: 12.10.1-9-s -description: > - with statement in strict mode throws SyntaxError (strict function - expression) -flags: [noStrict] ----*/ - - -assert.throws(SyntaxError, function() { - eval("\ - var f = function () {\ - \'use strict\';\ - var o = {}; \ - with (o) {}; \ - }\ - "); -});