From 2778324491d8f16d8caac5994fde9a5addb46892 Mon Sep 17 00:00:00 2001 From: Justin Ridgewell <jridgewell@google.com> Date: Tue, 31 Mar 2020 02:38:10 -0400 Subject: [PATCH] Fix tests --- .../lgcl-and-assignment-operator-bigint.js | 6 +++--- .../lgcl-and-assignment-operator-lhs-before-rhs.js | 2 +- .../lgcl-and-assignment-operator-no-set-put.js | 2 +- .../lgcl-and-assignment-operator-non-writeable-put.js | 2 +- .../lgcl-nullish-assignment-operator-bigint.js | 6 +++--- .../lgcl-nullish-assignment-operator-lhs-before-rhs.js | 8 ++++---- .../lgcl-nullish-assignment-operator-no-set-put.js | 2 +- .../lgcl-nullish-assignment-operator-non-extensible.js | 2 +- .../lgcl-nullish-assignment-operator-non-writeable-put.js | 2 +- .../lgcl-or-assignment-operator-bigint.js | 6 +++--- .../lgcl-or-assignment-operator-lhs-before-rhs.js | 2 +- .../lgcl-or-assignment-operator-no-set-put.js | 2 +- .../lgcl-or-assignment-operator-non-extensible.js | 2 +- .../lgcl-or-assignment-operator-non-writeable-put.js | 2 +- 14 files changed, 23 insertions(+), 23 deletions(-) diff --git a/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-bigint.js b/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-bigint.js index bdbc94a952..784dcfc8b9 100644 --- a/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-bigint.js +++ b/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-bigint.js @@ -21,7 +21,7 @@ info: | ---*/ var value = 0n; -assert.sameValue(value &&= 1n, "test", "(value &&= 1n) === 0n; where value = 0n"); +assert.sameValue(value &&= 1n, 0n, "(value &&= 1n) === 0n; where value = 0n"); -var value = 2n; -assert.sameValue(value &&= 1n, "test", "(value &&= 1n) === 1n; where value = 2n"); +value = 2n; +assert.sameValue(value &&= 1n, 1n, "(value &&= 1n) === 1n; where value = 2n"); diff --git a/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-lhs-before-rhs.js b/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-lhs-before-rhs.js index 4b858151d9..af6784bb58 100644 --- a/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-lhs-before-rhs.js +++ b/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-lhs-before-rhs.js @@ -23,7 +23,7 @@ assert.throws(DummyError, function() { base[prop()] &&= expr(); }); -assert.throws(Test262Error, function() { +assert.throws(TypeError, function() { var base = null; var prop = { toString: function() { diff --git a/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-no-set-put.js b/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-no-set-put.js index 73344c77dc..08d42d214f 100644 --- a/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-no-set-put.js +++ b/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-no-set-put.js @@ -22,7 +22,7 @@ Object.defineProperty(obj, "prop", { configurable: true }); -assert.throws(ReferenceError, function() { +assert.throws(TypeError, function() { obj.prop &&= 1; }); assert.sameValue(obj.prop, 2, "obj.prop"); diff --git a/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-non-writeable-put.js b/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-non-writeable-put.js index 39daa927a0..2dff8b5726 100644 --- a/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-non-writeable-put.js +++ b/test/language/expressions/logical-assignment/lgcl-and-assignment-operator-non-writeable-put.js @@ -20,7 +20,7 @@ Object.defineProperty(obj, "prop", { configurable: true }); -assert.throws(ReferenceError, function() { +assert.throws(TypeError, function() { obj.prop &&= 1; }); assert.sameValue(obj.prop, 2, "obj.prop"); diff --git a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-bigint.js b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-bigint.js index 3269418815..4626ce7307 100644 --- a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-bigint.js +++ b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-bigint.js @@ -20,7 +20,7 @@ info: | ---*/ var value = 0n; -assert.sameValue(value ??= 1n, "test", "(value ??= 1n) === 0n; where value = 0n"); +assert.sameValue(value ??= 1n, 0n, "(value ??= 1n) === 0n; where value = 0n"); -var value = 2n; -assert.sameValue(value ??= 1n, "test", "(value ??= 1n) === 2n; where value = 2n"); +value = 2n; +assert.sameValue(value ??= 1n, 2n, "(value ??= 1n) === 2n; where value = 2n"); diff --git a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-lhs-before-rhs.js b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-lhs-before-rhs.js index b5be4a4b0e..32d5d1bd55 100644 --- a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-lhs-before-rhs.js +++ b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-lhs-before-rhs.js @@ -23,7 +23,7 @@ assert.throws(DummyError, function() { base[prop()] ??= expr(); }); -assert.throws(Test262Error, function() { +assert.throws(TypeError, function() { var base = null; var prop = { toString: function() { @@ -45,9 +45,9 @@ function incr() { assert.sameValue(obj[incr()] ??= incr(), 2, "obj[incr()] ??= incr()"); assert.sameValue(obj[1], 2, "obj[1]"); -assert.sameValue(count, 1, "count"); +assert.sameValue(count, 2, "count"); -obj[2] = 1; -assert.sameValue(obj[incr()] ??= incr(), 3, "obj[incr()] ??= incr()"); +obj[3] = 1; +assert.sameValue(obj[incr()] ??= incr(), 1, "obj[incr()] ??= incr()"); assert.sameValue(obj[3], 1, "obj[3]"); assert.sameValue(count, 3, "count"); diff --git a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-no-set-put.js b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-no-set-put.js index f3d9c8be93..1d4441bfad 100644 --- a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-no-set-put.js +++ b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-no-set-put.js @@ -22,7 +22,7 @@ Object.defineProperty(obj, "prop", { configurable: true }); -assert.throws(ReferenceError, function() { +assert.throws(TypeError, function() { obj.prop ??= 1; }); assert.sameValue(obj.prop, undefined, "obj.prop"); diff --git a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-non-extensible.js b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-non-extensible.js index 1ea0b52f36..8556519956 100644 --- a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-non-extensible.js +++ b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-non-extensible.js @@ -15,7 +15,7 @@ features: [logical-assignment-operators] var obj = {}; Object.preventExtensions(obj); -assert.throws(ReferenceError, function() { +assert.throws(TypeError, function() { obj.prop ??= 1; }); assert.sameValue(obj.prop, undefined, "obj.prop"); diff --git a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-non-writeable-put.js b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-non-writeable-put.js index 9cb612b89d..67d219d618 100644 --- a/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-non-writeable-put.js +++ b/test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-non-writeable-put.js @@ -20,7 +20,7 @@ Object.defineProperty(obj, "prop", { configurable: true }); -assert.throws(ReferenceError, function() { +assert.throws(TypeError, function() { obj.prop ??= 1; }); assert.sameValue(obj.prop, undefined, "obj.prop"); diff --git a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-bigint.js b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-bigint.js index bf86322620..ccd4db2f10 100644 --- a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-bigint.js +++ b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-bigint.js @@ -21,7 +21,7 @@ info: | ---*/ var value = 0n; -assert.sameValue(value ||= 1n, "test", "(value ||= 1n) === 1n; where value = 0n"); +assert.sameValue(value ||= 1n, 1n, "(value ||= 1n) === 1n; where value = 0n"); -var value = 2n; -assert.sameValue(value ||= 1n, "test", "(value ||= 1n) === 2n; where value = 2n"); +value = 2n; +assert.sameValue(value ||= 1n, 2n, "(value ||= 1n) === 2n; where value = 2n"); diff --git a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-lhs-before-rhs.js b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-lhs-before-rhs.js index 65b9603a18..7cbe2ca43e 100644 --- a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-lhs-before-rhs.js +++ b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-lhs-before-rhs.js @@ -23,7 +23,7 @@ assert.throws(DummyError, function() { base[prop()] ||= expr(); }); -assert.throws(Test262Error, function() { +assert.throws(TypeError, function() { var base = null; var prop = { toString: function() { diff --git a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-no-set-put.js b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-no-set-put.js index 80528aa14a..c0856eea6e 100644 --- a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-no-set-put.js +++ b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-no-set-put.js @@ -22,7 +22,7 @@ Object.defineProperty(obj, "prop", { configurable: true }); -assert.throws(ReferenceError, function() { +assert.throws(TypeError, function() { obj.prop ||= 1; }); assert.sameValue(obj.prop, 0, "obj.prop"); diff --git a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-non-extensible.js b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-non-extensible.js index 2ec575c721..16275bf717 100644 --- a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-non-extensible.js +++ b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-non-extensible.js @@ -15,7 +15,7 @@ features: [logical-assignment-operators] var obj = {}; Object.preventExtensions(obj); -assert.throws(ReferenceError, function() { +assert.throws(TypeError, function() { obj.prop ||= 1; }); assert.sameValue(obj.prop, undefined, "obj.prop"); diff --git a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-non-writeable-put.js b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-non-writeable-put.js index a4233c6db9..2f57dd7089 100644 --- a/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-non-writeable-put.js +++ b/test/language/expressions/logical-assignment/lgcl-or-assignment-operator-non-writeable-put.js @@ -20,7 +20,7 @@ Object.defineProperty(obj, "prop", { configurable: true }); -assert.throws(ReferenceError, function() { +assert.throws(TypeError, function() { obj.prop ||= 1; }); assert.sameValue(obj.prop, 0, "obj.prop");