From 27a41b6321538197152c67f11279dc9b3204113c Mon Sep 17 00:00:00 2001
From: Alexey Shvayka <shvaikalesh@gmail.com>
Date: Sat, 11 Apr 2020 01:07:50 +0300
Subject: [PATCH] Improve malformed RegExp named groups coverage (#2568)

---
 .../non-unicode-malformed-lookbehind.js           | 15 +++++++++++++++
 .../RegExp/named-groups/non-unicode-malformed.js  | 12 +++++-------
 2 files changed, 20 insertions(+), 7 deletions(-)
 create mode 100644 test/annexB/built-ins/RegExp/named-groups/non-unicode-malformed-lookbehind.js

diff --git a/test/annexB/built-ins/RegExp/named-groups/non-unicode-malformed-lookbehind.js b/test/annexB/built-ins/RegExp/named-groups/non-unicode-malformed-lookbehind.js
new file mode 100644
index 0000000000..2d3aa1d4d9
--- /dev/null
+++ b/test/annexB/built-ins/RegExp/named-groups/non-unicode-malformed-lookbehind.js
@@ -0,0 +1,15 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: prod-GroupSpecifier
+description: >
+  \k is parsed as IdentityEscape as look-behind assertion is not a GroupName.
+features: [regexp-named-groups, regexp-lookbehind]
+---*/
+
+assert(/\k<a>(?<=>)a/.test("k<a>a"));
+assert(/(?<=>)\k<a>/.test(">k<a>"));
+
+assert(/\k<a>(?<!a)a/.test("k<a>a"));
+assert(/(?<!a>)\k<a>/.test("k<a>"));
diff --git a/test/annexB/built-ins/RegExp/named-groups/non-unicode-malformed.js b/test/annexB/built-ins/RegExp/named-groups/non-unicode-malformed.js
index 89911e13bf..98c0406287 100644
--- a/test/annexB/built-ins/RegExp/named-groups/non-unicode-malformed.js
+++ b/test/annexB/built-ins/RegExp/named-groups/non-unicode-malformed.js
@@ -6,7 +6,7 @@ description: >
   Named groups in Unicode RegExps have some syntax errors and some
   compatibility escape fallback behavior.
 esid: prod-GroupSpecifier
-features: [regexp-named-groups, regexp-lookbehind]
+features: [regexp-named-groups]
 includes: [compareArray.js]
 ---*/
 
@@ -17,11 +17,9 @@ assert(/\k/.test("k"));
 
 assert(/(?<a>\a)/.test("a"));
 
-assert(compareArray(["k<a>"], "xxxk<a>xxx".match(/\k<a>/)));
-assert(compareArray(["k<a"], "xxxk<a>xxx".match(/\k<a/)));
+assert.compareArray(["k<a>"], "xxxk<a>xxx".match(/\k<a>/));
+assert.compareArray(["k<a"], "xxxk<a>xxx".match(/\k<a/));
 
-// A couple of corner cases around '\k' as named back-references vs. identity
-// escapes.
-assert(/\k<a>(?<=>)a/.test("k<a>a"));
-assert(/\k<a>(?<!a)a/.test("k<a>a"));
 assert(/\k<a>(<a>x)/.test("k<a><a>x"));
+assert(/\k<a>\1/.test("k<a>\x01"));
+assert(/\1(b)\k<a>/.test("bk<a>"));