Apply review feedback for hashbang

features.txt

@@ -7,6 +7,10 @@
 #
 # https://github.com/tc39/process-document
 
+# Hashbang Grammar
+# https://github.com/tc39/proposal-hashbang
+hashbang
+
 # Object.fromEntries
 # https://github.com/tc39/proposal-object-from-entries
 Object.fromEntries

test/language/comments/hashbang/encoded-bang-041.js

@@ -0,0 +1,14 @@
+#\041
+/*---
+esid: pending
+description: >
+    Hashbang comments should not be allowed to have encoded characters \041
+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
+---*/

test/language/comments/hashbang/encoded-bang-u0021.js

@@ -2,9 +2,13 @@
 /*---
 esid: pending
 description: >
-    Hashbang comments should not be allowed to have encoded characters
+    Hashbang comments should not be allowed to have encoded characters \u0021
 info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
 flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/encoded-bang-u21.js

@@ -0,0 +1,14 @@
+#\u{21}
+/*---
+esid: pending
+description: >
+    Hashbang comments should not be allowed to have encoded characters \u{21}
+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
+---*/

test/language/comments/hashbang/encoded-bang-x21.js

@@ -0,0 +1,14 @@
+#\x21
+/*---
+esid: pending
+description: >
+    Hashbang comments should not be allowed to have encoded characters \x21
+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
+---*/

test/language/comments/hashbang/encoded-hash-043.js

@@ -0,0 +1,14 @@
+\043!
+/*---
+esid: pending
+description: >
+    Hashbang comments should not be allowed to have encoded characters \043
+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
+---*/

test/language/comments/hashbang/encoded-hash-u0023.js

@@ -2,9 +2,13 @@
 /*---
 esid: pending
 description: >
-    Hashbang comments should not be allowed to have encoded characters
+    Hashbang comments should not be allowed to have encoded characters \u0023
 info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
 flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/encoded-hash-u23.js

@@ -0,0 +1,14 @@
+\u{23}!
+/*---
+esid: pending
+description: >
+    Hashbang comments should not be allowed to have encoded characters \u{23}
+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
+---*/

test/language/comments/hashbang/encoded-hash-x23.js

@@ -0,0 +1,14 @@
+\x23!
+/*---
+esid: pending
+description: >
+    Hashbang comments should not be allowed to have encoded characters \x23
+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
+---*/

test/language/comments/hashbang/encoded-hashbang.js

@@ -7,4 +7,8 @@ info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
 flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/eval.js

@@ -5,6 +5,9 @@ description: >
 info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
+features: [hashbang]
 ---*/
 
 assert.sameValue(eval('#!\n'), undefined);
+assert.sameValue(eval('#!\n1'), 1)
+assert.sameValue(eval('#!2\n'), undefined);

test/language/comments/hashbang/function-body.js

@@ -9,6 +9,10 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/
+
+DONOTEVALUATE();
+
 function fn() {#!
 }

test/language/comments/hashbang/function-constructor.js

@@ -5,11 +5,12 @@ description: >
 info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
+features: [hashbang]
 ---*/
 const AsyncFunction = (async function (){}).constructor;
 const GeneratorFunction = (function *(){}).constructor;
 const AsyncGeneratorFunction = (async function *(){}).constructor;
-for (ctor of [
+for (const ctor of [
   Function,
   AsyncFunction,
   GeneratorFunction,

test/language/comments/hashbang/module.js

@@ -7,4 +7,5 @@ info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
 flags: [module]
+features: [hashbang]
 ---*/

test/language/comments/hashbang/multi-line-comment.js

@@ -1,4 +1,5 @@
 #!/*
+DONOTEVALUATE();
 these characters should not be considered within a comment
 */
 /*---
@@ -12,4 +13,5 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/no-line-separator.js

@@ -6,6 +6,7 @@ info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
 flags: [raw]
+features: [hashbang]
 ---*/
 
-eval('#!');
+assert.sameValue(eval('#!'), undefined);

test/language/comments/hashbang/not-empty.js

@@ -7,5 +7,6 @@ info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
 flags: [raw]
+features: [hashbang]
 ---*/
 

test/language/comments/hashbang/preceding-directive-prologue-sc.js

@@ -0,0 +1,15 @@
+"use strict";
+#!
+/*---
+esid: pending
+description: >
+    Hashbang comments should only be allowed at start of source texts and should not be preceded by DirectivePrologues.
+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+negative:
+  phase: parse
+  type: SyntaxError
+features: [hashbang]
+---*/

test/language/comments/hashbang/preceding-directive-prologue.js

@@ -11,4 +11,5 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/preceding-empty-statement.js

@@ -10,4 +10,5 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/preceding-hashbang.js

@@ -11,4 +11,5 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/preceding-line-comment.js

@@ -11,4 +11,5 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/preceding-multi-line-comment.js

@@ -11,4 +11,5 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/preceding-whitespace.js

@@ -1,4 +1,4 @@
-    #!
+ #!
 /*---
 esid: pending
 description: >
@@ -10,4 +10,5 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/

test/language/comments/hashbang/statement-block.js

@@ -9,6 +9,7 @@ flags: [raw]
 negative:
   phase: parse
   type: SyntaxError
+features: [hashbang]
 ---*/
 {
   #!

test/language/comments/hashbang/use-strict.js

@@ -2,11 +2,12 @@
 /*---
 esid: pending
 description: >
-    Hashbang comments should not be interpretted and should not generate DirectivePrologues.
+    Hashbang comments should not be interpreted and should not generate DirectivePrologues.
 info: |
     HashbangComment::
       #! SingleLineCommentChars[opt]
 flags: [raw]
+features: [hashbang]
 ---*/
 
 with ({}) {}