tyler.durden
/
test262
mirror of https://github.com/tc39/test262.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix false negative in for-in test 

As originally written, this test would spuriously pass when the deleted
property was incorrectly visited by enumation but correctly removed from
the object. In such cases, the accumulator string would take the form

    "aa1baundefinedca3"

And satisfy all conditions intended to highlight implementation errors.

Refactor the test to avoid false negative by using an object with a null
prototype and verifying the exact contents of the accumulator string.
This commit is contained in:
Mike Pennisi 2022-04-01 18:16:06 -04:00 committed by rwaldron
parent 833a784f20
commit 3c88e9b619
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/language/statements/for-in/S12.6.4_A7_T2.js
View File

@ -13,7 +13,10 @@ description: >
var __obj, __accum; var __obj, __accum;
__obj={aa:1,ba:2,ca:3}; __obj = Object.create(null);
__obj.aa = 1;
__obj.ba = 2;
__obj.ca = 3;
__accum=""; __accum="";
@ -25,23 +28,10 @@ for (var __key in __obj){
} }
assert(
////////////////////////////////////////////////////////////////////////////// __accum === "aa1ca3" || __accum === "ca3aa1",
//CHECK#1 "Unexpected value: '" + __accum + "'"
if (!((__accum.indexOf("aa1")!==-1)&&(__accum.indexOf("ca3")!==-1))) { );
throw new Test262Error('#1: (__accum.indexOf("aa1")!==-1)&&(__accum.indexOf("ca3")!==-1)');
}
//
//////////////////////////////////////////////////////////////////////////////
//////////////////////////////////////////////////////////////////////////////
//CHECK#2
if (__accum.indexOf("ba2")!==-1) {
throw new Test262Error('#2: __accum.indexOf("ba2") === -1. Actual: __accum.indexOf("ba2") ==='+ __accum.indexOf("ba2") );
}
//
//////////////////////////////////////////////////////////////////////////////
// erasator is the hash map terminator // erasator is the hash map terminator
function erasator_T_1000(hash_map, charactr){ function erasator_T_1000(hash_map, charactr){