Avoid writing to top-level vars named "top", for browser compat (#794)

The HTML spec requires browsers define a non-configurable property
of the global (window) object named "top". This makes it
impossible for a browser to successfully run a test in strict mode
if said test attempts to write to a global variable named "top".
This commit is contained in:
Kevin Gibbons 2016-11-22 09:02:40 -08:00 committed by Leo Balter
parent c779cba592
commit 3ed2c78600
2 changed files with 24 additions and 24 deletions

View File

@ -11,26 +11,26 @@ es5id: 13.2.2_A5_T1
description: Declaring a function with "function __FACTORY(arg1, arg2)" description: Declaring a function with "function __FACTORY(arg1, arg2)"
---*/ ---*/
var __VOLUME, __RED, __ID, __TOP, __BOTTOM, __LEFT, color, top, left, __device; var __VOLUME, __RED, __ID, __BOTTOM, __TOP, __LEFT, color, bottom, left, __device;
__VOLUME=8; __VOLUME=8;
__RED="red"; __RED="red";
__ID=12342; __ID=12342;
__TOP=1.1; __BOTTOM=1.1;
__BOTTOM=0.0; __TOP=0.1;
__LEFT=0.0; __LEFT=0.5;
function __FACTORY(arg1, arg2){ function __FACTORY(arg1, arg2){
this.volume=__VOLUME; this.volume=__VOLUME;
color=__RED; color=__RED;
this.id=arg1; this.id=arg1;
top=arg2; bottom=arg2;
this.bottom=arguments[3]; this.top=arguments[2];
left=arguments[4]; left=arguments[3];
}; };
__device = new __FACTORY(__ID, __TOP, __BOTTOM, __LEFT); __device = new __FACTORY(__ID, __BOTTOM, __TOP, __LEFT);
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
//CHECK#1 //CHECK#1
@ -50,8 +50,8 @@ if (__device.volume !== __VOLUME) {
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
//CHECK#3 //CHECK#3
if (__device.top !== undefined) { if (__device.bottom !== undefined) {
$ERROR('#3: __device.top === undefined. Actual: __device.top ==='+__device.top); $ERROR('#3: __device.bottom === undefined. Actual: __device.bottom ==='+__device.bottom);
} }
// //
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
@ -74,8 +74,8 @@ if (__device.left !== undefined) {
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
//CHECK#6 //CHECK#6
if (__device.bottom !== __BOTTOM) { if (__device.top !== __TOP) {
$ERROR('#6: __device.bottom === __BOTTOM. Actual: __device.bottom ==='+__device.bottom); $ERROR('#6: __device.top === __TOP. Actual: __device.top ==='+__device.top);
} }
// //
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////

View File

@ -11,26 +11,26 @@ es5id: 13.2.2_A5_T2
description: Declaring a function with "__FACTORY = function(arg1, arg2)" description: Declaring a function with "__FACTORY = function(arg1, arg2)"
---*/ ---*/
var __VOLUME, __RED, __ID, __TOP, __BOTTOM, __LEFT, __FACTORY, color, top, left, __device; var __VOLUME, __RED, __ID, __BOTTOM, __TOP, __LEFT, __FACTORY, color, bottom, left, __device;
__VOLUME=8; __VOLUME=8;
__RED="red"; __RED="red";
__ID=12342; __ID=12342;
__TOP=1.1; __BOTTOM=1.1;
__BOTTOM=0.0; __TOP=0.1;
__LEFT=0.0; __LEFT=0.5;
__FACTORY = function(arg1, arg2){ __FACTORY = function(arg1, arg2){
this.volume=__VOLUME; this.volume=__VOLUME;
color=__RED; color=__RED;
this.id=arg1; this.id=arg1;
top=arg2; bottom=arg2;
this.bottom=arguments[3]; this.top=arguments[2];
left=arguments[4]; left=arguments[3];
}; };
__device = new __FACTORY(__ID, __TOP, __BOTTOM, __LEFT); __device = new __FACTORY(__ID, __BOTTOM, __TOP, __LEFT);
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
//CHECK#1 //CHECK#1
@ -50,8 +50,8 @@ if (__device.volume !== __VOLUME) {
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
//CHECK#3 //CHECK#3
if (__device.top !== undefined) { if (__device.bottom !== undefined) {
$ERROR('#3: __device.top === undefined. Actual: __device.top ==='+__device.top); $ERROR('#3: __device.bottom === undefined. Actual: __device.bottom ==='+__device.bottom);
} }
// //
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
@ -74,8 +74,8 @@ if (__device.left !== undefined) {
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
//CHECK#6 //CHECK#6
if (__device.bottom !== __BOTTOM) { if (__device.top !== __TOP) {
$ERROR('#6: __device.bottom === __BOTTOM. Actual: __device.bottom ==='+__device.bottom); $ERROR('#6: __device.top === __TOP. Actual: __device.top ==='+__device.top);
} }
// //
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////