From 41110ab0d4c2a4986f67cdbfdc52be6d5ec69001 Mon Sep 17 00:00:00 2001 From: Mike Pennisi Date: Sun, 28 Oct 2018 22:44:34 -0400 Subject: [PATCH] Correct tests for line terminators within comments Four tests were documented as asserting the interpretation of line terminators within multi-line comments, but the source code did not actually demonstrate this condition. Introduce new tests that demonstrate the intended functionality and place them in the correct directory. --- .../comments/multi-line-asi-carriage-return.js | 17 +++++++++++++++++ .../comments/multi-line-asi-line-feed.js | 18 ++++++++++++++++++ .../comments/multi-line-asi-line-separator.js | 17 +++++++++++++++++ .../multi-line-asi-paragraph-separator.js | 17 +++++++++++++++++ test/language/line-terminators/7.3-11.js | 15 --------------- test/language/line-terminators/7.3-12.js | 15 --------------- test/language/line-terminators/7.3-13.js | 15 --------------- test/language/line-terminators/7.3-14.js | 15 --------------- 8 files changed, 69 insertions(+), 60 deletions(-) create mode 100644 test/language/comments/multi-line-asi-carriage-return.js create mode 100644 test/language/comments/multi-line-asi-line-feed.js create mode 100644 test/language/comments/multi-line-asi-line-separator.js create mode 100644 test/language/comments/multi-line-asi-paragraph-separator.js delete mode 100644 test/language/line-terminators/7.3-11.js delete mode 100644 test/language/line-terminators/7.3-12.js delete mode 100644 test/language/line-terminators/7.3-13.js delete mode 100644 test/language/line-terminators/7.3-14.js diff --git a/test/language/comments/multi-line-asi-carriage-return.js b/test/language/comments/multi-line-asi-carriage-return.js new file mode 100644 index 0000000000..e8b6c97502 --- /dev/null +++ b/test/language/comments/multi-line-asi-carriage-return.js @@ -0,0 +1,17 @@ +// Copyright (c) 2018 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +es5id: 7.4 +esid: sec-comments +description: > + A multi-line comment containing a carriage return should be considered a + LineTerminator +info: > + Comments behave like white space and are discarded except that, if a + MultiLineComment contains a line terminator code point, then the entire + comment is considered to be a LineTerminator for purposes of parsing by the + syntactic grammar. +---*/ + +''/* */'' diff --git a/test/language/comments/multi-line-asi-line-feed.js b/test/language/comments/multi-line-asi-line-feed.js new file mode 100644 index 0000000000..d253f837f9 --- /dev/null +++ b/test/language/comments/multi-line-asi-line-feed.js @@ -0,0 +1,18 @@ +// Copyright (c) 2018 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +es5id: 7.4 +esid: sec-comments +description: > + A multi-line comment containing a line feed should be considered a + LineTerminator +info: > + Comments behave like white space and are discarded except that, if a + MultiLineComment contains a line terminator code point, then the entire + comment is considered to be a LineTerminator for purposes of parsing by the + syntactic grammar. +---*/ + +''/* +*/'' diff --git a/test/language/comments/multi-line-asi-line-separator.js b/test/language/comments/multi-line-asi-line-separator.js new file mode 100644 index 0000000000..a7c102929f --- /dev/null +++ b/test/language/comments/multi-line-asi-line-separator.js @@ -0,0 +1,17 @@ +// Copyright (c) 2018 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +es5id: 7.4 +esid: sec-comments +description: > + A multi-line comment containing a line separator should be considered a + LineTerminator +info: > + Comments behave like white space and are discarded except that, if a + MultiLineComment contains a line terminator code point, then the entire + comment is considered to be a LineTerminator for purposes of parsing by the + syntactic grammar. +---*/ + +''/*
*/'' diff --git a/test/language/comments/multi-line-asi-paragraph-separator.js b/test/language/comments/multi-line-asi-paragraph-separator.js new file mode 100644 index 0000000000..4b1c0ed534 --- /dev/null +++ b/test/language/comments/multi-line-asi-paragraph-separator.js @@ -0,0 +1,17 @@ +// Copyright (c) 2018 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +es5id: 7.4 +esid: sec-comments +description: > + A multi-line comment containing a paragrah separator should be considered a + LineTerminator +info: > + Comments behave like white space and are discarded except that, if a + MultiLineComment contains a line terminator code point, then the entire + comment is considered to be a LineTerminator for purposes of parsing by the + syntactic grammar. +---*/ + +''/*
*/'' diff --git a/test/language/line-terminators/7.3-11.js b/test/language/line-terminators/7.3-11.js deleted file mode 100644 index 230edb1dd9..0000000000 --- a/test/language/line-terminators/7.3-11.js +++ /dev/null @@ -1,15 +0,0 @@ -// Copyright (c) 2012 Ecma International. All rights reserved. -// This code is governed by the BSD license found in the LICENSE file. - -/*--- -es5id: 7.3-11 -description: > - 7.3 - ES5 specifies that a multiline comment that contains a line - terminator character (\u2028) must be treated as a single - line terminator for the purposes of semicolon insertion ----*/ - - /*MultiLine - Comments - \u2028 var = ; - */ diff --git a/test/language/line-terminators/7.3-12.js b/test/language/line-terminators/7.3-12.js deleted file mode 100644 index add89852a5..0000000000 --- a/test/language/line-terminators/7.3-12.js +++ /dev/null @@ -1,15 +0,0 @@ -// Copyright (c) 2012 Ecma International. All rights reserved. -// This code is governed by the BSD license found in the LICENSE file. - -/*--- -es5id: 7.3-12 -description: > - 7.3 - ES5 specifies that a multiline comment that contains a line - terminator character (\u2029) must be treated as a single - line terminator for the purposes of semicolon insertion ----*/ - - /*MultiLine - Comments - \u2029 var = ; - */ diff --git a/test/language/line-terminators/7.3-13.js b/test/language/line-terminators/7.3-13.js deleted file mode 100644 index d28bceae74..0000000000 --- a/test/language/line-terminators/7.3-13.js +++ /dev/null @@ -1,15 +0,0 @@ -// Copyright (c) 2012 Ecma International. All rights reserved. -// This code is governed by the BSD license found in the LICENSE file. - -/*--- -es5id: 7.3-13 -description: > - 7.3 - ES5 specifies that a multiline comment that contains a line - terminator character (\u000D) must be treated as a single - line terminator for the purposes of semicolon insertion ----*/ - - /*MultiLine - Comments - \u000D var = ; - */ diff --git a/test/language/line-terminators/7.3-14.js b/test/language/line-terminators/7.3-14.js deleted file mode 100644 index 211d3184ee..0000000000 --- a/test/language/line-terminators/7.3-14.js +++ /dev/null @@ -1,15 +0,0 @@ -// Copyright (c) 2012 Ecma International. All rights reserved. -// This code is governed by the BSD license found in the LICENSE file. - -/*--- -es5id: 7.3-14 -description: > - 7.3 - ES5 specifies that a multiline comment that contains a line - terminator character (\u000A) must be treated as a single - line terminator for the purposes of semicolon insertion ----*/ - - /*MultiLine - Comments - \u000A var = ; - */