Expand largestUnit and smallestUnit invalid strings tests

Some of these (in PlainDate) had already been rewritten to test more
invalid strings that are otherwise valid units. This commit takes these
improvements and brings them to all of the similar tests for other types'
since() and until() methods.

test/built-ins/Temporal/Instant/prototype/since/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.Instant(1_000_000_000_000_000_000n);
 const later = new Temporal.Instant(1_000_090_061_987_654_321n);
-assert.throws(RangeError, () => later.since(earlier, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "years", "months", "weeks", "days", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { largestUnit }));
+}

test/built-ins/Temporal/Instant/prototype/since/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.Instant(1_000_000_000_000_000_000n);
 const later = new Temporal.Instant(1_000_090_061_987_654_321n);
-assert.throws(RangeError, () => later.since(earlier, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "years", "months", "weeks", "days", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { smallestUnit }));
+}

test/built-ins/Temporal/Instant/prototype/until/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.Instant(1_000_000_000_000_000_000n);
 const later = new Temporal.Instant(1_000_090_061_987_654_321n);
-assert.throws(RangeError, () => earlier.until(later, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "years", "months", "weeks", "days", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { largestUnit }));
+}

test/built-ins/Temporal/Instant/prototype/until/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.Instant(1_000_000_000_000_000_000n);
 const later = new Temporal.Instant(1_000_090_061_987_654_321n);
-assert.throws(RangeError, () => earlier.until(later, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "years", "months", "weeks", "days", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { smallestUnit }));
+}

test/built-ins/Temporal/PlainDate/prototype/since/largestunit-invalid-string.js

@@ -9,7 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainDate(2000, 5, 2);
 const later = new Temporal.PlainDate(2001, 6, 3);
-const values = ["hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
+const values = ["era", "eraYear", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
 for (const largestUnit of values) {
   assert.throws(RangeError, () => later.since(earlier, { largestUnit }));
 }

test/built-ins/Temporal/PlainDate/prototype/since/smallestunit-invalid-string.js

@@ -9,7 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainDate(2000, 5, 2);
 const later = new Temporal.PlainDate(2001, 6, 3);
-const values = ["era", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
+const values = ["era", "eraYear", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
 for (const smallestUnit of values) {
   assert.throws(RangeError, () => later.since(earlier, { smallestUnit }));
 }

test/built-ins/Temporal/PlainDate/prototype/until/largestunit-invalid-string.js

@@ -9,7 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainDate(2000, 5, 2);
 const later = new Temporal.PlainDate(2001, 6, 3);
-const values = ["hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
+const values = ["era", "eraYear", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
 for (const largestUnit of values) {
   assert.throws(RangeError, () => earlier.until(later, { largestUnit }));
 }

test/built-ins/Temporal/PlainDate/prototype/until/smallestunit-invalid-string.js

@@ -9,7 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainDate(2000, 5, 2);
 const later = new Temporal.PlainDate(2001, 6, 3);
-const values = ["era", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
+const values = ["era", "eraYear", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
 for (const smallestUnit of values) {
   assert.throws(RangeError, () => earlier.until(later, { smallestUnit }));
 }

test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainDateTime(2000, 5, 2, 12, 34, 56, 0, 0, 0);
 const later = new Temporal.PlainDateTime(2001, 6, 3, 13, 35, 57, 987, 654, 321);
-assert.throws(RangeError, () => later.since(earlier, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { largestUnit }));
+}

test/built-ins/Temporal/PlainDateTime/prototype/since/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainDateTime(2000, 5, 2, 12, 34, 56, 0, 0, 0);
 const later = new Temporal.PlainDateTime(2000, 5, 3, 13, 35, 57, 987, 654, 321);
-assert.throws(RangeError, () => later.since(earlier, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { smallestUnit }));
+}

test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainDateTime(2000, 5, 2, 12, 34, 56, 0, 0, 0);
 const later = new Temporal.PlainDateTime(2001, 6, 3, 13, 35, 57, 987, 654, 321);
-assert.throws(RangeError, () => earlier.until(later, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { largestUnit }));
+}

test/built-ins/Temporal/PlainDateTime/prototype/until/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainDateTime(2000, 5, 2, 12, 34, 56, 0, 0, 0);
 const later = new Temporal.PlainDateTime(2000, 5, 3, 13, 35, 57, 987, 654, 321);
-assert.throws(RangeError, () => earlier.until(later, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { smallestUnit }));
+}

test/built-ins/Temporal/PlainTime/prototype/since/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainTime(12, 34, 56, 0, 0, 0);
 const later = new Temporal.PlainTime(13, 35, 57, 987, 654, 321);
-assert.throws(RangeError, () => later.since(earlier, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "years", "months", "weeks", "days", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { largestUnit }));
+}

test/built-ins/Temporal/PlainTime/prototype/since/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainTime(12, 34, 56, 0, 0, 0);
 const later = new Temporal.PlainTime(13, 35, 57, 987, 654, 321);
-assert.throws(RangeError, () => later.since(earlier, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "years", "months", "weeks", "days", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { smallestUnit }));
+}

test/built-ins/Temporal/PlainTime/prototype/until/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainTime(12, 34, 56, 0, 0, 0);
 const later = new Temporal.PlainTime(13, 35, 57, 987, 654, 321);
-assert.throws(RangeError, () => earlier.until(later, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "years", "months", "weeks", "days", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { largestUnit }));
+}

test/built-ins/Temporal/PlainTime/prototype/until/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainTime(12, 34, 56, 0, 0, 0);
 const later = new Temporal.PlainTime(13, 35, 57, 987, 654, 321);
-assert.throws(RangeError, () => earlier.until(later, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "years", "months", "weeks", "days", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { smallestUnit }));
+}

test/built-ins/Temporal/PlainYearMonth/prototype/since/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainYearMonth(2000, 5);
 const later = new Temporal.PlainYearMonth(2001, 6);
-assert.throws(RangeError, () => later.since(earlier, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "weeks", "days", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { largestUnit }));
+}

test/built-ins/Temporal/PlainYearMonth/prototype/since/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainYearMonth(2000, 5);
 const later = new Temporal.PlainYearMonth(2001, 6);
-assert.throws(RangeError, () => later.since(earlier, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "weeks", "days", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { smallestUnit }));
+}

test/built-ins/Temporal/PlainYearMonth/prototype/until/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainYearMonth(2000, 5);
 const later = new Temporal.PlainYearMonth(2001, 6);
-assert.throws(RangeError, () => earlier.until(later, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "weeks", "days", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { largestUnit }));
+}

test/built-ins/Temporal/PlainYearMonth/prototype/until/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.PlainYearMonth(2000, 5);
 const later = new Temporal.PlainYearMonth(2001, 6);
-assert.throws(RangeError, () => earlier.until(later, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "weeks", "days", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { smallestUnit }));
+}

test/built-ins/Temporal/ZonedDateTime/prototype/since/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.ZonedDateTime(1_000_000_000_000_000_000n, "UTC");
 const later = new Temporal.ZonedDateTime(1_000_090_061_987_654_321n, "UTC");
-assert.throws(RangeError, () => later.since(earlier, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { largestUnit }));
+}

test/built-ins/Temporal/ZonedDateTime/prototype/since/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.ZonedDateTime(1_000_000_000_000_000_000n, "UTC");
 const later = new Temporal.ZonedDateTime(1_000_090_061_987_654_321n, "UTC");
-assert.throws(RangeError, () => later.since(earlier, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => later.since(earlier, { smallestUnit }));
+}

test/built-ins/Temporal/ZonedDateTime/prototype/until/largestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.ZonedDateTime(1_000_000_000_000_000_000n, "UTC");
 const later = new Temporal.ZonedDateTime(1_000_090_061_987_654_321n, "UTC");
-assert.throws(RangeError, () => earlier.until(later, { largestUnit: "other string" }));
+const values = ["era", "eraYear", "other string"];
+for (const largestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { largestUnit }));
+}

test/built-ins/Temporal/ZonedDateTime/prototype/until/smallestunit-invalid-string.js

@@ -9,4 +9,7 @@ features: [Temporal]
 
 const earlier = new Temporal.ZonedDateTime(1_000_000_000_000_000_000n, "UTC");
 const later = new Temporal.ZonedDateTime(1_000_090_061_987_654_321n, "UTC");
-assert.throws(RangeError, () => earlier.until(later, { smallestUnit: "other string" }));
+const values = ["era", "eraYear", "other string"];
+for (const smallestUnit of values) {
+  assert.throws(RangeError, () => earlier.until(later, { smallestUnit }));
+}