From 45495094e24dffc614e9f08b8ed9a84dc0a71818 Mon Sep 17 00:00:00 2001 From: rwaldron Date: Tue, 20 Jul 2021 10:45:47 -0400 Subject: [PATCH] fix: updates per review --- ...-function-arguments-are-wrapped-into-the-inner-realm.js | 2 +- ...rapped-function-from-return-values-share-no-identity.js | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/test/built-ins/Realm/prototype/evaluate/wrapped-function-arguments-are-wrapped-into-the-inner-realm.js b/test/built-ins/Realm/prototype/evaluate/wrapped-function-arguments-are-wrapped-into-the-inner-realm.js index 985a7403e5..1afcd6704f 100644 --- a/test/built-ins/Realm/prototype/evaluate/wrapped-function-arguments-are-wrapped-into-the-inner-realm.js +++ b/test/built-ins/Realm/prototype/evaluate/wrapped-function-arguments-are-wrapped-into-the-inner-realm.js @@ -17,7 +17,7 @@ const r = new Realm(); const blueFn = (x, y) => x + y; const redWrappedFn = r.evaluate(` -0, function(blueWrappedFn, a, b, c) { +0, (blueWrappedFn, a, b, c) => { return blueWrappedFn(a, b) * c; } `); diff --git a/test/built-ins/Realm/prototype/evaluate/wrapped-function-from-return-values-share-no-identity.js b/test/built-ins/Realm/prototype/evaluate/wrapped-function-from-return-values-share-no-identity.js index 9e999f7230..dec3e68179 100644 --- a/test/built-ins/Realm/prototype/evaluate/wrapped-function-from-return-values-share-no-identity.js +++ b/test/built-ins/Realm/prototype/evaluate/wrapped-function-from-return-values-share-no-identity.js @@ -43,11 +43,13 @@ const wrappedOrdinary = r.evaluate('() => fn')(); assert.sameValue(typeof wrappedOrdinary, 'function', 'ordinary function wrapped'); assert.sameValue(wrappedOrdinary(), 42, 'ordinary, return'); assert.sameValue(wrappedOrdinary.x, undefined, 'ordinary, no property shared'); +assert.sameValue(Object.prototype.hasOwnProperty.call(wrappedOrdinary, 'x'), false, 'ordinary, no own property shared'); const wrappedArrow = r.evaluate('() => arrow')(); assert.sameValue(typeof wrappedArrow, 'function', 'arrow function wrapped'); assert.sameValue(wrappedArrow(7), 14, 'arrow function, return'); assert.sameValue(wrappedArrow.x, undefined, 'arrow function, no property'); +assert.sameValue(Object.prototype.hasOwnProperty.call(wrappedArrow, 'x'), false, 'arrow function, no own property shared'); const wrappedProxied = r.evaluate('() => pFn')(); assert.sameValue(typeof wrappedProxied, 'function', 'proxied ordinary function wrapped'); @@ -55,13 +57,16 @@ assert.sameValue(r.evaluate('pFn.used'), undefined, 'pFn not called yet'); assert.sameValue(wrappedProxied(), 39, 'return of the proxied callable'); assert.sameValue(r.evaluate('pFn.used'), 1, 'pfn called'); assert.sameValue(wrappedProxied.x, undefined, 'proxy callable, no property'); +assert.sameValue(Object.prototype.hasOwnProperty.call(wrappedProxied, 'x'), false, 'proxy callable, no own property shared'); const wrappedAsync = r.evaluate('() => aFn')(); assert.sameValue(typeof wrappedAsync, 'function', 'async function wrapped'); assert.throws(TypeError, () => wrappedAsync(), 'wrapped function cannot return non callable object'); -assert.sameValue(wrappedAsync.x, undefined, 'async fn, no property'); +assert.sameValue(wrappedAsync.x, undefined, 'async function, no property'); +assert.sameValue(Object.prototype.hasOwnProperty.call(wrappedAsync, 'x'), false, 'async function, no own property shared'); const wrappedGenerator = r.evaluate('() => genFn')(); assert.sameValue(typeof wrappedGenerator, 'function', 'gen function wrapped'); assert.throws(TypeError, () => wrappedGenerator(), 'wrapped function cannot return non callable object'); assert.sameValue(wrappedGenerator.x, undefined, 'generator, no property'); +assert.sameValue(Object.prototype.hasOwnProperty.call(wrappedGenerator, 'x'), false, 'generator, no own property shared');