From 4f20476e0a15ddad2331b19af456efa987999ba5 Mon Sep 17 00:00:00 2001 From: Philip Chimento Date: Tue, 18 Jan 2022 15:41:07 -0800 Subject: [PATCH] Add tests for largestUnit/smallestUnit mismatch These tests already existed for PlainDate. Copy them to the other types (and use the constructor instead of from() in order to be as simple as possible) --- .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 4 ++-- .../largestunit-smallestunit-mismatch.js | 4 ++-- .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ .../largestunit-smallestunit-mismatch.js | 19 +++++++++++++++++++ 12 files changed, 194 insertions(+), 4 deletions(-) create mode 100644 test/built-ins/Temporal/Instant/prototype/since/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/Instant/prototype/until/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/PlainTime/prototype/since/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/PlainTime/prototype/until/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/PlainYearMonth/prototype/since/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/PlainYearMonth/prototype/until/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/ZonedDateTime/prototype/since/largestunit-smallestunit-mismatch.js create mode 100644 test/built-ins/Temporal/ZonedDateTime/prototype/until/largestunit-smallestunit-mismatch.js diff --git a/test/built-ins/Temporal/Instant/prototype/since/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/Instant/prototype/since/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..0b014ae7b8 --- /dev/null +++ b/test/built-ins/Temporal/Instant/prototype/since/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.instant.prototype.since +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.Instant(1_000_000_000_000_000_000n); +const later = new Temporal.Instant(1_000_090_061_987_654_321n); +const units = ["hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => later.since(earlier, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/Instant/prototype/until/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/Instant/prototype/until/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..8393f854bc --- /dev/null +++ b/test/built-ins/Temporal/Instant/prototype/until/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.instant.prototype.until +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.Instant(1_000_000_000_000_000_000n); +const later = new Temporal.Instant(1_000_090_061_987_654_321n); +const units = ["hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => earlier.until(later, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/PlainDate/prototype/since/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/PlainDate/prototype/since/largestunit-smallestunit-mismatch.js index 8b1894c3fd..2bd8ea8aa2 100644 --- a/test/built-ins/Temporal/PlainDate/prototype/since/largestunit-smallestunit-mismatch.js +++ b/test/built-ins/Temporal/PlainDate/prototype/since/largestunit-smallestunit-mismatch.js @@ -7,8 +7,8 @@ description: RangeError thrown when smallestUnit is larger than largestUnit features: [Temporal] ---*/ -const earlier = Temporal.PlainDate.from("2019-01-08"); -const later = Temporal.PlainDate.from("2021-09-07"); +const earlier = new Temporal.PlainDate(2000, 5, 2); +const later = new Temporal.PlainDate(2001, 6, 3); const units = ["years", "months", "weeks", "days"]; for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { diff --git a/test/built-ins/Temporal/PlainDate/prototype/until/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/PlainDate/prototype/until/largestunit-smallestunit-mismatch.js index 7b2334722f..3da479c602 100644 --- a/test/built-ins/Temporal/PlainDate/prototype/until/largestunit-smallestunit-mismatch.js +++ b/test/built-ins/Temporal/PlainDate/prototype/until/largestunit-smallestunit-mismatch.js @@ -7,8 +7,8 @@ description: RangeError thrown when smallestUnit is larger than largestUnit features: [Temporal] ---*/ -const earlier = Temporal.PlainDate.from("2019-01-08"); -const later = Temporal.PlainDate.from("2021-09-07"); +const earlier = new Temporal.PlainDate(2000, 5, 2); +const later = new Temporal.PlainDate(2001, 6, 3); const units = ["years", "months", "weeks", "days"]; for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { diff --git a/test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..676f81be56 --- /dev/null +++ b/test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.plaindatetime.prototype.since +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.PlainDateTime(2000, 5, 2, 12, 34, 56, 0, 0, 0); +const later = new Temporal.PlainDateTime(2001, 6, 3, 13, 35, 57, 987, 654, 321); +const units = ["years", "months", "weeks", "days", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => later.since(earlier, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..7f15b68a80 --- /dev/null +++ b/test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.plaindatetime.prototype.until +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.PlainDateTime(2000, 5, 2, 12, 34, 56, 0, 0, 0); +const later = new Temporal.PlainDateTime(2001, 6, 3, 13, 35, 57, 987, 654, 321); +const units = ["years", "months", "weeks", "days", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => earlier.until(later, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/PlainTime/prototype/since/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/PlainTime/prototype/since/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..b98fd74384 --- /dev/null +++ b/test/built-ins/Temporal/PlainTime/prototype/since/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.plaintime.prototype.since +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.PlainTime(12, 34, 56, 0, 0, 0); +const later = new Temporal.PlainTime(13, 35, 57, 987, 654, 321); +const units = ["hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => later.since(earlier, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/PlainTime/prototype/until/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/PlainTime/prototype/until/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..1bc8a64b92 --- /dev/null +++ b/test/built-ins/Temporal/PlainTime/prototype/until/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.plaintime.prototype.until +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.PlainTime(12, 34, 56, 0, 0, 0); +const later = new Temporal.PlainTime(13, 35, 57, 987, 654, 321); +const units = ["hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => earlier.until(later, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/PlainYearMonth/prototype/since/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/PlainYearMonth/prototype/since/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..64262218e6 --- /dev/null +++ b/test/built-ins/Temporal/PlainYearMonth/prototype/since/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.plainyearmonth.prototype.since +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.PlainYearMonth(2000, 5); +const later = new Temporal.PlainYearMonth(2001, 6); +const units = ["years", "months"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => later.since(earlier, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/PlainYearMonth/prototype/until/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/PlainYearMonth/prototype/until/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..b1a90c42a7 --- /dev/null +++ b/test/built-ins/Temporal/PlainYearMonth/prototype/until/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.plainyearmonth.prototype.until +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.PlainYearMonth(2000, 5); +const later = new Temporal.PlainYearMonth(2001, 6); +const units = ["years", "months"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => earlier.until(later, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/ZonedDateTime/prototype/since/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/ZonedDateTime/prototype/since/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..e8637812a3 --- /dev/null +++ b/test/built-ins/Temporal/ZonedDateTime/prototype/since/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.zoneddatetime.prototype.since +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.ZonedDateTime(1_000_000_000_000_000_000n, "UTC"); +const later = new Temporal.ZonedDateTime(1_000_090_061_987_654_321n, "UTC"); +const units = ["years", "months", "weeks", "days", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => later.since(earlier, { largestUnit, smallestUnit })); + } +} diff --git a/test/built-ins/Temporal/ZonedDateTime/prototype/until/largestunit-smallestunit-mismatch.js b/test/built-ins/Temporal/ZonedDateTime/prototype/until/largestunit-smallestunit-mismatch.js new file mode 100644 index 0000000000..b3d647d6fa --- /dev/null +++ b/test/built-ins/Temporal/ZonedDateTime/prototype/until/largestunit-smallestunit-mismatch.js @@ -0,0 +1,19 @@ +// Copyright (C) 2021 Igalia, S.L. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-temporal.zoneddatetime.prototype.until +description: RangeError thrown when smallestUnit is larger than largestUnit +features: [Temporal] +---*/ + +const earlier = new Temporal.ZonedDateTime(1_000_000_000_000_000_000n, "UTC"); +const later = new Temporal.ZonedDateTime(1_000_090_061_987_654_321n, "UTC"); +const units = ["years", "months", "weeks", "days", "hours", "minutes", "seconds", "milliseconds", "microseconds", "nanoseconds"]; +for (let largestIdx = 1; largestIdx < units.length; largestIdx++) { + for (let smallestIdx = 0; smallestIdx < largestIdx; smallestIdx++) { + const largestUnit = units[largestIdx]; + const smallestUnit = units[smallestIdx]; + assert.throws(RangeError, () => earlier.until(later, { largestUnit, smallestUnit })); + } +}