Replace assertThrowsInstanceOf with assert.throws in sm/Symbol

This commit is contained in:
André Bargull 2025-04-30 14:15:45 +02:00 committed by Philip Chimento
parent 68acce80ed
commit 60c271e441
15 changed files with 36 additions and 36 deletions

View File

@ -89,7 +89,7 @@ for (var sym of symbols) {
assert.sameValue(sym[noSuchPropName], undefined); assert.sameValue(sym[noSuchPropName], undefined);
// non-existent method // non-existent method
assertThrowsInstanceOf(() => sym.noSuchProp(), TypeError); assert.throws(TypeError, () => sym.noSuchProp());
assertThrowsInstanceOf(() => sym[noSuchPropName](), TypeError); assert.throws(TypeError, () => sym[noSuchPropName]());
} }

View File

@ -36,7 +36,7 @@ for (var comparator of ["<", "<=", ">", ">="]) {
var f = Function("a, b", "return a " + comparator + " b;"); var f = Function("a, b", "return a " + comparator + " b;");
for (var a of symbols) { for (var a of symbols) {
for (var b of values) for (var b of values)
assertThrowsInstanceOf(() => f(a, b), TypeError); assert.throws(TypeError, () => f(a, b));
} }
} }

View File

@ -13,7 +13,7 @@ esid: pending
---*/ ---*/
// Symbol(symbol) throws a TypeError. // Symbol(symbol) throws a TypeError.
var sym = Symbol(); var sym = Symbol();
assertThrowsInstanceOf(() => Symbol(sym), TypeError); assert.throws(TypeError, () => Symbol(sym));
// Symbol(undefined) is equivalent to Symbol(). // Symbol(undefined) is equivalent to Symbol().
assert.sameValue(Symbol(undefined).toString(), "Symbol()"); assert.sameValue(Symbol(undefined).toString(), "Symbol()");
@ -24,7 +24,7 @@ assert.sameValue(Symbol(true).toString(), "Symbol(true)");
assert.sameValue(Symbol(null).toString(), "Symbol(null)"); assert.sameValue(Symbol(null).toString(), "Symbol(null)");
assert.sameValue(Symbol([1, 2]).toString(), "Symbol(1,2)"); assert.sameValue(Symbol([1, 2]).toString(), "Symbol(1,2)");
var symobj = Object(sym); var symobj = Object(sym);
assertThrowsInstanceOf(() => Symbol(symobj), TypeError); assert.throws(TypeError, () => Symbol(symobj));
var hits = 0; var hits = 0;
var obj = { var obj = {
@ -39,5 +39,5 @@ assert.sameValue(hits, 1);
assert.sameValue(Object.getPrototypeOf(Symbol.prototype), Object.prototype); assert.sameValue(Object.getPrototypeOf(Symbol.prototype), Object.prototype);
// Symbol.prototype is not itself a Symbol object. // Symbol.prototype is not itself a Symbol object.
assertThrowsInstanceOf(() => Symbol.prototype.valueOf(), TypeError); assert.throws(TypeError, () => Symbol.prototype.valueOf());

View File

@ -26,20 +26,20 @@ function testSymbolConversions(sym) {
assert.sameValue(sym && 13, 13); assert.sameValue(sym && 13, 13);
// 7.1.3 ToNumber // 7.1.3 ToNumber
assertThrowsInstanceOf(() => +sym, TypeError); assert.throws(TypeError, () => +sym);
assertThrowsInstanceOf(() => sym | 0, TypeError); assert.throws(TypeError, () => sym | 0);
// 7.1.12 ToString // 7.1.12 ToString
assertThrowsInstanceOf(() => "" + sym, TypeError); assert.throws(TypeError, () => "" + sym);
assertThrowsInstanceOf(() => sym + "", TypeError); assert.throws(TypeError, () => sym + "");
assertThrowsInstanceOf(() => "" + [1, 2, sym], TypeError); assert.throws(TypeError, () => "" + [1, 2, sym]);
assertThrowsInstanceOf(() => ["simple", "thimble", sym].join(), TypeError); assert.throws(TypeError, () => ["simple", "thimble", sym].join());
// 21.1.1.1 String() // 21.1.1.1 String()
assert.sameValue(String(sym), sym.toString()); assert.sameValue(String(sym), sym.toString());
// 21.1.1.2 new String() // 21.1.1.2 new String()
assertThrowsInstanceOf(() => new String(sym), TypeError); assert.throws(TypeError, () => new String(sym));
// 7.1.13 ToObject // 7.1.13 ToObject
var obj = Object(sym); var obj = Object(sym);
@ -58,19 +58,19 @@ for (var sym of symbols) {
// 7.1.1 ToPrimitive // 7.1.1 ToPrimitive
var symobj = Object(sym); var symobj = Object(sym);
assertThrowsInstanceOf(() => Number(symobj), TypeError); assert.throws(TypeError, () => Number(symobj));
assertThrowsInstanceOf(() => String(symobj), TypeError); assert.throws(TypeError, () => String(symobj));
assertThrowsInstanceOf(() => symobj < 0, TypeError); assert.throws(TypeError, () => symobj < 0);
assertThrowsInstanceOf(() => 0 < symobj, TypeError); assert.throws(TypeError, () => 0 < symobj);
assertThrowsInstanceOf(() => symobj + 1, TypeError); assert.throws(TypeError, () => symobj + 1);
assertThrowsInstanceOf(() => "" + symobj, TypeError); assert.throws(TypeError, () => "" + symobj);
assert.sameValue(sym == symobj, true); assert.sameValue(sym == symobj, true);
assert.sameValue(sym === symobj, false); assert.sameValue(sym === symobj, false);
assert.sameValue(symobj == 0, false); assert.sameValue(symobj == 0, false);
assert.sameValue(0 != symobj, true); assert.sameValue(0 != symobj, true);
// 7.1.12 ToString // 7.1.12 ToString
assertThrowsInstanceOf(() => String(Object(sym)), TypeError); assert.throws(TypeError, () => String(Object(sym)));
} }
// Deleting Symbol.prototype[@@toPrimitive] does not change the behavior of // Deleting Symbol.prototype[@@toPrimitive] does not change the behavior of

View File

@ -16,10 +16,10 @@ esid: pending
var sym = Symbol(); var sym = Symbol();
// 7.2.2 IsCallable // 7.2.2 IsCallable
assertThrowsInstanceOf(() => sym(), TypeError); assert.throws(TypeError, () => sym());
assertThrowsInstanceOf(() => Function.prototype.call.call(sym), TypeError); assert.throws(TypeError, () => Function.prototype.call.call(sym));
// 7.2.5 IsConstructor // 7.2.5 IsConstructor
assertThrowsInstanceOf(() => new sym(), TypeError); assert.throws(TypeError, () => new sym());
assertThrowsInstanceOf(() => new Symbol(), TypeError); assert.throws(TypeError, () => new Symbol());

View File

@ -16,8 +16,8 @@ assert.sameValue(Symbol.keyFor(Symbol.for("")), "");
assert.sameValue(Symbol.keyFor(Symbol("moon")), undefined); assert.sameValue(Symbol.keyFor(Symbol("moon")), undefined);
assert.sameValue(Symbol.keyFor(Symbol.iterator), undefined); assert.sameValue(Symbol.keyFor(Symbol.iterator), undefined);
assertThrowsInstanceOf(() => Symbol.keyFor(), TypeError); assert.throws(TypeError, () => Symbol.keyFor());
assertThrowsInstanceOf(() => Symbol.keyFor(Object(Symbol("moon"))), TypeError); assert.throws(TypeError, () => Symbol.keyFor(Object(Symbol("moon"))));
assert.sameValue(Symbol.keyFor.length, 1); assert.sameValue(Symbol.keyFor.length, 1);

View File

@ -48,7 +48,7 @@ assert.sameValue(value, "gravity");
Object.defineProperty(F.prototype, sym, { Object.defineProperty(F.prototype, sym, {
set: undefined set: undefined
}); });
assertThrowsInstanceOf(function () { "use strict"; f[sym] = 0; }, TypeError); assert.throws(TypeError, function () { "use strict"; f[sym] = 0; });
// deeply inherited accessor property // deeply inherited accessor property
var g = Object.create(f); var g = Object.create(f);

View File

@ -18,7 +18,7 @@ function checkNotWritable(obj) {
assert.sameValue(obj[sym], "cheese"); assert.sameValue(obj[sym], "cheese");
// In strict mode code, it throws. // In strict mode code, it throws.
assertThrowsInstanceOf(function () { "use strict"; obj[sym] = "robots"; }, TypeError); assert.throws(TypeError, function () { "use strict"; obj[sym] = "robots"; });
assert.sameValue(obj[sym], "cheese"); assert.sameValue(obj[sym], "cheese");
} }

View File

@ -88,7 +88,7 @@ assert.sameValue(descs.propertyIsEnumerable(s3), false); // inherited properties
var obj = {}; var obj = {};
obj[s1] = 1; obj[s1] = 1;
assert.sameValue(Object.preventExtensions(obj), obj); assert.sameValue(Object.preventExtensions(obj), obj);
assertThrowsInstanceOf(function () { "use strict"; obj[s2] = 2; }, TypeError); assert.throws(TypeError, function () { "use strict"; obj[s2] = 2; });
obj[s2] = 2; // still no effect obj[s2] = 2; // still no effect
assert.sameValue(s2 in obj, false); assert.sameValue(s2 in obj, false);

View File

@ -22,6 +22,6 @@ for (let method of [true, false, 0, 123, "", "abc", Symbol(), {}]) {
[Symbol.toPrimitive]: method, [Symbol.toPrimitive]: method,
toString: () => "pass", toString: () => "pass",
}; };
assertThrowsInstanceOf(() => "" + obj, TypeError); assert.throws(TypeError, () => "" + obj);
} }

View File

@ -37,7 +37,7 @@ var nonSymbols = [
new Proxy(obj, {}) new Proxy(obj, {})
]; ];
for (var value of nonSymbols) { for (var value of nonSymbols) {
assertThrowsInstanceOf(() => symbolToPrimitive.call(value, "string"), TypeError); assert.throws(TypeError, () => symbolToPrimitive.call(value, "string"));
} }
// Surface features: // Surface features:

View File

@ -31,5 +31,5 @@ var nonsymbols = [
undefined, null, "not-ok", new String("still-not-ok"), {}, [] undefined, null, "not-ok", new String("still-not-ok"), {}, []
]; ];
for (var nonsym of nonsymbols) for (var nonsym of nonsymbols)
assertThrowsInstanceOf(() => Symbol.prototype.toString.call(nonsym), TypeError); assert.throws(TypeError, () => Symbol.prototype.toString.call(nonsym));

View File

@ -62,7 +62,7 @@ function testProxy() {
assert.sameValue(Object.prototype.toString.call(new Proxy(function() {}, metaHandler)), "[object Function]") assert.sameValue(Object.prototype.toString.call(new Proxy(function() {}, metaHandler)), "[object Function]")
var {proxy, revoke} = Proxy.revocable({}, metaHandler); var {proxy, revoke} = Proxy.revocable({}, metaHandler);
revoke(); revoke();
assertThrowsInstanceOf(() => Object.prototype.toString.call(proxy), TypeError); assert.throws(TypeError, () => Object.prototype.toString.call(proxy));
assert.sameValue(count, 4); assert.sameValue(count, 4);
} }

View File

@ -15,11 +15,11 @@ esid: pending
for (var T of [Uint8Array, Uint8ClampedArray, Int16Array, Float32Array]) { for (var T of [Uint8Array, Uint8ClampedArray, Int16Array, Float32Array]) {
// Typed array constructors convert symbols using ToNumber(), which throws. // Typed array constructors convert symbols using ToNumber(), which throws.
assertThrowsInstanceOf(() => new T([Symbol("a")]), TypeError); assert.throws(TypeError, () => new T([Symbol("a")]));
// Assignment does the same. // Assignment does the same.
var arr = new T([1]); var arr = new T([1]);
assertThrowsInstanceOf(() => { arr[0] = Symbol.iterator; }, TypeError); assert.throws(TypeError, () => { arr[0] = Symbol.iterator; });
assert.sameValue(arr[0], 1); assert.sameValue(arr[0], 1);
} }

View File

@ -26,5 +26,5 @@ for (var sym of symbols) {
// Any other value throws. // Any other value throws.
var nonsymbols = [undefined, null, NaN, {}, Symbol.prototype]; var nonsymbols = [undefined, null, NaN, {}, Symbol.prototype];
for (var nonsym of nonsymbols) for (var nonsym of nonsymbols)
assertThrowsInstanceOf(() => Symbol.prototype.valueOf.call(nonsym), TypeError); assert.throws(TypeError, () => Symbol.prototype.valueOf.call(nonsym));