tyler.durden/test262
1
0
Fork 0
mirror of https://github.com/tc39/test262.git synced 2025-09-26 03:28:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary tests if $262.detachArrayBuffer is defined

Browse Source
This commit is contained in:
André Bargull 2025-04-30 14:16:12 +02:00 committed by Philip Chimento
parent 11c8fe0a99
commit 61286de40c
9 changed files with 475 additions and 493 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/staging/sm/DataView/get-set-index-range.js
View File

@ -8,6 +8,7 @@ description: |
pending
esid: pending
---*/
var buffer = new ArrayBuffer(2);
var view = new DataView(buffer);
@ -30,16 +31,13 @@ for (let fun of ['getInt8', 'getInt16']) {
assert.sameValue(view[fun](NaN), 0);
}
if ('$262.detachArrayBuffer' in this) {
// ToIndex is called before detachment check, so we can tell the difference
// between a ToIndex failure and a real out of bounds failure.
$262.detachArrayBuffer(buffer);
// ToIndex is called before detachment check, so we can tell the difference
// between a ToIndex failure and a real out of bounds failure.
$262.detachArrayBuffer(buffer);
check(view);
assert.throws(TypeError, () => view.getInt8(0));
assert.throws(TypeError, () => view.setInt8(0, 0));
assert.throws(TypeError, () => view.getInt8(Math.pow(2, 53) - 1));
assert.throws(TypeError, () => view.setInt8(Math.pow(2, 53) - 1, 0));
}
check(view);
assert.throws(TypeError, () => view.getInt8(0));
assert.throws(TypeError, () => view.setInt8(0, 0));
assert.throws(TypeError, () => view.getInt8(Math.pow(2, 53) - 1));
assert.throws(TypeError, () => view.setInt8(Math.pow(2, 53) - 1, 0));

22
test/staging/sm/TypedArray/iterator-next-with-detached.js
View File

@ -9,24 +9,22 @@ description: |
pending
esid: pending
---*/
function checkResult(actual, expected)
{
assert.sameValue(actual.value, expected.value);
assert.sameValue(actual.done, expected.done);
}
if (typeof $262.detachArrayBuffer === "function")
var iteratorFunction = Uint8Array.prototype[Symbol.iterator];
var thisGlobal = this;
var otherGlobal = $262.createRealm().global;
var thisNext = new Uint8Array()[Symbol.iterator]().next
for (const constructor of typedArrayConstructors)
{
var iteratorFunction = Uint8Array.prototype[Symbol.iterator];
var thisGlobal = this;
var otherGlobal = $262.createRealm().global;
var thisNext = new Uint8Array()[Symbol.iterator]().next
for (const constructor of typedArrayConstructors)
{
assert.sameValue(new constructor()[Symbol.iterator]().next, thisNext);
var globals =
@ -77,6 +75,4 @@ if (typeof $262.detachArrayBuffer === "function")
bufferGlobal.$262.detachArrayBuffer(buffer);
assert.throws(TypeError, () => thisNext.call(iterator));
}
}
}

122
test/staging/sm/TypedArray/set-detached.js
View File

@ -8,6 +8,7 @@ description: |
pending
esid: pending
---*/
// Tests for detached ArrayBuffer checks in %TypedArray%.prototype.set(array|typedArray, offset).
function* createTypedArrays(lengths = [0, 1, 4, 4096]) {
@ -19,11 +20,10 @@ function* createTypedArrays(lengths = [0, 1, 4, 4096]) {
}
}
if (typeof $262.detachArrayBuffer === "function") {
class ExpectedError extends Error {}
class ExpectedError extends Error {}
// No detached check on function entry.
for (let {typedArray, buffer} of createTypedArrays()) {
// No detached check on function entry.
for (let {typedArray, buffer} of createTypedArrays()) {
$262.detachArrayBuffer(buffer);
assert.throws(ExpectedError, () => typedArray.set(null, {
@ -31,13 +31,13 @@ if (typeof $262.detachArrayBuffer === "function") {
throw new ExpectedError();
}
}));
}
}
// Check for detached buffer after calling ToInteger(offset). Test with:
// - valid offset,
// - too large offset,
// - and negative offset.
for (let [offset, error] of [[0, TypeError], [1000000, TypeError], [-1, RangeError]]) {
// Check for detached buffer after calling ToInteger(offset). Test with:
// - valid offset,
// - too large offset,
// - and negative offset.
for (let [offset, error] of [[0, TypeError], [1000000, TypeError], [-1, RangeError]]) {
for (let source of [[], [0], new Int32Array(0), new Int32Array(1)]) {
for (let {typedArray, buffer} of createTypedArrays()) {
assert.throws(error, () => typedArray.set(source, {
@ -48,10 +48,10 @@ if (typeof $262.detachArrayBuffer === "function") {
}));
}
}
}
}
// Tests when called with detached typed array as source.
for (let {typedArray} of createTypedArrays()) {
// Tests when called with detached typed array as source.
for (let {typedArray} of createTypedArrays()) {
for (let {typedArray: source, buffer: sourceBuffer} of createTypedArrays()) {
$262.detachArrayBuffer(sourceBuffer);
@ -61,13 +61,13 @@ if (typeof $262.detachArrayBuffer === "function") {
}
}));
}
}
}
// Check when detaching source buffer in ToInteger(offset). Test with:
// - valid offset,
// - too large offset,
// - and negative offset.
for (let [offset, error] of [[0, TypeError], [1000000, TypeError], [-1, RangeError]]) {
// Check when detaching source buffer in ToInteger(offset). Test with:
// - valid offset,
// - too large offset,
// - and negative offset.
for (let [offset, error] of [[0, TypeError], [1000000, TypeError], [-1, RangeError]]) {
for (let {typedArray} of createTypedArrays()) {
for (let {typedArray: source, buffer: sourceBuffer} of createTypedArrays()) {
assert.throws(error, () => typedArray.set(source, {
@ -78,14 +78,14 @@ if (typeof $262.detachArrayBuffer === "function") {
}));
}
}
}
}
// Test when target and source use the same underlying buffer and
// ToInteger(offset) detaches the buffer. Test with:
// - same typed array,
// - different typed array, but same element type,
// - and different element type.
for (let src of [ta => ta, ta => new Int32Array(ta.buffer), ta => new Float32Array(ta.buffer)]) {
// Test when target and source use the same underlying buffer and
// ToInteger(offset) detaches the buffer. Test with:
// - same typed array,
// - different typed array, but same element type,
// - and different element type.
for (let src of [ta => ta, ta => new Int32Array(ta.buffer), ta => new Float32Array(ta.buffer)]) {
for (let {typedArray, buffer} of createTypedArrays()) {
let source = src(typedArray);
assert.throws(TypeError, () => typedArray.set(source, {
@ -95,12 +95,12 @@ if (typeof $262.detachArrayBuffer === "function") {
}
}));
}
}
}
// Test when Get(src, "length") detaches the buffer, but srcLength is 0.
// Also use different offsets to ensure bounds checks use the typed array's
// length value from before detaching the buffer.
for (let offset of [() => 0, ta => Math.min(1, ta.length), ta => Math.max(0, ta.length - 1)]) {
// Test when Get(src, "length") detaches the buffer, but srcLength is 0.
// Also use different offsets to ensure bounds checks use the typed array's
// length value from before detaching the buffer.
for (let offset of [() => 0, ta => Math.min(1, ta.length), ta => Math.max(0, ta.length - 1)]) {
for (let {typedArray, buffer} of createTypedArrays()) {
let source = {
get length() {
@ -110,12 +110,12 @@ if (typeof $262.detachArrayBuffer === "function") {
};
typedArray.set(source, offset(typedArray));
}
}
}
// Test when ToLength(Get(src, "length")) detaches the buffer, but
// srcLength is 0. Also use different offsets to ensure bounds checks use
// the typed array's length value from before detaching the buffer.
for (let offset of [() => 0, ta => Math.min(1, ta.length), ta => Math.max(0, ta.length - 1)]) {
// Test when ToLength(Get(src, "length")) detaches the buffer, but
// srcLength is 0. Also use different offsets to ensure bounds checks use
// the typed array's length value from before detaching the buffer.
for (let offset of [() => 0, ta => Math.min(1, ta.length), ta => Math.max(0, ta.length - 1)]) {
for (let {typedArray, buffer} of createTypedArrays()) {
let source = {
length: {
@ -127,11 +127,11 @@ if (typeof $262.detachArrayBuffer === "function") {
};
typedArray.set(source, offset(typedArray));
}
}
}
// Test no TypeError is thrown when the typed array is detached and
// srcLength > 0.
for (let {typedArray, buffer} of createTypedArrays()) {
// Test no TypeError is thrown when the typed array is detached and
// srcLength > 0.
for (let {typedArray, buffer} of createTypedArrays()) {
let source = {
length: {
valueOf() {
@ -145,10 +145,10 @@ if (typeof $262.detachArrayBuffer === "function") {
} else {
typedArray.set(source);
}
}
}
// Same as above, but with side-effect when executing Get(src, "0").
for (let {typedArray, buffer} of createTypedArrays()) {
// Same as above, but with side-effect when executing Get(src, "0").
for (let {typedArray, buffer} of createTypedArrays()) {
let source = {
get 0() {
throw new ExpectedError();
@ -162,10 +162,10 @@ if (typeof $262.detachArrayBuffer === "function") {
};
let err = typedArray.length === 0 ? RangeError : ExpectedError;
assert.throws(err, () => typedArray.set(source));
}
}
// Same as above, but with side-effect when executing ToNumber(Get(src, "0")).
for (let {typedArray, buffer} of createTypedArrays()) {
// Same as above, but with side-effect when executing ToNumber(Get(src, "0")).
for (let {typedArray, buffer} of createTypedArrays()) {
let source = {
get 0() {
return {
@ -183,10 +183,10 @@ if (typeof $262.detachArrayBuffer === "function") {
};
let err = typedArray.length === 0 ? RangeError : ExpectedError;
assert.throws(err, () => typedArray.set(source));
}
}
// Side-effects when getting the source elements detach the buffer.
for (let {typedArray, buffer} of createTypedArrays()) {
// Side-effects when getting the source elements detach the buffer.
for (let {typedArray, buffer} of createTypedArrays()) {
let source = Object.defineProperties([], {
0: {
get() {
@ -200,11 +200,11 @@ if (typeof $262.detachArrayBuffer === "function") {
} else {
typedArray.set(source);
}
}
}
// Side-effects when getting the source elements detach the buffer. Also
// ensure other elements are accessed.
for (let {typedArray, buffer} of createTypedArrays()) {
// Side-effects when getting the source elements detach the buffer. Also
// ensure other elements are accessed.
for (let {typedArray, buffer} of createTypedArrays()) {
let accessed = false;
let source = Object.defineProperties([], {
0: {
@ -228,10 +228,10 @@ if (typeof $262.detachArrayBuffer === "function") {
typedArray.set(source);
assert.sameValue(accessed, true);
}
}
}
// Side-effects when converting the source elements detach the buffer.
for (let {typedArray, buffer} of createTypedArrays()) {
// Side-effects when converting the source elements detach the buffer.
for (let {typedArray, buffer} of createTypedArrays()) {
let source = [{
valueOf() {
$262.detachArrayBuffer(buffer);
@ -243,11 +243,11 @@ if (typeof $262.detachArrayBuffer === "function") {
} else {
typedArray.set(source);
}
}
}
// Side-effects when converting the source elements detach the buffer. Also
// ensure other elements are accessed.
for (let {typedArray, buffer} of createTypedArrays()) {
// Side-effects when converting the source elements detach the buffer. Also
// ensure other elements are accessed.
for (let {typedArray, buffer} of createTypedArrays()) {
let accessed = false;
let source = [{
valueOf() {
@ -268,6 +268,4 @@ if (typeof $262.detachArrayBuffer === "function") {
typedArray.set(source);
assert.sameValue(accessed, true);
}
}
}

4
test/staging/sm/TypedArray/set-with-receiver.js
View File

@ -24,9 +24,7 @@ for (var constructor of anyTypedArrayConstructors) {
assert.sameValue(Object.hasOwn(receiver, 10), false);
// Detached
if (typeof $262.detachArrayBuffer === "function" &&
!isSharedConstructor(constructor))
{
if (!isSharedConstructor(constructor)) {
$262.detachArrayBuffer(ta.buffer)
assert.sameValue(ta[0], undefined);

58
test/staging/sm/TypedArray/set-wrapped.js
View File

@ -9,6 +9,7 @@ description: |
pending
esid: pending
---*/
// Test %TypedArray%.prototype.set(typedArray, offset) when called with wrapped
// typed array.
@ -35,9 +36,9 @@ for (var TA of anyTypedArrayConstructors) {
}
// Detachment checks are also applied correctly for wrapped typed arrays.
if (typeof $262.detachArrayBuffer === "function") {
// Create typed array from different global (explicit constructor call).
for (var TA of typedArrayConstructors) {
// Create typed array from different global (explicit constructor call).
for (var TA of typedArrayConstructors) {
var target = new TA(4);
var source = new otherGlobal[TA.name](1);
taintLengthProperty(source);
@ -58,30 +59,29 @@ if (typeof $262.detachArrayBuffer === "function") {
}
};
assert.throws(TypeError, () => target.set(source, offset));
}
// Create typed array from different global (implictly created when
// ArrayBuffer is a CCW).
for (var TA of typedArrayConstructors) {
var target = new TA(4);
var source = new TA(new otherGlobal.ArrayBuffer(1 * TA.BYTES_PER_ELEMENT));
taintLengthProperty(source);
// Called with wrapped typed array, array buffer already detached.
otherGlobal.$262.detachArrayBuffer(source.buffer);
assert.throws(TypeError, () => target.set(source));
var source = new TA(new otherGlobal.ArrayBuffer(1 * TA.BYTES_PER_ELEMENT));
taintLengthProperty(source);
// Called with wrapped typed array, array buffer detached when
// processing offset parameter.
var offset = {
valueOf() {
otherGlobal.$262.detachArrayBuffer(source.buffer);
return 0;
}
};
assert.throws(TypeError, () => target.set(source, offset));
}
}
// Create typed array from different global (implictly created when
// ArrayBuffer is a CCW).
for (var TA of typedArrayConstructors) {
var target = new TA(4);
var source = new TA(new otherGlobal.ArrayBuffer(1 * TA.BYTES_PER_ELEMENT));
taintLengthProperty(source);
// Called with wrapped typed array, array buffer already detached.
otherGlobal.$262.detachArrayBuffer(source.buffer);
assert.throws(TypeError, () => target.set(source));
var source = new TA(new otherGlobal.ArrayBuffer(1 * TA.BYTES_PER_ELEMENT));
taintLengthProperty(source);
// Called with wrapped typed array, array buffer detached when
// processing offset parameter.
var offset = {
valueOf() {
otherGlobal.$262.detachArrayBuffer(source.buffer);
return 0;
}
};
assert.throws(TypeError, () => target.set(source, offset));
}

26
test/staging/sm/TypedArray/slice-detached.js
View File

@ -8,6 +8,7 @@ description: |
pending
esid: pending
---*/
// Tests for detached ArrayBuffer checks in %TypedArray%.prototype.slice ( start, end ).
function* createTypedArrays(lengths = [0, 1, 4, 4096]) {
@ -27,17 +28,16 @@ function* createTypedArrays(lengths = [0, 1, 4, 4096]) {
}
}
if (typeof $262.detachArrayBuffer === "function") {
// ArrayBuffer is detached when entering slice().
for (let {typedArray, buffer} of createTypedArrays()) {
// ArrayBuffer is detached when entering slice().
for (let {typedArray, buffer} of createTypedArrays()) {
$262.detachArrayBuffer(buffer());
assert.throws(TypeError, () => {
typedArray.slice(0);
}, "ArrayBuffer is detached on function entry");
}
}
// ArrayBuffer is detached when computing ToInteger(start).
for (let {typedArray, length, buffer} of createTypedArrays()) {
// ArrayBuffer is detached when computing ToInteger(start).
for (let {typedArray, length, buffer} of createTypedArrays()) {
let detached = false;
let start = {
valueOf() {
@ -58,10 +58,10 @@ if (typeof $262.detachArrayBuffer === "function") {
}, "ArrayBuffer is detached in ToInteger(start)");
}
assert.sameValue(detached, true, "$262.detachArrayBuffer was called");
}
}
// ArrayBuffer is detached when computing ToInteger(end).
for (let {typedArray, length, buffer} of createTypedArrays()) {
// ArrayBuffer is detached when computing ToInteger(end).
for (let {typedArray, length, buffer} of createTypedArrays()) {
let detached = false;
let end = {
valueOf() {
@ -82,10 +82,10 @@ if (typeof $262.detachArrayBuffer === "function") {
}, "ArrayBuffer is detached in ToInteger(end)");
}
assert.sameValue(detached, true, "$262.detachArrayBuffer was called");
}
}
// ArrayBuffer is detached in species constructor.
for (let {typedArray, length, buffer} of createTypedArrays()) {
// ArrayBuffer is detached in species constructor.
for (let {typedArray, length, buffer} of createTypedArrays()) {
let detached = false;
typedArray.constructor = {
[Symbol.species]: function(...args) {
@ -106,6 +106,4 @@ if (typeof $262.detachArrayBuffer === "function") {
}, "ArrayBuffer is detached in TypedArraySpeciesCreate(...)");
}
assert.sameValue(detached, true, "$262.detachArrayBuffer was called");
}
}

11
test/staging/sm/TypedArray/sort_errors.js
View File

@ -8,18 +8,17 @@ description: |
pending
esid: pending
---*/
// Ensure that TypedArrays throw when attempting to sort a detached ArrayBuffer
if (typeof $262.detachArrayBuffer === "function") {
assert.throws(TypeError, () => {
assert.throws(TypeError, () => {
let buffer = new ArrayBuffer(32);
let array = new Int32Array(buffer);
$262.detachArrayBuffer(buffer);
array.sort();
});
}
});
// Ensure detaching buffer in comparator doesn't throw an error.
if (typeof $262.detachArrayBuffer === "function") {
{
let detached = false;
let ta = new Int32Array(3);
ta.sort(function(a, b) {
@ -43,7 +42,7 @@ let otherGlobal = $262.createRealm().global;
}
// Ensure detaching buffer in comparator doesn't throw an error when the typed array is wrapped.
if (typeof $262.detachArrayBuffer === "function") {
{
let detached = false;
let ta = new Int32Array(3);
otherGlobal.Int32Array.prototype.sort.call(ta, function(a,b) {

7
test/staging/sm/TypedArray/subarray.js
View File

@ -9,9 +9,8 @@ description: |
pending
esid: pending
---*/
// Bug 1291003
if (typeof $262.detachArrayBuffer === "function") {
for (let constructor of typedArrayConstructors) {
for (let constructor of typedArrayConstructors) {
const elementSize = constructor.BYTES_PER_ELEMENT;
let targetOffset;
@ -33,6 +32,4 @@ if (typeof $262.detachArrayBuffer === "function") {
typedArray.subarray(beginIndex);
assert.sameValue(targetOffset, 1 * elementSize);
}
}

18
test/staging/sm/TypedArray/toLocaleString-detached.js
View File

@ -9,18 +9,18 @@ description: |
pending
esid: pending
---*/
if (typeof $262.detachArrayBuffer === "function") {
const originalNumberToLocaleString = Number.prototype.toLocaleString;
// Throws if array buffer is detached.
for (let constructor of typedArrayConstructors) {
const originalNumberToLocaleString = Number.prototype.toLocaleString;
// Throws if array buffer is detached.
for (let constructor of typedArrayConstructors) {
let typedArray = new constructor(42);
$262.detachArrayBuffer(typedArray.buffer);
assert.throws(TypeError, () => typedArray.toLocaleString());
}
}
// Doesn't throw a TypeError if detached in Number.prototype.toLocaleString.
for (let constructor of typedArrayConstructors) {
// Doesn't throw a TypeError if detached in Number.prototype.toLocaleString.
for (let constructor of typedArrayConstructors) {
Number.prototype.toLocaleString = function() {
"use strict";
if (!detached) {
@ -41,7 +41,5 @@ if (typeof $262.detachArrayBuffer === "function") {
typedArray = new constructor(2);
assert.sameValue(typedArray.toLocaleString(), "0,");
assert.sameValue(detached, true);
}
Number.prototype.toLocaleString = originalNumberToLocaleString;
}
Number.prototype.toLocaleString = originalNumberToLocaleString;