From 943face280c17d1c5215362ee6a574046bb94184 Mon Sep 17 00:00:00 2001 From: Pieter van Ginkel Date: Wed, 3 Jun 2015 19:29:10 +0200 Subject: [PATCH 1/2] Fixed testing deletion of an environment object. Test 11.4.1-4.a-5 states that it verifies that an environment object cannot be deleted. However, this was giving a false positive. It was actually testing where a "var" declaration on an environment object cannot be deleted (there are other tests for this). This test case fails on Chrome 43, Firefox 38 and Internet Explorer 11. --- test/language/expressions/delete/11.4.1-4.a-5.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/language/expressions/delete/11.4.1-4.a-5.js b/test/language/expressions/delete/11.4.1-4.a-5.js index c53aa0a006..82ce58fdb9 100644 --- a/test/language/expressions/delete/11.4.1-4.a-5.js +++ b/test/language/expressions/delete/11.4.1-4.a-5.js @@ -17,7 +17,7 @@ includes: [runTestCase.js] ---*/ function testcase() { - var o = new Object(); + o = new Object(); o.x = 1; var d; with(o) From 632beef930894cc6fa9c8a331ce7ccf7e472b797 Mon Sep 17 00:00:00 2001 From: Pieter van Ginkel Date: Tue, 9 Jun 2015 11:29:54 +0200 Subject: [PATCH 2/2] Improved description of 11.4.1-4.a-5. The previous description of the 11.4.1-4.a-5 test case implied that an environment object could not be deleted while inside a with. However, the actual test was to test whether the variable declaration could be deleted. The description has been updated to better reflect this. --- test/language/expressions/delete/11.4.1-4.a-5.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/language/expressions/delete/11.4.1-4.a-5.js b/test/language/expressions/delete/11.4.1-4.a-5.js index 82ce58fdb9..65b6be01fb 100644 --- a/test/language/expressions/delete/11.4.1-4.a-5.js +++ b/test/language/expressions/delete/11.4.1-4.a-5.js @@ -10,14 +10,14 @@ info: > language provides no way to directly exercise [[Delete]], the tests are placed here. es5id: 11.4.1-4.a-5 description: > - delete operator returns false when deleting the environment object + delete operator returns false when deleting the declaration of the environment object inside 'with' flags: [noStrict] includes: [runTestCase.js] ---*/ function testcase() { - o = new Object(); + var o = new Object(); o.x = 1; var d; with(o)