tyler.durden/test262
1
0
Fork 0
mirror of https://github.com/tc39/test262.git synced 2025-07-27 07:54:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixing tests that access PrivateNames from another realm to assert the correct TypeError object, since each function will throw the TypeError from the realm where it was created. (#2258)

Browse Source
This commit is contained in:
Caio Lima 2019-07-30 11:43:01 -07:00 committed by Leo Balter
parent 99f75984db
commit 67ab89a4cb
6 changed files with 39 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/language/expressions/class/private-getter-brand-check-multiple-evaluations-of-class-realm-function-ctor.js
View File

@ -30,9 +30,12 @@ return class {
`; `;
let createAndInstantiateClass = function () { let createAndInstantiateClass = function () {
let classFactoryFunction = new ($262.createRealm().global.Function)(classStringExpression); let realm = $262.createRealm();
let classFactoryFunction = new (realm.global.Function)(classStringExpression);
let Class = classFactoryFunction(); let Class = classFactoryFunction();
return new Class(); let obj = new Class();
obj.realm = realm;
return obj;
}; };
let c1 = createAndInstantiateClass(); let c1 = createAndInstantiateClass();
@ -41,10 +44,10 @@ let c2 = createAndInstantiateClass();
assert.sameValue(c1.access(c1), 'test262'); assert.sameValue(c1.access(c1), 'test262');
assert.sameValue(c2.access(c2), 'test262'); assert.sameValue(c2.access(c2), 'test262');
assert.throws(TypeError, function() { assert.throws(c1.realm.global.TypeError, function() {
c1.access(c2); c1.access(c2);
}, 'invalid access of c1 private method'); }, 'invalid access of c1 private method');
assert.throws(TypeError, function() { assert.throws(c2.realm.global.TypeError, function() {
c2.access(c1); c2.access(c1);
}, 'invalid access of c2 private method'); }, 'invalid access of c2 private method');

10
test/language/expressions/class/private-getter-brand-check-multiple-evaluations-of-class-realm.js
View File

@ -20,8 +20,10 @@ features: [class, class-methods-private]
flags: [noStrict] flags: [noStrict]
---*/ ---*/
let eval1 = $262.createRealm().global.eval; let realm1 = $262.createRealm();
let eval2 = $262.createRealm().global.eval; let realm2 = $262.createRealm();
let eval1 = realm1.global.eval;
let eval2 = realm2.global.eval;
let classStringExpression = `( let classStringExpression = `(
class { class {
@ -43,10 +45,10 @@ let c2 = createAndInstantiateClass(eval2);
assert.sameValue(c1.access(c1), 'test262'); assert.sameValue(c1.access(c1), 'test262');
assert.sameValue(c2.access(c2), 'test262'); assert.sameValue(c2.access(c2), 'test262');
assert.throws(TypeError, function() { assert.throws(realm1.global.TypeError, function() {
c1.access(c2); c1.access(c2);
}, 'invalid access of c1 private method'); }, 'invalid access of c1 private method');
assert.throws(TypeError, function() { assert.throws(realm2.global.TypeError, function() {
c2.access(c1); c2.access(c1);
}, 'invalid access of c2 private method'); }, 'invalid access of c2 private method');

11
test/language/expressions/class/private-method-brand-check-multiple-evaluations-of-class-realm-function-ctor.js
View File

@ -30,9 +30,12 @@ return class C {
`; `;
let createAndInstantiateClass = function () { let createAndInstantiateClass = function () {
let classFactoryFunction = new ($262.createRealm().global.Function)(classStringExpression); let realm = $262.createRealm();
let classFactoryFunction = new (realm.global.Function)(classStringExpression);
let Class = classFactoryFunction(); let Class = classFactoryFunction();
return new Class(); let obj = new Class();
obj.realm = realm;
return obj;
}; };
let c1 = createAndInstantiateClass(); let c1 = createAndInstantiateClass();
@ -41,10 +44,10 @@ let c2 = createAndInstantiateClass();
assert.sameValue(c1.access(c1), 'test262'); assert.sameValue(c1.access(c1), 'test262');
assert.sameValue(c2.access(c2), 'test262'); assert.sameValue(c2.access(c2), 'test262');
assert.throws(TypeError, function() { assert.throws(c1.realm.global.TypeError, function() {
c1.access(c2); c1.access(c2);
}, 'invalid access of c1 private method'); }, 'invalid access of c1 private method');
assert.throws(TypeError, function() { assert.throws(c2.realm.global.TypeError, function() {
c2.access(c1); c2.access(c1);
}, 'invalid access of c2 private method'); }, 'invalid access of c2 private method');

10
test/language/expressions/class/private-method-brand-check-multiple-evaluations-of-class-realm.js
View File

@ -20,8 +20,10 @@ features: [class, class-methods-private]
flags: [noStrict] flags: [noStrict]
---*/ ---*/
let eval1 = $262.createRealm().global.eval; let realm1 = $262.createRealm();
let eval2 = $262.createRealm().global.eval; let realm2 = $262.createRealm();
let eval1 = realm1.global.eval;
let eval2 = realm2.global.eval;
let classStringExpression = `( let classStringExpression = `(
class { class {
@ -43,10 +45,10 @@ let c2 = createAndInstantiateClass(eval2);
assert.sameValue(c1.access(c1), 'test262'); assert.sameValue(c1.access(c1), 'test262');
assert.sameValue(c2.access(c2), 'test262'); assert.sameValue(c2.access(c2), 'test262');
assert.throws(TypeError, function() { assert.throws(realm1.global.TypeError, function() {
c1.access(c2); c1.access(c2);
}, 'invalid access of c1 private method'); }, 'invalid access of c1 private method');
assert.throws(TypeError, function() { assert.throws(realm2.global.TypeError, function() {
c2.access(c1); c2.access(c1);
}, 'invalid access of c2 private method'); }, 'invalid access of c2 private method');

11
test/language/expressions/class/private-setter-brand-check-multiple-evaluations-of-class-realm-function-ctor.js
View File

@ -30,9 +30,12 @@ return class {
`; `;
let createAndInstantiateClass = function () { let createAndInstantiateClass = function () {
let classFactoryFunction = new ($262.createRealm().global.Function)(classStringExpression); let realm = $262.createRealm();
let classFactoryFunction = new (realm.global.Function)(classStringExpression);
let Class = classFactoryFunction(); let Class = classFactoryFunction();
return new Class(); let obj = new Class();
obj.realm = realm;
return obj;
}; };
let c1 = createAndInstantiateClass(); let c1 = createAndInstantiateClass();
@ -43,10 +46,10 @@ assert.sameValue(c1._v, 'test262');
c2.access(c2, 'test262'); c2.access(c2, 'test262');
assert.sameValue(c2._v, 'test262'); assert.sameValue(c2._v, 'test262');
assert.throws(TypeError, function() { assert.throws(c1.realm.global.TypeError, function() {
c1.access(c2, 'foo'); c1.access(c2, 'foo');
}, 'invalid access of c1 private method'); }, 'invalid access of c1 private method');
assert.throws(TypeError, function() { assert.throws(c2.realm.global.TypeError, function() {
c2.access(c1, 'foo'); c2.access(c1, 'foo');
}, 'invalid access of c2 private method'); }, 'invalid access of c2 private method');

10
test/language/expressions/class/private-setter-brand-check-multiple-evaluations-of-class-realm.js
View File

@ -20,8 +20,10 @@ features: [class, class-methods-private]
flags: [noStrict] flags: [noStrict]
---*/ ---*/
let eval1 = $262.createRealm().global.eval; let realm1 = $262.createRealm();
let eval2 = $262.createRealm().global.eval; let realm2 = $262.createRealm();
let eval1 = realm1.global.eval;
let eval2 = realm2.global.eval;
let classStringExpression = `( let classStringExpression = `(
class { class {
@ -45,10 +47,10 @@ assert.sameValue(c1._v, 'test262');
c2.access(c2, 'test262'); c2.access(c2, 'test262');
assert.sameValue(c2._v, 'test262'); assert.sameValue(c2._v, 'test262');
assert.throws(TypeError, function() { assert.throws(realm1.global.TypeError, function() {
c1.access(c2, 'foo'); c1.access(c2, 'foo');
}, 'invalid access of c1 private method'); }, 'invalid access of c1 private method');
assert.throws(TypeError, function() { assert.throws(realm2.global.TypeError, function() {
c2.access(c1, 'foo'); c2.access(c1, 'foo');
}, 'invalid access of c2 private method'); }, 'invalid access of c2 private method');