From 6888a8df829d416b93cb7057aa860261aa05cf08 Mon Sep 17 00:00:00 2001 From: strager Date: Fri, 9 Apr 2021 17:13:41 -0700 Subject: [PATCH] Fix typo in private getter/setter tests (#2971) Several tests for getters and setters claim to check for an early SyntaxError regarding mixing static and non-static propeties with the same name. However, the tests trigger another issue: the getters have no method body; they're missing curlies. Fix the tests to test only the intended SyntaxError, not unrelated SyntaxError-s. --- .../private-non-static-getter-static-setter-early-error.js | 2 +- .../private-non-static-setter-static-getter-early-error.js | 2 +- .../private-static-getter-non-static-setter-early-error.js | 2 +- .../private-static-setter-non-static-getter-early-error.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/language/statements/class/private-non-static-getter-static-setter-early-error.js b/test/language/statements/class/private-non-static-getter-static-setter-early-error.js index 04ea104f7e..e7e350d0ab 100644 --- a/test/language/statements/class/private-non-static-getter-static-setter-early-error.js +++ b/test/language/statements/class/private-non-static-getter-static-setter-early-error.js @@ -13,7 +13,7 @@ negative: $DONOTEVALUATE(); class C { - get #f(); + get #f() {} static set #f(v) {} } diff --git a/test/language/statements/class/private-non-static-setter-static-getter-early-error.js b/test/language/statements/class/private-non-static-setter-static-getter-early-error.js index c589d0d2bf..eb4d7bb04a 100644 --- a/test/language/statements/class/private-non-static-setter-static-getter-early-error.js +++ b/test/language/statements/class/private-non-static-setter-static-getter-early-error.js @@ -14,6 +14,6 @@ $DONOTEVALUATE(); class C { set #f(v) {} - static get #f(); + static get #f() {} } diff --git a/test/language/statements/class/private-static-getter-non-static-setter-early-error.js b/test/language/statements/class/private-static-getter-non-static-setter-early-error.js index 9b201e6f01..ded19b2fa6 100644 --- a/test/language/statements/class/private-static-getter-non-static-setter-early-error.js +++ b/test/language/statements/class/private-static-getter-non-static-setter-early-error.js @@ -13,7 +13,7 @@ negative: $DONOTEVALUATE(); class C { - static get #f(); + static get #f() {} set #f(v) {} } diff --git a/test/language/statements/class/private-static-setter-non-static-getter-early-error.js b/test/language/statements/class/private-static-setter-non-static-getter-early-error.js index 23716997db..295399b528 100644 --- a/test/language/statements/class/private-static-setter-non-static-getter-early-error.js +++ b/test/language/statements/class/private-static-setter-non-static-getter-early-error.js @@ -14,6 +14,6 @@ $DONOTEVALUATE(); class C { static set #f(v) {} - get #f(); + get #f() {} }