address ljharb comments

This commit is contained in:
Kevin Gibbons 2024-03-11 22:43:06 -07:00 committed by Jordan Harband
parent 911aa6173d
commit 6d7bd55175
No known key found for this signature in database
GPG Key ID: 9F6A681E35EF8B56
3 changed files with 7 additions and 6 deletions

View File

@ -26,3 +26,4 @@ var target = new Uint8Array([255, 255, 255]);
assert.throws(TypeError, function() { assert.throws(TypeError, function() {
target.setFromBase64('Zg==', targetDetachingOptions); target.setFromBase64('Zg==', targetDetachingOptions);
}); });
assert.sameValue(getterCalls, 1);

View File

@ -9,8 +9,8 @@ features: [uint8array-base64]
var array = new Uint8Array(2); var array = new Uint8Array(2);
var getterCalls = 0; var getterCalls = 0;
var recevierDetachingOptions = {}; var receiverDetachingOptions = {};
Object.defineProperty(recevierDetachingOptions, "alphabet", { Object.defineProperty(receiverDetachingOptions, "alphabet", {
get: function() { get: function() {
getterCalls += 1; getterCalls += 1;
$DETACHBUFFER(array.buffer); $DETACHBUFFER(array.buffer);
@ -18,7 +18,7 @@ Object.defineProperty(recevierDetachingOptions, "alphabet", {
} }
}); });
assert.throws(TypeError, function() { assert.throws(TypeError, function() {
array.toBase64(recevierDetachingOptions); array.toBase64(receiverDetachingOptions);
}); });
assert.sameValue(getterCalls, 1); assert.sameValue(getterCalls, 1);

View File

@ -31,13 +31,13 @@ assert.sameValue(alphabetAccesses, 1);
// side-effects from the getter on the receiver are reflected in the result // side-effects from the getter on the receiver are reflected in the result
var array = new Uint8Array([0]); var array = new Uint8Array([0]);
var recevierMutatingOptions = {}; var receiverMutatingOptions = {};
Object.defineProperty(recevierMutatingOptions, "alphabet", { Object.defineProperty(receiverMutatingOptions, "alphabet", {
get: function() { get: function() {
array[0] = 255; array[0] = 255;
return "base64"; return "base64";
} }
}); });
var result = array.toBase64(recevierMutatingOptions); var result = array.toBase64(receiverMutatingOptions);
assert.sameValue(result, "/w=="); assert.sameValue(result, "/w==");
assert.sameValue(array[0], 255); assert.sameValue(array[0], 255);