From 7fb465496fb90da733cbe5bbb234a1a7b092c0b4 Mon Sep 17 00:00:00 2001 From: Tim Chevalier Date: Wed, 30 Oct 2024 17:02:25 -0700 Subject: [PATCH] Feedback from code review --- ...ropertybag-ignores-incorrect-properties.js | 1 - ...g-required-correctly-spelled-properties.js | 19 +++++++++++++++++++ ...pertybag-required-prop-undefined-throws.js | 3 +-- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-ignores-incorrect-properties.js b/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-ignores-incorrect-properties.js index aa3e9a3677..53a2fb41c6 100644 --- a/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-ignores-incorrect-properties.js +++ b/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-ignores-incorrect-properties.js @@ -11,7 +11,6 @@ features: [Temporal] // "1976-11-18T00:00:00+01:00[+01:00]" const expected = new Temporal.ZonedDateTime(217119600000000000n, "+01:00"); -// can be constructed with monthCode and without month TemporalHelpers.assertZonedDateTimesEqual(Temporal.ZonedDateTime.from({ year: 1976, month: 11, diff --git a/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-required-correctly-spelled-properties.js b/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-required-correctly-spelled-properties.js index 033b77b69b..bea851c550 100644 --- a/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-required-correctly-spelled-properties.js +++ b/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-required-correctly-spelled-properties.js @@ -14,3 +14,22 @@ assert.throws(TypeError, () => Temporal.ZonedDateTime.from({ days: 18, timeZone: "+01:00" })); +assert.throws(TypeError, () => Temporal.ZonedDateTime.from({ + years: 1976, + months: 11, + day: 18, + timeZone: "+01:00" +})); +assert.throws(TypeError, () => Temporal.ZonedDateTime.from({ + year: 1976, + months: 11, + days: 18, + timeZone: "+01:00" +})); +assert.throws(TypeError, () => Temporal.ZonedDateTime.from({ + years: 1976, + month: 11, + days: 18, + timeZone: "+01:00" +})); + diff --git a/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-required-prop-undefined-throws.js b/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-required-prop-undefined-throws.js index 794c16db59..698e2598f8 100644 --- a/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-required-prop-undefined-throws.js +++ b/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-required-prop-undefined-throws.js @@ -3,11 +3,10 @@ /*--- esid: sec-temporal.zoneddatetime.from -description: Temporal.ZonedDateTime.from({}) throws. +description: from() throws if a required property is undefined. features: [Temporal] ---*/ -// Temporal.ZonedDateTime.from(required prop undefined) throws assert.throws(TypeError, () => Temporal.ZonedDateTime.from({ year: 1976, month: undefined,