From 8790a8e98a1b3d3776751b02bbdbb61d25beb07e Mon Sep 17 00:00:00 2001 From: Caio Lima Date: Wed, 28 Aug 2019 12:44:14 -0300 Subject: [PATCH] Added private static accessor cases with direct eval access (#2305) --- ...te-static-getter-visible-to-direct-eval.js | 61 ++++++++++++++++++ ...te-static-setter-visible-to-direct-eval.js | 62 +++++++++++++++++++ 2 files changed, 123 insertions(+) create mode 100644 test/language/statements/class/elements/private-static-getter-visible-to-direct-eval.js create mode 100644 test/language/statements/class/elements/private-static-setter-visible-to-direct-eval.js diff --git a/test/language/statements/class/elements/private-static-getter-visible-to-direct-eval.js b/test/language/statements/class/elements/private-static-getter-visible-to-direct-eval.js new file mode 100644 index 0000000000..5cab31dfaf --- /dev/null +++ b/test/language/statements/class/elements/private-static-getter-visible-to-direct-eval.js @@ -0,0 +1,61 @@ +// Copyright (C) 2019 Caio Lima (Igalia SL). All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: Private static getter is visible to direct eval code +esid: sec-privatefieldget +info: | + PrivateFieldGet (P, O) + 1. Assert: P is a Private Name. + 2. If O is not an object, throw a TypeError exception. + 3. If P.[[Kind]] is "field", + a. Let entry be PrivateFieldFind(P, O). + b. If entry is empty, throw a TypeError exception. + c. Return entry.[[PrivateFieldValue]]. + 4. Perform ? PrivateBrandCheck(O, P). + 5. If P.[[Kind]] is "method", + a. Return P.[[Value]]. + 6. Else, + a. Assert: P.[[Kind]] is "accessor". + b. If P does not have a [[Get]] field, throw a TypeError exception. + c. Let getter be P.[[Get]]. + d. Return ? Call(getter, O). + + ClassElementName : PrivateIdentifier + 1. Let privateIdentifier be StringValue of PrivateIdentifier. + 2. Let privateName be NewPrivateName(privateIdentifier). + 3. Let scope be the running execution context's PrivateEnvironment. + 4. Let scopeEnvRec be scope's EnvironmentRecord. + 5. Perform ! scopeEnvRec.InitializeBinding(privateIdentifier, privateName). + 6. Return privateName. + + MakePrivateReference ( baseValue, privateIdentifier ) + 1. Let env be the running execution context's PrivateEnvironment. + 2. Let privateNameBinding be ? ResolveBinding(privateIdentifier, env). + 3. Let privateName be GetValue(privateNameBinding). + 4. Assert: privateName is a Private Name. + 5. Return a value of type Reference whose base value is baseValue, whose referenced name is privateName, whose strict reference flag is true. +features: [class-static-methods-private, class] +---*/ + +class C { + static get #m() { + return 'Test262'; + } + + static getWithEval() { + return eval('this.#m'); + } +} + +class D { + static get #m() { + throw new Test262Error('should never be executed'); + } +} + +assert.sameValue(C.getWithEval(), 'Test262'); + +assert.throws(TypeError, function() { + C.getWithEval.call(D); +}, 'invalid access to a static private getter'); diff --git a/test/language/statements/class/elements/private-static-setter-visible-to-direct-eval.js b/test/language/statements/class/elements/private-static-setter-visible-to-direct-eval.js new file mode 100644 index 0000000000..dcdaff72dc --- /dev/null +++ b/test/language/statements/class/elements/private-static-setter-visible-to-direct-eval.js @@ -0,0 +1,62 @@ +// Copyright (C) 2019 Caio Lima (Igalia SL). All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: Private static setter is visible to direct eval code +esid: sec-privatefieldget +info: | + PrivateFieldGet (P, O) + 1. Assert: P is a Private Name. + 2. If O is not an object, throw a TypeError exception. + 3. If P.[[Kind]] is "field", + a. Let entry be PrivateFieldFind(P, O). + b. If entry is empty, throw a TypeError exception. + c. Return entry.[[PrivateFieldValue]]. + 4. Perform ? PrivateBrandCheck(O, P). + 5. If P.[[Kind]] is "method", + a. Return P.[[Value]]. + 6. Else, + a. Assert: P.[[Kind]] is "accessor". + b. If P does not have a [[Get]] field, throw a TypeError exception. + c. Let getter be P.[[Get]]. + d. Return ? Call(getter, O). + + ClassElementName : PrivateIdentifier + 1. Let privateIdentifier be StringValue of PrivateIdentifier. + 2. Let privateName be NewPrivateName(privateIdentifier). + 3. Let scope be the running execution context's PrivateEnvironment. + 4. Let scopeEnvRec be scope's EnvironmentRecord. + 5. Perform ! scopeEnvRec.InitializeBinding(privateIdentifier, privateName). + 6. Return privateName. + + MakePrivateReference ( baseValue, privateIdentifier ) + 1. Let env be the running execution context's PrivateEnvironment. + 2. Let privateNameBinding be ? ResolveBinding(privateIdentifier, env). + 3. Let privateName be GetValue(privateNameBinding). + 4. Assert: privateName is a Private Name. + 5. Return a value of type Reference whose base value is baseValue, whose referenced name is privateName, whose strict reference flag is true. +features: [class-static-methods-private, class] +---*/ + +class C { + static set #m(v) { + this._v = v; + } + + static setWithEval() { + eval('this.#m = "Test262"'); + } +} + +class D { + static set #m(v) { + throw new Test262Error('should never be called'); + } +} + +C.setWithEval(); +assert.sameValue(C._v, 'Test262'); + +assert.throws(TypeError, function() { + C.getWithEval.call(D); +}, 'invalid access to a static private getter');