Add tests for DataView.prototype.setInt32

test/built-ins/DataView/prototype/setFloat64/no-value-arg.js

@@ -22,13 +22,12 @@ info: |
   24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value [ , isLittleEndian ] )
 
   ...
-  8. If type is "Float32", then
-    a. Set rawBytes to a List containing the 4 bytes that are the result of
-    converting value to IEEE 754-2008 binary32 format using “Round to nearest,
-    ties to even” rounding mode. If isLittleEndian is false, the bytes are
+  9. Else if type is "Float64", then
+    a. Set rawBytes to a List containing the 8 bytes that are the IEEE 754-2008
+    binary64 format encoding of value. If isLittleEndian is false, the bytes are
     arranged in big endian order. Otherwise, the bytes are arranged in little
     endian order. If value is NaN, rawValue may be set to any implementation
-    chosen IEEE 754-2008 binary32 format Not-a-Number encoding. An
+    chosen IEEE 754-2008 binary64 format Not-a-Number encoding. An
     implementation must always choose the same encoding for each implementation
     distinguishable NaN value.
   ...

test/built-ins/DataView/prototype/setFloat64/set-values-return-undefined.js

@@ -22,13 +22,12 @@ info: |
   24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value [ , isLittleEndian ] )
 
   ...
-  8. If type is "Float32", then
-    a. Set rawBytes to a List containing the 4 bytes that are the result of
-    converting value to IEEE 754-2008 binary32 format using “Round to nearest,
-    ties to even” rounding mode. If isLittleEndian is false, the bytes are
+  9. Else if type is "Float64", then
+    a. Set rawBytes to a List containing the 8 bytes that are the IEEE 754-2008
+    binary64 format encoding of value. If isLittleEndian is false, the bytes are
     arranged in big endian order. Otherwise, the bytes are arranged in little
     endian order. If value is NaN, rawValue may be set to any implementation
-    chosen IEEE 754-2008 binary32 format Not-a-Number encoding. An
+    chosen IEEE 754-2008 binary64 format Not-a-Number encoding. An
     implementation must always choose the same encoding for each implementation
     distinguishable NaN value.
   ...

test/built-ins/DataView/prototype/setInt32/byteoffset-is-different-integer-throws.js

@@ -0,0 +1,62 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Throws a RangeError if numberIndex ≠ getIndex
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  4. Let numberIndex be ? ToNumber(requestIndex).
+  5. Let getIndex be ToInteger(numberIndex).
+  6. If numberIndex ≠ getIndex or getIndex < 0, throw a RangeError exception.
+  ...
+features: [DataView.prototype.getInt32]
+---*/
+
+var buffer = new ArrayBuffer(12);
+var sample = new DataView(buffer, 0);
+
+assert.throws(RangeError, function() {
+  sample.setInt32();
+}, "no args");
+assert.sameValue(sample.getInt32(0), 0, "no args - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(undefined, 39);
+}, "undefined");
+assert.sameValue(sample.getInt32(0), 0, "undefined - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(1.1, 39);
+}, "floating number");
+assert.sameValue(sample.getInt32(0), 0, "floating number - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(0.1, 39);
+}, "0.1");
+assert.sameValue(sample.getInt32(0), 0, "0.1 - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(NaN, 39);
+}, "NaN");
+assert.sameValue(sample.getInt32(0), 0, "NaN - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(-0.1, 39);
+}, "-0.1");
+assert.sameValue(sample.getInt32(0), 0, "-0.1 - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(-1.1, 39);
+}, "-1.1");
+assert.sameValue(sample.getInt32(0), 0, "-1.1 - no value was set");

test/built-ins/DataView/prototype/setInt32/byteoffset-is-negative-throws.js

@@ -0,0 +1,37 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Throws a RangeError if getIndex < 0
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  4. Let numberIndex be ? ToNumber(requestIndex).
+  5. Let getIndex be ToInteger(numberIndex).
+  6. If numberIndex ≠ getIndex or getIndex < 0, throw a RangeError exception.
+  ...
+features: [DataView.prototype.getInt32]
+---*/
+
+var buffer = new ArrayBuffer(12);
+var sample = new DataView(buffer, 0);
+
+assert.throws(RangeError, function() {
+  sample.setInt32(-1, 39);
+}, "-1");
+assert.sameValue(sample.getInt32(0), 0, "-1 - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(-Infinity, 39);
+}, "-Infinity");
+assert.sameValue(sample.getInt32(0), 0, "-Infinity - no value was set");

test/built-ins/DataView/prototype/setInt32/detached-buffer-after-integer-byteoffset.js

@@ -0,0 +1,38 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Detached buffer is checked after checking If numberIndex ≠ getIndex or
+  getIndex < 0
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  6. If numberIndex ≠ getIndex or getIndex < 0, throw a RangeError exception.
+  ...
+  9. Let buffer be the value of view's [[ViewedArrayBuffer]] internal slot.
+  10. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
+  ...
+includes: [detachArrayBuffer.js]
+---*/
+
+var buffer = new ArrayBuffer(12);
+var sample = new DataView(buffer, 0);
+
+$DETACHBUFFER(buffer);
+assert.throws(RangeError, function() {
+  sample.setInt32(1.1, 0);
+});
+
+assert.throws(RangeError, function() {
+  sample.setInt32(-1, 0);
+});

test/built-ins/DataView/prototype/setInt32/detached-buffer-after-number-value.js

@@ -0,0 +1,39 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Detached buffer is checked after ToNumber(value)
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  7. Let numberValue be ? ToNumber(value).
+  ...
+  9. Let buffer be the value of view's [[ViewedArrayBuffer]] internal slot.
+  10. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
+  ...
+includes: [detachArrayBuffer.js]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var v = {
+  valueOf: function() {
+    throw new Test262Error();
+  }
+};
+
+$DETACHBUFFER(buffer);
+assert.throws(Test262Error, function() {
+  sample.setInt32(0, v);
+});

test/built-ins/DataView/prototype/setInt32/detached-buffer-before-outofrange-byteoffset.js

@@ -0,0 +1,40 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Detached buffer is checked before out of range byteOffset's value
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  9. Let buffer be the value of view's [[ViewedArrayBuffer]] internal slot.
+  10. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
+  ...
+  14. If getIndex + elementSize > viewSize, throw a RangeError exception.
+  ...
+includes: [detachArrayBuffer.js]
+---*/
+
+var sample;
+var buffer = new ArrayBuffer(12);
+
+sample = new DataView(buffer, 0);
+
+$DETACHBUFFER(buffer);
+
+assert.throws(TypeError, function() {
+  sample.setInt32(Infinity, 0);
+}, "Infinity");
+
+assert.throws(TypeError, function() {
+  sample.setInt32(13, 0);
+}, "13");

test/built-ins/DataView/prototype/setInt32/detached-buffer.js

@@ -0,0 +1,31 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Throws a TypeError if buffer is detached
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  9. Let buffer be the value of view's [[ViewedArrayBuffer]] internal slot.
+  10. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
+  ...
+includes: [detachArrayBuffer.js]
+---*/
+
+var buffer = new ArrayBuffer(1);
+var sample = new DataView(buffer, 0);
+
+$DETACHBUFFER(buffer);
+assert.throws(TypeError, function() {
+  sample.setInt32(0, 0);
+});

test/built-ins/DataView/prototype/setInt32/index-check-before-value-conversion.js

@@ -4,25 +4,27 @@
 /*---
 esid: sec-dataview.prototype.setint32
 description: >
-  Throws a RangeError if the index is negative or non-integral number.
+  RangeError exception for negative or non-integral index is thrown before
+  the value conversion.
 info: >
   ...
   3. Return SetViewValue(v, byteOffset, littleEndian, "Int32", value).
 
   24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
-    ...
-    3. Let numberIndex be ToNumber(requestIndex).
-    4. Let getIndex be ? ToInteger(numberIndex).
-    5. If numberIndex ≠ getIndex or getIndex < 0, throw a RangeError exception.
-    6. Let numberValue be ? ToNumber(value).
-    ...
+
+  ...
+  4. Let numberIndex be ToNumber(requestIndex).
+  5. Let getIndex be ? ToInteger(numberIndex).
+  6. If numberIndex ≠ getIndex or getIndex < 0, throw a RangeError exception.
+  7. Let numberValue be ? ToNumber(value).
+  ...
 ---*/
 
-var dataView = new DataView(new ArrayBuffer(8));
+var dataView = new DataView(new ArrayBuffer(8), 0);
 
 var poisoned = {
   valueOf: function() {
-    $ERROR("valueOf called");
+    throw new Test262Error("valueOf called");
   }
 };
 

test/built-ins/DataView/prototype/setInt32/index-is-out-of-range.js

@@ -0,0 +1,90 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Throws a RangeError if getIndex + elementSize > viewSize
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  11. Let viewOffset be the value of view's [[ByteOffset]] internal slot.
+  12. Let viewSize be the value of view's [[ByteLength]] internal slot.
+  13. Let elementSize be the Number value of the Element Size value specified in
+  Table 50 for Element Type type.
+  14. If getIndex + elementSize > viewSize, throw a RangeError exception.
+  ...
+features: [DataView.prototype.getInt32]
+---*/
+
+var sample;
+var buffer = new ArrayBuffer(12);
+
+sample = new DataView(buffer, 0);
+
+assert.throws(RangeError, function() {
+  sample.setInt32(Infinity, 39);
+}, "getIndex == Infinity");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(13, 39);
+}, "13 + 4 > 12");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(12, 39);
+}, "12 + 4 > 12");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(11, 39);
+}, "11 + 4 > 12");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(10, 39);
+}, "10 + 4 > 12");
+
+assert.throws(RangeError, function() {
+  sample.setInt32(9, 39);
+}, "9 + 4 > 12");
+
+sample = new DataView(buffer, 8);
+assert.throws(RangeError, function() {
+  sample.setInt32(1, 39);
+}, "1 + 4 > 4 (offset)");
+
+sample = new DataView(buffer, 9);
+assert.throws(RangeError, function() {
+  sample.setInt32(0, 39);
+}, "0 + 4 > 3 (offset)");
+
+sample = new DataView(buffer, 0, 4);
+assert.throws(RangeError, function() {
+  sample.setInt32(1, 39);
+}, "1 + 4 > 4 (length)");
+
+sample = new DataView(buffer, 0, 3);
+assert.throws(RangeError, function() {
+  sample.setInt32(0, 39);
+}, "0 + 4 > 3 (length)");
+
+sample = new DataView(buffer, 4, 4);
+assert.throws(RangeError, function() {
+  sample.setInt32(1, 39);
+}, "1 + 4 > 4 (offset+length)");
+
+sample = new DataView(buffer, 4, 3);
+assert.throws(RangeError, function() {
+  sample.setInt32(0, 39);
+}, "0 + 4 > 3 (offset+length)");
+
+sample = new DataView(buffer, 0);
+assert.sameValue(sample.getInt32(0), 0, "[0] no value was set");
+assert.sameValue(sample.getInt32(4), 0, "[1] no value was set");
+assert.sameValue(sample.getInt32(8), 0, "[2] no value was set");

test/built-ins/DataView/prototype/setInt32/index-to-integer.js

@@ -17,7 +17,7 @@ info: >
     ...
 ---*/
 
-var dataView = new DataView(new ArrayBuffer(8));
+var dataView = new DataView(new ArrayBuffer(8), 0);
 
 dataView.setInt32(+0, 1);
 assert.sameValue(dataView.getInt32(0), 1, "setInt32(+0, 1)");

test/built-ins/DataView/prototype/setInt32/no-value-arg.js

@@ -0,0 +1,39 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Set value as undefined (cast to 0) when value argument is not present
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  15. Let bufferIndex be getIndex + viewOffset.
+  16. Return SetValueInBuffer(buffer, bufferIndex, type, numberValue, isLittleEndian).
+
+  24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value [ , isLittleEndian ] )
+
+  ...
+  11. Store the individual bytes of rawBytes into block, in order, starting at
+  block[byteIndex].
+  12. Return NormalCompletion(undefined).
+features: [DataView.prototype.getInt32]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+sample.setInt32(0, 42);
+
+var result = sample.setInt32(0);
+
+assert.sameValue(sample.getInt32(0), 0);
+assert.sameValue(result, undefined);

test/built-ins/DataView/prototype/setInt32/range-check-after-value-conversion.js

@@ -22,28 +22,26 @@ info: >
     ...
 ---*/
 
-var dataView = new DataView(new ArrayBuffer(8));
-
-function DummyError() { }
+var dataView = new DataView(new ArrayBuffer(8), 0);
 
 var poisoned = {
   valueOf: function() {
-    throw new DummyError();
+    throw new Test262Error();
   }
 };
 
-assert.throws(DummyError, function() {
+assert.throws(Test262Error, function() {
   dataView.setInt32(Infinity, poisoned);
 }, "setInt32(Infinity, poisoned)");
 
-assert.throws(DummyError, function() {
+assert.throws(Test262Error, function() {
   dataView.setInt32(100, poisoned);
 }, "setInt32(100, poisoned)");
 
-assert.throws(DummyError, function() {
+assert.throws(Test262Error, function() {
   dataView.setInt32('Infinity', poisoned);
 }, "setInt32('Infinity', poisoned)");
 
-assert.throws(DummyError, function() {
+assert.throws(Test262Error, function() {
   dataView.setInt32('100', poisoned);
 }, "setInt32('100', poisoned)");

test/built-ins/DataView/prototype/setInt32/return-abrupt-from-tonumber-byteoffset-symbol.js

@@ -0,0 +1,31 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Return abrupt from ToNumber(symbol byteOffset)
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  4. Let numberIndex be ? ToNumber(requestIndex).
+  ...
+features: [Symbol]
+---*/
+
+var buffer = new ArrayBuffer(1);
+var sample = new DataView(buffer, 0);
+
+var s = Symbol("1");
+
+assert.throws(TypeError, function() {
+  sample.setInt32(s, 1);
+});

test/built-ins/DataView/prototype/setInt32/return-abrupt-from-tonumber-byteoffset.js

@@ -0,0 +1,44 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Return abrupt from ToNumber(byteOffset)
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  4. Let numberIndex be ? ToNumber(requestIndex).
+  ...
+---*/
+
+var buffer = new ArrayBuffer(1);
+var sample = new DataView(buffer, 0);
+
+var bo1 = {
+  valueOf: function() {
+    throw new Test262Error();
+  }
+};
+
+var bo2 = {
+  toString: function() {
+    throw new Test262Error();
+  }
+};
+
+assert.throws(Test262Error, function() {
+  sample.setInt32(bo1, 1);
+}, "valueOf");
+
+assert.throws(Test262Error, function() {
+  sample.setInt32(bo2, 1);
+}, "toString");

test/built-ins/DataView/prototype/setInt32/return-abrupt-from-tonumber-value-symbol.js

@@ -0,0 +1,31 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Return abrupt from ToNumber(symbol value)
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  7. Let numberValue be ? ToNumber(value).
+  ...
+features: [Symbol]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var s = Symbol("1");
+
+assert.throws(TypeError, function() {
+  sample.setInt32(0, s);
+});

test/built-ins/DataView/prototype/setInt32/return-abrupt-from-tonumber-value.js

@@ -0,0 +1,44 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Return abrupt from ToNumber(value)
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  7. Let numberValue be ? ToNumber(value).
+  ...
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var bo1 = {
+  valueOf: function() {
+    throw new Test262Error();
+  }
+};
+
+var bo2 = {
+  toString: function() {
+    throw new Test262Error();
+  }
+};
+
+assert.throws(Test262Error, function() {
+  sample.setInt32(0, bo1);
+}, "valueOf");
+
+assert.throws(Test262Error, function() {
+  sample.setInt32(0, bo2);
+}, "toString");

test/built-ins/DataView/prototype/setInt32/set-values-little-endian-order.js

@@ -0,0 +1,58 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Set values on the little endian order
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  15. Let bufferIndex be getIndex + viewOffset.
+  16. Return SetValueInBuffer(buffer, bufferIndex, type, numberValue, isLittleEndian).
+
+  24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value [ , isLittleEndian ] )
+
+  ...
+  11. Store the individual bytes of rawBytes into block, in order, starting at
+  block[byteIndex].
+  12. Return NormalCompletion(undefined).
+features: [DataView.prototype.getInt32]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var result;
+
+result = sample.setInt32(0, -1870724872, true);
+assert.sameValue(result, undefined, "returns undefined #1");
+assert.sameValue(sample.getInt32(0), -134185072);
+
+result = sample.setInt32(0, -134185072, true);
+assert.sameValue(result, undefined, "returns undefined #2");
+assert.sameValue(sample.getInt32(0), -1870724872);
+
+result = sample.setInt32(0, 1870724872, true);
+assert.sameValue(result, undefined, "returns undefined #3");
+assert.sameValue(sample.getInt32(0), 150962287);
+
+result = sample.setInt32(0, 150962287, true);
+assert.sameValue(result, undefined, "returns undefined #4");
+assert.sameValue(sample.getInt32(0), 1870724872);
+
+result = sample.setInt32(0, 4160782224, true);
+assert.sameValue(result, undefined, "returns undefined #5");
+assert.sameValue(sample.getInt32(0), -1870724872);
+
+result = sample.setInt32(0, 2424242424, true);
+assert.sameValue(result, undefined, "returns undefined #6");
+assert.sameValue(sample.getInt32(0), -134185072);

test/built-ins/DataView/prototype/setInt32/set-values-return-undefined.js

@@ -0,0 +1,53 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Set values and return undefined
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  15. Let bufferIndex be getIndex + viewOffset.
+  16. Return SetValueInBuffer(buffer, bufferIndex, type, numberValue, isLittleEndian).
+
+  24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value [ , isLittleEndian ] )
+
+  ...
+  11. Store the individual bytes of rawBytes into block, in order, starting at
+  block[byteIndex].
+  12. Return NormalCompletion(undefined).
+features: [DataView.prototype.getInt32]
+includes: [byteConversionValues.js]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var values = byteConversionValues.values;
+var expectedValues = byteConversionValues.expected.Int32;
+
+values.forEach(function(value, i) {
+  var expected = expectedValues[i];
+
+  var result = sample.setInt32(0, value, false);
+
+  assert.sameValue(
+    sample.getInt32(0),
+    expected,
+    "value: " + value
+  );
+  assert.sameValue(
+    result,
+    undefined,
+    "return is undefined, value: " + value
+  );
+});

test/built-ins/DataView/prototype/setInt32/this-has-no-dataview-internal.js

@@ -0,0 +1,43 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Throws a TypeError if this does not have a [[DataView]] internal slot
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  1. If Type(view) is not Object, throw a TypeError exception.
+  2. If view does not have a [[DataView]] internal slot, throw a TypeError
+  exception.
+  ...
+features: [Int8Array]
+---*/
+
+var setInt32 = DataView.prototype.setInt32;
+
+assert.throws(TypeError, function() {
+  setInt32.call({});
+}, "{}");
+
+assert.throws(TypeError, function() {
+  setInt32.call([]);
+}, "[]");
+
+var ab = new ArrayBuffer(1);
+assert.throws(TypeError, function() {
+  setInt32.call(ab);
+}, "ArrayBuffer");
+
+var ta = new Int8Array();
+assert.throws(TypeError, function() {
+  setInt32.call(ta);
+}, "TypedArray");

test/built-ins/DataView/prototype/setInt32/this-is-not-object.js

@@ -0,0 +1,51 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: Throws a TypeError if this is not Object
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  1. If Type(view) is not Object, throw a TypeError exception.
+  ...
+features: [Symbol]
+---*/
+
+var setInt32 = DataView.prototype.setInt32;
+
+assert.throws(TypeError, function() {
+  setInt32.call(undefined);
+}, "undefined");
+
+assert.throws(TypeError, function() {
+  setInt32.call(null);
+}, "null");
+
+assert.throws(TypeError, function() {
+  setInt32.call(1);
+}, "1");
+
+assert.throws(TypeError, function() {
+  setInt32.call("string");
+}, "string");
+
+assert.throws(TypeError, function() {
+  setInt32.call(true);
+}, "true");
+
+assert.throws(TypeError, function() {
+  setInt32.call(false);
+}, "false");
+
+var s = Symbol("1");
+assert.throws(TypeError, function() {
+  setInt32.call(s);
+}, "symbol");

test/built-ins/DataView/prototype/setInt32/to-boolean-littleendian.js

@@ -0,0 +1,47 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setint32
+es6id: 24.2.4.17
+description: >
+  Boolean littleEndian argument coerced in ToBoolean
+info: |
+  24.2.4.17 DataView.prototype.setInt32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Int32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  15. Let bufferIndex be getIndex + viewOffset.
+  16. Return SetValueInBuffer(buffer, bufferIndex, type, numberValue, isLittleEndian).
+features: [DataView.prototype.getInt32, Symbol]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+// False
+sample.setInt32(0, 1);
+assert.sameValue(sample.getInt32(0), 1, "no arg");
+sample.setInt32(0, 2, undefined);
+assert.sameValue(sample.getInt32(0), 2, "undefined");
+sample.setInt32(0, 3, null);
+assert.sameValue(sample.getInt32(0), 3, "null");
+sample.setInt32(0, 4, 0);
+assert.sameValue(sample.getInt32(0), 4, "0");
+sample.setInt32(0, 5, "");
+assert.sameValue(sample.getInt32(0), 5, "the empty string");
+
+// True
+sample.setInt32(0, 6, {});
+assert.sameValue(sample.getInt32(0), 100663296, "{}");
+sample.setInt32(0, 7, Symbol("1"));
+assert.sameValue(sample.getInt32(0), 117440512, "symbol");
+sample.setInt32(0, 8, 1);
+assert.sameValue(sample.getInt32(0), 134217728, "1");
+sample.setInt32(0, 9, "string");
+assert.sameValue(sample.getInt32(0), 150994944, "string");