From d420adb9f238b813dba916876bca276da9b80914 Mon Sep 17 00:00:00 2001 From: test262-automation Date: Tue, 4 Dec 2018 19:13:06 +0000 Subject: [PATCH 1/2] [v8-test262-automation] Changes from https://github.com/v8/v8.git at sha 4a395137 on Tue Dec 04 2018 19:12:32 GMT+0000 (Coordinated Universal Time) --- .../v8/intl/list-format/constructor.js | 19 --------------- .../intl/relative-time-format/constructor.js | 24 ------------------- .../v8/intl/segmenter/constructor-order.js | 23 ++++++++++++++++++ .../v8/mjsunit/harmony/bigint/regressions.js | 4 ++-- .../v8/wasm-js/wasm-js.status | 8 ++++++- 5 files changed, 32 insertions(+), 46 deletions(-) create mode 100644 implementation-contributed/v8/intl/segmenter/constructor-order.js diff --git a/implementation-contributed/v8/intl/list-format/constructor.js b/implementation-contributed/v8/intl/list-format/constructor.js index 2ef2c5088b..d730516c9c 100644 --- a/implementation-contributed/v8/intl/list-format/constructor.js +++ b/implementation-contributed/v8/intl/list-format/constructor.js @@ -88,22 +88,3 @@ assertDoesNotThrow( assertDoesNotThrow( () => new Intl.ListFormat(['sr'], {type: 'unit', style: 'narrow'})); - -// Throws only once during construction. -// Check for all getters to prevent regression. -// Preserve the order of getter initialization. -let getCount = 0; -let style = -1; -let type = -1; - -new Intl.ListFormat(['en-US'], { - get style() { - style = ++getCount; - }, - get type() { - type = ++getCount; - } -}); - -assertEquals(1, type); -assertEquals(2, style); diff --git a/implementation-contributed/v8/intl/relative-time-format/constructor.js b/implementation-contributed/v8/intl/relative-time-format/constructor.js index 91d649891d..ba03e1dd70 100644 --- a/implementation-contributed/v8/intl/relative-time-format/constructor.js +++ b/implementation-contributed/v8/intl/relative-time-format/constructor.js @@ -77,27 +77,3 @@ assertDoesNotThrow( assertThrows( () => new Intl.RelativeTimeFormat('sr', {numeric: 'never'}), RangeError); - -// Throws only once during construction. -// Check for all getters to prevent regression. -// Preserve the order of getter initialization. -let getCount = 0; -let localeMatcher = -1; -let style = -1; -let numeric = -1; - -new Intl.RelativeTimeFormat('en-US', { - get localeMatcher() { - localeMatcher = ++getCount; - }, - get style() { - style = ++getCount; - }, - get numeric() { - numeric = ++getCount; - } -}); - -assertEquals(1, localeMatcher); -assertEquals(2, style); -assertEquals(3, numeric); diff --git a/implementation-contributed/v8/intl/segmenter/constructor-order.js b/implementation-contributed/v8/intl/segmenter/constructor-order.js new file mode 100644 index 0000000000..09ff8f1fe0 --- /dev/null +++ b/implementation-contributed/v8/intl/segmenter/constructor-order.js @@ -0,0 +1,23 @@ +// Copyright 2018 the V8 project authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Flags: --harmony-intl-segmenter + +// Throws only once during construction. +// Check for all getters to prevent regression. +// Preserve the order of getter initialization. +let getCount = 0; + +new Intl.Segmenter(['en-US'], { + get localeMatcher() { + assertEquals(0, getCount++); + }, + get lineBreakStyle() { + assertEquals(1, getCount++); + }, + get granularity() { + assertEquals(2, getCount++); + }, +}); +assertEquals(3, getCount); diff --git a/implementation-contributed/v8/mjsunit/harmony/bigint/regressions.js b/implementation-contributed/v8/mjsunit/harmony/bigint/regressions.js index 8e13622eab..b4a55c1ffd 100644 --- a/implementation-contributed/v8/mjsunit/harmony/bigint/regressions.js +++ b/implementation-contributed/v8/mjsunit/harmony/bigint/regressions.js @@ -19,8 +19,8 @@ assertTrue(0n === 0n); // crbug.com/818277: Must throw without DCHECK failures. // In order to run acceptably fast in Debug mode, this test assumes that -// we allow at least 2 billion bits in a BigInt. -var close_to_limit = 2n ** 2000000000n; +// we allow at least 1 billion bits in a BigInt. +var close_to_limit = 2n ** 1000000000n; assertThrows(() => close_to_limit ** 100n, RangeError); // Check boundary conditions of the power-of-two fast path. diff --git a/implementation-contributed/v8/wasm-js/wasm-js.status b/implementation-contributed/v8/wasm-js/wasm-js.status index e2b06903c0..2f3111aa3a 100644 --- a/implementation-contributed/v8/wasm-js/wasm-js.status +++ b/implementation-contributed/v8/wasm-js/wasm-js.status @@ -14,5 +14,11 @@ 'module/customSections': [FAIL], 'global/constructor': [FAIL], 'global/value-get-set': [FAIL], -}] # ALWAYS +}], # ALWAYS + +['arch == s390 or arch == s390x or system == aix', { + # https://bugs.chromium.org/p/v8/issues/detail?id=8402 + 'instance/constructor': [SKIP], +}], # 'arch == s390 or arch == s390x or system == aix' + ] From 5303404d5413563f1c271ff056d92c471dfcfc90 Mon Sep 17 00:00:00 2001 From: test262-automation Date: Tue, 4 Dec 2018 19:13:09 +0000 Subject: [PATCH 2/2] [v8-test262-automation] Updated curation log with latest revision sha's from export and changed files. sourceRevisionAtLastExport: 4a395137 targetRevisionAtLastExport: 07b313100e --- .../curation_logs/v8.json | 4 +- .../v8/intl/collator/constructor-order.js | 30 +++++++++++++ .../v8/intl/list-format/constructor-order.js | 21 ++++++++++ .../intl/number-format/constructor-order.js | 42 +++++++++++++++++++ .../v8/intl/plural-rules/constructor-order.js | 33 +++++++++++++++ .../relative-time-format/constructor-order.js | 21 ++++++++++ .../mjsunit/regress/regress-crbug-909614.js | 9 ++++ 7 files changed, 158 insertions(+), 2 deletions(-) create mode 100644 implementation-contributed/v8/intl/collator/constructor-order.js create mode 100644 implementation-contributed/v8/intl/list-format/constructor-order.js create mode 100644 implementation-contributed/v8/intl/number-format/constructor-order.js create mode 100644 implementation-contributed/v8/intl/plural-rules/constructor-order.js create mode 100644 implementation-contributed/v8/intl/relative-time-format/constructor-order.js create mode 100644 implementation-contributed/v8/mjsunit/regress/regress-crbug-909614.js diff --git a/implementation-contributed/curation_logs/v8.json b/implementation-contributed/curation_logs/v8.json index f32cdc95fd..35a2852a25 100644 --- a/implementation-contributed/curation_logs/v8.json +++ b/implementation-contributed/curation_logs/v8.json @@ -1,5 +1,5 @@ { - "sourceRevisionAtLastExport": "4a395137", - "targetRevisionAtLastExport": "07b313100e", + "sourceRevisionAtLastExport": "9583858e", + "targetRevisionAtLastExport": "d420adb9f2", "curatedFiles": {} } \ No newline at end of file diff --git a/implementation-contributed/v8/intl/collator/constructor-order.js b/implementation-contributed/v8/intl/collator/constructor-order.js new file mode 100644 index 0000000000..2b1de6b866 --- /dev/null +++ b/implementation-contributed/v8/intl/collator/constructor-order.js @@ -0,0 +1,30 @@ +// Copyright 2018 the V8 project authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Throws only once during construction. +// Check for all getters to prevent regression. +// Preserve the order of getter initialization. +let getCount = 0; + +new Intl.Collator(['en-US'], { + get usage() { + assertEquals(0, getCount++); + }, + get localeMatcher() { + assertEquals(1, getCount++); + }, + get numeric() { + assertEquals(2, getCount++); + }, + get caseFirst() { + assertEquals(3, getCount++); + }, + get sensitivity() { + assertEquals(4, getCount++); + }, + get ignorePunctuation() { + assertEquals(5, getCount++); + }, +}); +assertEquals(6, getCount); diff --git a/implementation-contributed/v8/intl/list-format/constructor-order.js b/implementation-contributed/v8/intl/list-format/constructor-order.js new file mode 100644 index 0000000000..1fc7d99429 --- /dev/null +++ b/implementation-contributed/v8/intl/list-format/constructor-order.js @@ -0,0 +1,21 @@ +// Copyright 2018 the V8 project authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Throws only once during construction. +// Check for all getters to prevent regression. +// Preserve the order of getter initialization. +let getCount = 0; + +new Intl.ListFormat(['en-US'], { + get type() { + assertEquals(0, getCount++); + }, + get style() { + assertEquals(1, getCount++); + }, + get localeMatcher() { + assertEquals(2, getCount++); + }, +}); +assertEquals(3, getCount); diff --git a/implementation-contributed/v8/intl/number-format/constructor-order.js b/implementation-contributed/v8/intl/number-format/constructor-order.js new file mode 100644 index 0000000000..db99793bb9 --- /dev/null +++ b/implementation-contributed/v8/intl/number-format/constructor-order.js @@ -0,0 +1,42 @@ +// Copyright 2018 the V8 project authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Throws only once during construction. +// Check for all getters to prevent regression. +// Preserve the order of getter initialization. +let getCount = 0; + +new Intl.NumberFormat(['en-US'], { + get localeMatcher() { + assertEquals(0, getCount++); + }, + get style() { + assertEquals(1, getCount++); + }, + get currency() { + assertEquals(2, getCount++); + }, + get currencyDisplay() { + assertEquals(3, getCount++); + }, + get minimumIntegerDigits() { + assertEquals(4, getCount++); + }, + get minimumFractionDigits() { + assertEquals(5, getCount++); + }, + get maximumFractionDigits() { + assertEquals(6, getCount++); + }, + get minimumSignificantDigits() { + assertEquals(7, getCount++); + }, + get maximumSignificantDigits() { + assertEquals(8, getCount++); + }, + get useGrouping() { + assertEquals(9, getCount++); + }, +}); +assertEquals(10, getCount); diff --git a/implementation-contributed/v8/intl/plural-rules/constructor-order.js b/implementation-contributed/v8/intl/plural-rules/constructor-order.js new file mode 100644 index 0000000000..18acdcccbb --- /dev/null +++ b/implementation-contributed/v8/intl/plural-rules/constructor-order.js @@ -0,0 +1,33 @@ +// Copyright 2018 the V8 project authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Throws only once during construction. +// Check for all getters to prevent regression. +// Preserve the order of getter initialization. +let getCount = 0; + +new Intl.PluralRules(['en-US'], { + get localeMatcher() { + assertEquals(0, getCount++); + }, + get type() { + assertEquals(1, getCount++); + }, + get minimumIntegerDigits() { + assertEquals(2, getCount++); + }, + get minimumFractionDigits() { + assertEquals(3, getCount++); + }, + get maximumFractionDigits() { + assertEquals(4, getCount++); + }, + get minimumSignificantDigits() { + assertEquals(5, getCount++); + }, + get maximumSignificantDigits() { + assertEquals(6, getCount++); + }, +}); +assertEquals(7, getCount); diff --git a/implementation-contributed/v8/intl/relative-time-format/constructor-order.js b/implementation-contributed/v8/intl/relative-time-format/constructor-order.js new file mode 100644 index 0000000000..540034dd4d --- /dev/null +++ b/implementation-contributed/v8/intl/relative-time-format/constructor-order.js @@ -0,0 +1,21 @@ +// Copyright 2018 the V8 project authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Throws only once during construction. +// Check for all getters to prevent regression. +// Preserve the order of getter initialization. +let getCount = 0; + +new Intl.RelativeTimeFormat(['en-US'], { + get localeMatcher() { + assertEquals(0, getCount++); + }, + get style() { + assertEquals(1, getCount++); + }, + get numeric() { + assertEquals(2, getCount++); + }, +}); +assertEquals(3, getCount); diff --git a/implementation-contributed/v8/mjsunit/regress/regress-crbug-909614.js b/implementation-contributed/v8/mjsunit/regress/regress-crbug-909614.js new file mode 100644 index 0000000000..4070c9b821 --- /dev/null +++ b/implementation-contributed/v8/mjsunit/regress/regress-crbug-909614.js @@ -0,0 +1,9 @@ +// Copyright 2018 the V8 project authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +let just_under = 2n ** 30n - 1n; +let just_above = 2n ** 30n; + +assertDoesNotThrow(() => { var dummy = 2n ** just_under; }); +assertThrows(() => { var dummy = 2n ** just_above; });