Generation: don't make negative parse SyntaxError tests that have flags: [async]. Fixes gh-1229

tools/generation/lib/template.py

@@ -156,10 +156,20 @@ class Template:
         if len(features):
             lines += ['features: ' + re.sub('\n\s*', ' ', yaml.dump(features, default_flow_style=True).strip())]
 
+        # Reconcile "negative" meta data before "flags"
+        if case_values['meta'].get('negative'):
+            if self.attribs['meta'].get('negative'):
+                raise Exception('Cannot specify negative in case and template file')
+            negative = case_values['meta'].get('negative')
+        else:
+            negative = self.attribs['meta'].get('negative')
+
         flags = ['generated']
         flags += case_values['meta'].get('flags', [])
         flags += self.attribs['meta'].get('flags', [])
         flags = list(OrderedDict.fromkeys(flags))
+        if 'async' in flags and negative and negative.get('phase') == 'parse' and negative.get('type') == 'SyntaxError':
+            flags.remove('async')
         lines += ['flags: ' + re.sub('\n\s*', ' ', yaml.dump(flags, default_flow_style=True).strip())]
 
         includes = []
@@ -169,17 +179,9 @@ class Template:
         if len(includes):
             lines += ['includes: ' + re.sub('\n\s*', ' ', yaml.dump(includes, default_flow_style=True).strip())]
 
-        if case_values['meta'].get('negative'):
-            if self.attribs['meta'].get('negative'):
-                raise Exception('Cannot specify negative in case and template file')
-            negative = case_values['meta'].get('negative')
-        else:
-            negative = self.attribs['meta'].get('negative')
-
         if negative:
             lines += ['negative:']
-            as_yaml = yaml.dump(negative,
+            as_yaml = yaml.dump(negative, default_flow_style=False)
-                                default_flow_style=False)
             lines += indent(as_yaml.strip(), '  ').split('\n')
 
         info = []

tools/generation/test/expected/async/async-function-declaration-async-negative-invalid.js

@@ -0,0 +1,17 @@
+// This file was procedurally generated from the following sources:
+// - tools/generation/test/fixtures/async-negative-invalid.case
+// - tools/generation/test/fixtures/async/async.template
+/*---
+description: Early SyntaxError tests should not include "async" in flags[] (async function declaration)
+esid: prod-AsyncFunctionDeclaration
+flags: [generated]
+negative:
+  phase: parse
+  type: SyntaxError
+---*/
+$DONOTEVALUATE();
+
+async function fn() {
+  await 1;
+  1=1;
+}

tools/generation/test/fixtures/async-negative-invalid.case

@@ -0,0 +1,15 @@
+// Copyright (C) 2017 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+desc: Early SyntaxError tests should not include "async" in flags[]
+template: async
+negative:
+  phase: parse
+  type: SyntaxError
+---*/
+
+//- setup
+$DONOTEVALUATE();
+//- body
+1=1;

tools/generation/test/fixtures/async/async.template

@@ -0,0 +1,13 @@
+// Copyright (C) 2017 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+path: async/async-function-declaration-
+name: async function declaration
+esid: prod-AsyncFunctionDeclaration
+flags: [async]
+---*/
+
+async function fn() {
+  await 1;
+  /*{ body }*/
+}

tools/generation/test/run.py

@@ -59,6 +59,11 @@ class TestGeneration(unittest.TestCase):
         self.assertEqual(result['returncode'], 0)
         self.compareTrees('normal')
 
+    def test_async(self):
+        result = self.fixture('async-negative-invalid.case')
+        self.assertEqual(result['returncode'], 0)
+        self.compareTrees('async')
+
     def test_negative(self):
         result = self.fixture('negative.case')
         self.assertEqual(result['returncode'], 0)