From 983b1aceb59bcdfaca8cea9258afd701c2ce3563 Mon Sep 17 00:00:00 2001 From: Alexey Shvayka Date: Wed, 11 Mar 2020 12:35:01 +0200 Subject: [PATCH] Add [[OwnPropertyKeys]] tests --- .../trap-is-missing-target-is-proxy.js | 46 ++++++++++++++++++ .../ownKeys/trap-is-null-target-is-proxy.js | 48 +++++++++++++++++++ .../trap-is-undefined-target-is-proxy.js | 40 ++++++++++++++++ 3 files changed, 134 insertions(+) create mode 100644 test/built-ins/Proxy/ownKeys/trap-is-missing-target-is-proxy.js create mode 100644 test/built-ins/Proxy/ownKeys/trap-is-null-target-is-proxy.js create mode 100644 test/built-ins/Proxy/ownKeys/trap-is-undefined-target-is-proxy.js diff --git a/test/built-ins/Proxy/ownKeys/trap-is-missing-target-is-proxy.js b/test/built-ins/Proxy/ownKeys/trap-is-missing-target-is-proxy.js new file mode 100644 index 0000000000..0e48d82b16 --- /dev/null +++ b/test/built-ins/Proxy/ownKeys/trap-is-missing-target-is-proxy.js @@ -0,0 +1,46 @@ +// Copyright (C) 2020 Alexey Shvayka. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys +description: > + If "ownKeys" trap is null or undefined, [[OwnPropertyKeys]] call is + properly forwarded to [[ProxyTarget]] (which is also a Proxy object). +info: | + [[OwnPropertyKeys]] ( ) + + [...] + 4. Let target be O.[[ProxyTarget]]. + 5. Let trap be ? GetMethod(handler, "ownKeys"). + 6. If trap is undefined, then + a. Return ? target.[[OwnPropertyKeys]](). + + [[OwnPropertyKeys]] ( ) + + 1. Let keys be a new empty List. + [...] + 5. For each integer i starting with 0 such that i < len, in ascending order, do + a. Add ! ToString(i) as the last element of keys. + [...] + 7. For each own property key P of O such that Type(P) is String and P is not an + array index, in ascending chronological order of property creation, do + a. Add P as the last element of keys. + 8. For each own property key P of O such that Type(P) is Symbol, in ascending + chronological order of property creation, do + a. Add P as the last element of keys. + 9. Return keys. +includes: [compareArray.js] +features: [Symbol, Proxy, Reflect] +---*/ + +var sym = Symbol(); +var string = new String("str"); +string[sym] = 1; + +var stringTarget = new Proxy(string, {}); +var stringProxy = new Proxy(stringTarget, {}); + +assert.compareArray( + Reflect.ownKeys(stringProxy), + ["0", "1", "2", "length", sym] +); diff --git a/test/built-ins/Proxy/ownKeys/trap-is-null-target-is-proxy.js b/test/built-ins/Proxy/ownKeys/trap-is-null-target-is-proxy.js new file mode 100644 index 0000000000..0e3f98e472 --- /dev/null +++ b/test/built-ins/Proxy/ownKeys/trap-is-null-target-is-proxy.js @@ -0,0 +1,48 @@ +// Copyright (C) 2020 Alexey Shvayka. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys +description: > + If "ownKeys" trap is null or undefined, [[OwnPropertyKeys]] call is + properly forwarded to [[ProxyTarget]] (which is also a Proxy object). +info: | + [[OwnPropertyKeys]] ( ) + + [...] + 4. Let target be O.[[ProxyTarget]]. + 5. Let trap be ? GetMethod(handler, "ownKeys"). + 6. If trap is undefined, then + a. Return ? target.[[OwnPropertyKeys]](). + + OrdinaryOwnPropertyKeys ( O ) + + 1. Let keys be a new empty List. + 2. For each own property key P of O that is an array index, + in ascending numeric index order, do + a. Add P as the last element of keys. + 3. For each own property key P of O that is a String but is not an + array index, in ascending chronological order of property creation, do + a. Add P as the last element of keys. + [...] + 5. Return keys. +includes: [compareArray.js] +features: [Proxy] +---*/ + +var plainObject = { + foo: 1, + "0": 2, + get bar() {}, + "1": 4, +}; + +var plainObjectTarget = new Proxy(plainObject, {}); +var plainObjectProxy = new Proxy(plainObjectTarget, { + ownKeys: null, +}); + +assert.compareArray( + Object.keys(plainObjectProxy), + ["0", "1", "foo", "bar"] +); diff --git a/test/built-ins/Proxy/ownKeys/trap-is-undefined-target-is-proxy.js b/test/built-ins/Proxy/ownKeys/trap-is-undefined-target-is-proxy.js new file mode 100644 index 0000000000..6e34ddc4cd --- /dev/null +++ b/test/built-ins/Proxy/ownKeys/trap-is-undefined-target-is-proxy.js @@ -0,0 +1,40 @@ +// Copyright (C) 2020 Alexey Shvayka. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys +description: > + If "ownKeys" trap is null or undefined, [[OwnPropertyKeys]] call is + properly forwarded to [[ProxyTarget]] (which is also a Proxy object). +info: | + [[OwnPropertyKeys]] ( ) + + [...] + 4. Let target be O.[[ProxyTarget]]. + 5. Let trap be ? GetMethod(handler, "ownKeys"). + 6. If trap is undefined, then + a. Return ? target.[[OwnPropertyKeys]](). + + [[OwnPropertyKeys]] ( ) + + [...] + 7. Let trapResultArray be ? Call(trap, handler, « target »). + 8. Let trapResult be ? CreateListFromArrayLike(trapResultArray, « String, Symbol »). + [...] + 23. Return trapResult. +includes: [compareArray.js] +features: [Symbol, Proxy, Reflect] +---*/ + +var trapResult = [Symbol(), "length", "foo", "0"]; +var target = new Proxy([], { + ownKeys: function(_target) { + return trapResult; + }, +}); + +var proxy = new Proxy(target, { + ownKeys: undefined, +}); + +assert.compareArray(Reflect.ownKeys(proxy), trapResult);