From 9b127c190cd418b2451c556784aae3d0ac7e9bcf Mon Sep 17 00:00:00 2001 From: Chengzhong Wu Date: Tue, 13 May 2025 10:36:26 +0100 Subject: [PATCH] Fixup incorrect assertion in AsyncGenerator.p.return with broken promises --- .../return-state-completed-broken-promise.js | 28 +++++++++++-------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/test/built-ins/AsyncGeneratorPrototype/return/return-state-completed-broken-promise.js b/test/built-ins/AsyncGeneratorPrototype/return/return-state-completed-broken-promise.js index ca3f605185..2afb11b69b 100644 --- a/test/built-ins/AsyncGeneratorPrototype/return/return-state-completed-broken-promise.js +++ b/test/built-ins/AsyncGeneratorPrototype/return/return-state-completed-broken-promise.js @@ -46,17 +46,21 @@ Object.defineProperty(brokenPromise, 'constructor', { } }); -it.next(); -it.return(brokenPromise) - .then( - () => { - throw new Test262Error("Expected rejection"); - }, - err => { - assert(unblocked, false, 'return should be rejected before generator is resumed'); - assert.sameValue(err.message, 'broken promise'); - } - ) - .then($DONE, $DONE); +it.next().then(function(result) { + assert.sameValue(result.value, undefined); + assert.sameValue(result.done, true); + + it.return(brokenPromise) + .then( + () => { + throw new Test262Error("Expected rejection"); + }, + err => { + assert(unblocked, 'return should be rejected when the generator is completed'); + assert.sameValue(err.message, 'broken promise'); + } + ) + .then($DONE, $DONE); +}); unblock();