Gracefully handle nullish arguments in harness/compareArray

This commit is contained in:
Alexey Shvayka 2020-08-31 21:45:36 +03:00 committed by Rick Waldron
parent 24c6732806
commit 9e75c60028
2 changed files with 32 additions and 2 deletions

View File

@ -30,10 +30,12 @@ compareArray.format = function(array) {
return `[${array.map(String).join(', ')}]`;
};
assert.compareArray = function(actual, expected, message) {
assert.compareArray = function(actual, expected, message = '') {
assert(actual != null, `First argument shouldn't be nullish. ${message}`);
assert(expected != null, `Second argument shouldn't be nullish. ${message}`);
var format = compareArray.format;
assert(
compareArray(actual, expected),
`Expected ${format(actual)} and ${format(expected)} to have the same contents. ${(message || '')}`
`Expected ${format(actual)} and ${format(expected)} to have the same contents. ${message}`
);
};

View File

@ -0,0 +1,28 @@
// Copyright (C) 2020 Alexey Shvayka. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
description: >
compareArray gracefully handles nullish arguments.
includes: [compareArray.js]
---*/
function assertThrows(func, errorMessage) {
var caught = false;
try {
func();
} catch (error) {
caught = true;
assert.sameValue(error.constructor, Test262Error);
assert.sameValue(error.message, errorMessage);
}
assert(caught, `Expected ${func} to throw, but it didn't.`);
}
assertThrows(() => assert.compareArray(), "First argument shouldn't be nullish. ");
assertThrows(() => assert.compareArray(null, []), "First argument shouldn't be nullish. ");
assertThrows(() => assert.compareArray(null, [], "foo"), "First argument shouldn't be nullish. foo");
assertThrows(() => assert.compareArray([]), "Second argument shouldn't be nullish. ");
assertThrows(() => assert.compareArray([], undefined, "foo"), "Second argument shouldn't be nullish. foo");