From 6376e4d8337712d45160cad74a15f1e950250940 Mon Sep 17 00:00:00 2001 From: Mythri Date: Thu, 10 Mar 2016 15:38:33 +0000 Subject: [PATCH 1/3] Removes special handling for UTC timezon in toISOString/15.9.5.43-0-13.js --- test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js b/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js index 5840e5daaa..ecc43d7cf6 100644 --- a/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js +++ b/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js @@ -13,11 +13,6 @@ description: > var date, dateStr; assert.throws(RangeError, function() { - if (timeZoneMinutes > 0) { date = new Date(1970, 0, 100000001, 0, 0 + timeZoneMinutes + 60, 0, 1); dateStr = date.toISOString(); - } else { - date = new Date(1970, 0, 100000001, 0, 0, 0, 1); - dateStr = date.toISOString(); - } }); From 679d02a6ede60d80ff7c187bcbb655531ce9d482 Mon Sep 17 00:00:00 2001 From: Mythri Date: Mon, 25 Apr 2016 15:43:55 +0100 Subject: [PATCH 2/3] Fixed comments --- .../Date/prototype/toISOString/15.9.5.43-0-13.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js b/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js index ecc43d7cf6..8d534c6a01 100644 --- a/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js +++ b/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js @@ -5,14 +5,14 @@ es5id: 15.9.5.43-0-13 description: > Date.prototype.toISOString - RangeError is thrown when value of - date is Date(1970, 0, 100000001, 0, 0, 0, 1), the time zone is - UTC(0) + date is outside the valid range of time. ---*/ - var timeZoneMinutes = new Date().getTimezoneOffset() * (-1); var date, dateStr; assert.throws(RangeError, function() { - date = new Date(1970, 0, 100000001, 0, 0 + timeZoneMinutes + 60, 0, 1); + // As specified in ES5 15.9.1.14, time > 8.64e15 is not in the + // valid range. + date = new Date(8.64e15 + 1); dateStr = date.toISOString(); }); From 664ec78fccb5dfa7f346f82a7194f0e357416b10 Mon Sep 17 00:00:00 2001 From: Mythri Date: Mon, 25 Apr 2016 16:45:03 +0100 Subject: [PATCH 3/3] Moves Date constructor outside of assert, so that it actually tests toISOString --- .../Date/prototype/toISOString/15.9.5.43-0-13.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js b/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js index 8d534c6a01..e1845b0d77 100644 --- a/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js +++ b/test/built-ins/Date/prototype/toISOString/15.9.5.43-0-13.js @@ -8,11 +8,8 @@ description: > date is outside the valid range of time. ---*/ - var date, dateStr; - + // As specified in ES5 15.9.1.14, time > 8.64e15 is not in the valid range. + var date = new Date(8.64e15 + 1); assert.throws(RangeError, function() { - // As specified in ES5 15.9.1.14, time > 8.64e15 is not in the - // valid range. - date = new Date(8.64e15 + 1); - dateStr = date.toISOString(); + date.toISOString(); });