From a6834093aa27c24250f92676e86ac3379e428816 Mon Sep 17 00:00:00 2001 From: Mike Pennisi Date: Tue, 5 Oct 2021 14:15:19 -0400 Subject: [PATCH] Improve coverage by invoking functions as intended Some tests which include function declarations designed to verify behavior do not reference those functions. Insert the references necessary for those functions to serve their intended purpose. --- .../computed-property-name-from-yield-expression.case | 2 ++ test/built-ins/Array/prototype/reduce/15.4.4.21-9-8.js | 2 +- test/built-ins/Array/prototype/reduceRight/15.4.4.22-9-8.js | 6 ++++-- test/language/expressions/await/await-throws-rejections.js | 2 ++ ...ccessors-computed-property-name-from-yield-expression.js | 2 ++ ...ass-expr-computed-property-name-from-yield-expression.js | 2 ++ ...r-fields-computed-property-name-from-yield-expression.js | 2 ++ ...-methods-computed-property-name-from-yield-expression.js | 2 ++ ...-obj-lit-computed-property-name-from-yield-expression.js | 2 ++ ...ccessors-computed-property-name-from-yield-expression.js | 2 ++ ...ass-decl-computed-property-name-from-yield-expression.js | 2 ++ ...l-fields-computed-property-name-from-yield-expression.js | 2 ++ ...-methods-computed-property-name-from-yield-expression.js | 2 ++ 13 files changed, 27 insertions(+), 3 deletions(-) diff --git a/src/computed-property-names/computed-property-name-from-yield-expression.case b/src/computed-property-names/computed-property-name-from-yield-expression.case index d6cde1031b..50173be0a1 100644 --- a/src/computed-property-names/computed-property-name-from-yield-expression.case +++ b/src/computed-property-names/computed-property-name-from-yield-expression.case @@ -15,3 +15,5 @@ yield 9 9 //- teardown } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/built-ins/Array/prototype/reduce/15.4.4.21-9-8.js b/test/built-ins/Array/prototype/reduce/15.4.4.21-9-8.js index 8cd610cd4b..a9179cbc6f 100644 --- a/test/built-ins/Array/prototype/reduce/15.4.4.21-9-8.js +++ b/test/built-ins/Array/prototype/reduce/15.4.4.21-9-8.js @@ -25,7 +25,7 @@ Object.defineProperty(obj, "0", { configurable: true }); -Array.prototype.reduce.call(obj, function() {}, "initialValue"); +Array.prototype.reduce.call(obj, callbackfn, "initialValue"); assert.sameValue(accessed, false, 'accessed'); assert.sameValue(callbackAccessed, false, 'callbackAccessed'); diff --git a/test/built-ins/Array/prototype/reduceRight/15.4.4.22-9-8.js b/test/built-ins/Array/prototype/reduceRight/15.4.4.22-9-8.js index 22fd673682..155e813783 100644 --- a/test/built-ins/Array/prototype/reduceRight/15.4.4.22-9-8.js +++ b/test/built-ins/Array/prototype/reduceRight/15.4.4.22-9-8.js @@ -9,9 +9,10 @@ description: > ---*/ var accessed = false; +var callbackAccessed = false; function callbackfn() { - accessed = true; + callbackAccessed = true; } var obj = { @@ -26,6 +27,7 @@ Object.defineProperty(obj, "5", { configurable: true }); -Array.prototype.reduceRight.call(obj, function() {}, "initialValue"); +Array.prototype.reduceRight.call(obj, callbackfn, "initialValue"); assert.sameValue(accessed, false, 'accessed'); +assert.sameValue(callbackAccessed, false, 'callbackAccessed'); diff --git a/test/language/expressions/await/await-throws-rejections.js b/test/language/expressions/await/await-throws-rejections.js index 1be6084076..82229be0bb 100644 --- a/test/language/expressions/await/await-throws-rejections.js +++ b/test/language/expressions/await/await-throws-rejections.js @@ -6,6 +6,7 @@ author: Brian Terlson esid: pending description: > Await throws errors from rejected promises +flags: [async] ---*/ async function foo() { @@ -21,3 +22,4 @@ async function foo() { assert(caught); } +foo().then($DONE, $DONE); diff --git a/test/language/expressions/class/cpn-class-expr-accessors-computed-property-name-from-yield-expression.js b/test/language/expressions/class/cpn-class-expr-accessors-computed-property-name-from-yield-expression.js index cbc3617116..90621a9769 100644 --- a/test/language/expressions/class/cpn-class-expr-accessors-computed-property-name-from-yield-expression.js +++ b/test/language/expressions/class/cpn-class-expr-accessors-computed-property-name-from-yield-expression.js @@ -92,3 +92,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/language/expressions/class/cpn-class-expr-computed-property-name-from-yield-expression.js b/test/language/expressions/class/cpn-class-expr-computed-property-name-from-yield-expression.js index 1bc3ff3ee5..56f1f79f6c 100644 --- a/test/language/expressions/class/cpn-class-expr-computed-property-name-from-yield-expression.js +++ b/test/language/expressions/class/cpn-class-expr-computed-property-name-from-yield-expression.js @@ -65,3 +65,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/language/expressions/class/cpn-class-expr-fields-computed-property-name-from-yield-expression.js b/test/language/expressions/class/cpn-class-expr-fields-computed-property-name-from-yield-expression.js index da7f440347..66cde7a2c4 100644 --- a/test/language/expressions/class/cpn-class-expr-fields-computed-property-name-from-yield-expression.js +++ b/test/language/expressions/class/cpn-class-expr-fields-computed-property-name-from-yield-expression.js @@ -62,3 +62,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/language/expressions/class/cpn-class-expr-fields-methods-computed-property-name-from-yield-expression.js b/test/language/expressions/class/cpn-class-expr-fields-methods-computed-property-name-from-yield-expression.js index 549bc40807..47da791124 100644 --- a/test/language/expressions/class/cpn-class-expr-fields-methods-computed-property-name-from-yield-expression.js +++ b/test/language/expressions/class/cpn-class-expr-fields-methods-computed-property-name-from-yield-expression.js @@ -66,3 +66,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/language/expressions/object/cpn-obj-lit-computed-property-name-from-yield-expression.js b/test/language/expressions/object/cpn-obj-lit-computed-property-name-from-yield-expression.js index f71300ea42..fe87711c53 100644 --- a/test/language/expressions/object/cpn-obj-lit-computed-property-name-from-yield-expression.js +++ b/test/language/expressions/object/cpn-obj-lit-computed-property-name-from-yield-expression.js @@ -39,3 +39,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/language/statements/class/cpn-class-decl-accessors-computed-property-name-from-yield-expression.js b/test/language/statements/class/cpn-class-decl-accessors-computed-property-name-from-yield-expression.js index c422d0d156..a746fe6fb4 100644 --- a/test/language/statements/class/cpn-class-decl-accessors-computed-property-name-from-yield-expression.js +++ b/test/language/statements/class/cpn-class-decl-accessors-computed-property-name-from-yield-expression.js @@ -92,3 +92,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/language/statements/class/cpn-class-decl-computed-property-name-from-yield-expression.js b/test/language/statements/class/cpn-class-decl-computed-property-name-from-yield-expression.js index b40e1233a3..f258177ba6 100644 --- a/test/language/statements/class/cpn-class-decl-computed-property-name-from-yield-expression.js +++ b/test/language/statements/class/cpn-class-decl-computed-property-name-from-yield-expression.js @@ -65,3 +65,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/language/statements/class/cpn-class-decl-fields-computed-property-name-from-yield-expression.js b/test/language/statements/class/cpn-class-decl-fields-computed-property-name-from-yield-expression.js index 959fe3bb2d..626aa65db5 100644 --- a/test/language/statements/class/cpn-class-decl-fields-computed-property-name-from-yield-expression.js +++ b/test/language/statements/class/cpn-class-decl-fields-computed-property-name-from-yield-expression.js @@ -62,3 +62,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ; diff --git a/test/language/statements/class/cpn-class-decl-fields-methods-computed-property-name-from-yield-expression.js b/test/language/statements/class/cpn-class-decl-fields-methods-computed-property-name-from-yield-expression.js index f82437411b..4b5cca9bf8 100644 --- a/test/language/statements/class/cpn-class-decl-fields-methods-computed-property-name-from-yield-expression.js +++ b/test/language/statements/class/cpn-class-decl-fields-methods-computed-property-name-from-yield-expression.js @@ -66,3 +66,5 @@ assert.sameValue( ); } +var iter = g(); +while (iter.next().done === false) ;