mirror of
https://github.com/tc39/test262.git
synced 2025-07-19 03:54:36 +02:00
Apply suggestions from code review
Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
This commit is contained in:
parent
97477ad1f6
commit
ac098dbe6a
@ -12,7 +12,7 @@ examples of tests which contradict the preferred patterns.
|
|||||||
|
|
||||||
For instance:
|
For instance:
|
||||||
|
|
||||||
- tests which expression expectations with `throw` statements inside of
|
- tests which express expectations with `throw` statements inside of
|
||||||
conditional statements rather than the assertion API implemented by the
|
conditional statements rather than the assertion API implemented by the
|
||||||
harness files (though this explicitness will always be desirable when
|
harness files (though this explicitness will always be desirable when
|
||||||
asserting the semantics of conditional statements and `throw` statements
|
asserting the semantics of conditional statements and `throw` statements
|
||||||
@ -124,7 +124,7 @@ would not necessarily accept such a test.
|
|||||||
## Large tests
|
## Large tests
|
||||||
|
|
||||||
Test262 tests are typically very focused. The vast majority exercise just one
|
Test262 tests are typically very focused. The vast majority exercise just one
|
||||||
algorithm step/grammar production, and some are even more granular that that!
|
algorithm step/grammar production, and some are even more granular than that!
|
||||||
|
|
||||||
Some test contributors are uncomfortable splitting their work across files like
|
Some test contributors are uncomfortable splitting their work across files like
|
||||||
this. It's certainly unlike the practices that are common in modern application
|
this. It's certainly unlike the practices that are common in modern application
|
||||||
|
Loading…
x
Reference in New Issue
Block a user