From ac4d02d77adcb9dc05dc3e7b4ffb15eb484ee6f5 Mon Sep 17 00:00:00 2001 From: Alexey Shvayka Date: Wed, 10 Jun 2020 21:29:02 +0300 Subject: [PATCH] Fix Promise.prototype.finally test --- .../rejected-observable-then-calls-argument.js | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/test/built-ins/Promise/prototype/finally/rejected-observable-then-calls-argument.js b/test/built-ins/Promise/prototype/finally/rejected-observable-then-calls-argument.js index 42ef3f81fd..a55f69c087 100644 --- a/test/built-ins/Promise/prototype/finally/rejected-observable-then-calls-argument.js +++ b/test/built-ins/Promise/prototype/finally/rejected-observable-then-calls-argument.js @@ -17,9 +17,19 @@ includes: [isConstructor.js] flags: [async] ---*/ -Promise.reject(new Test262Error()) +class MyError extends Error {} + +Promise.reject(new MyError()) .finally(function() {}) - .then($DONE, () => $DONE()); + .then(function(value) { + $DONE('Expected promise to be rejected, got fulfilled with ' + value); + }, function(reason) { + if (reason instanceof MyError) { + $DONE(); + } else { + $DONE(reason); + } + }); var calls = 0; var expected = [ @@ -33,7 +43,7 @@ Promise.prototype.then = function(resolve, reject) { assert.sameValue(resolve.length, expected[calls].length); assert.sameValue(resolve.name, expected[calls].name); if (calls === 0) { - assert.throws(Test262Error, resolve); + assert.throws(MyError, resolve); } calls += 1;