tyler.durden
/
test262
mirror of https://github.com/tc39/test262.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Lint: use Python urlparse to verify esid fragment correctness

This commit is contained in:
Rick Waldron 2018-06-19 15:57:04 -04:00
parent 90c667afd1
commit ae3493a409
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/lint/lib/checks/esid.py
View File

@ -1,4 +1,5 @@
from ..check import Check from ..check import Check
from urlparse import urlparse
import re import re
class CheckEsid(Check): class CheckEsid(Check):
@ -8,7 +9,6 @@ class CheckEsid(Check):
def __init__(self): def __init__(self):
#self.es5idRegex = re.compile(r"^S?(B|\d+)(\.\d+)+(-(\d+|[a-z]|i+))*(_A\d(\.\d+)?(_T\d(\.\d+)?)?)?$") #self.es5idRegex = re.compile(r"^S?(B|\d+)(\.\d+)+(-(\d+|[a-z]|i+))*(_A\d(\.\d+)?(_T\d(\.\d+)?)?)?$")
self.es6idRegex = re.compile(r"^(S?(B|\d+)(\.\d+)+(((_A\d\.\d)?_T?\d)|[ _]S\d+(\.[a-z])*)?(, |$))+") self.es6idRegex = re.compile(r"^(S?(B|\d+)(\.\d+)+(((_A\d\.\d)?_T?\d)|[ _]S\d+(\.[a-z])*)?(, |$))+")
self.esidRegex = re.compile(r"^(pending|(prod|sec|sup)-[-_A-Za-z0-9.%@]+)$")
def run(self, name, meta, source): def run(self, name, meta, source):
if not meta: if not meta:
@ -30,7 +30,7 @@ class CheckEsid(Check):
if 'esid' in meta: if 'esid' in meta:
esid = str(meta['esid']) esid = str(meta['esid'])
if self.esidRegex.match(esid) == None: parsed = urlparse('#%s' % esid)
if parsed.fragment != esid:
return 'The `esid` tag has the wrong format: %s' % esid return 'The `esid` tag has the wrong format: %s' % esid

9
tools/lint/test/fixtures/valid_esid_url_fragment.js vendored Normal file
View File

@ -0,0 +1,9 @@
^ expected errors | v input
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: any!thing$goes&-?
description: Minimal test
---*/
function f() {}