From b2f1d9bb4f7cced7a18f35015762862e5f612a3f Mon Sep 17 00:00:00 2001 From: Kubilay Kahveci Date: Fri, 23 Aug 2019 13:50:16 +0100 Subject: [PATCH] Add tests covering static private methods used from instance methods and vice versa --- ...-method-referenced-from-static-method.case | 34 +++++++++++++++++++ ...ethod-referenced-from-instance-method.case | 34 +++++++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 src/class-elements/private-method-referenced-from-static-method.case create mode 100644 src/class-elements/static-private-method-referenced-from-instance-method.case diff --git a/src/class-elements/private-method-referenced-from-static-method.case b/src/class-elements/private-method-referenced-from-static-method.case new file mode 100644 index 0000000000..60cb79218e --- /dev/null +++ b/src/class-elements/private-method-referenced-from-static-method.case @@ -0,0 +1,34 @@ +// Copyright (C) 2019 Kubilay Kahveci (Bloomberg LP). All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +desc: Private method referenced from a static method +info: | + PrivateFieldGet (P, O) + 1. Assert: P is a Private Name. + 2. If O is not an object, throw a TypeError exception. + 3. If P.[[Kind]] is "field", + ... + 4. Perform ? PrivateBrandCheck(O, P). + 5. If P.[[Kind]] is "method", + a. Return P.[[Value]]. + ... + + PrivateBrandCheck(O, P) + 1. If O.[[PrivateBrands]] does not contain an entry e such that SameValue(e, P.[[Brand]]) is true, + a. Throw a TypeError exception. +template: default +features: [class-static-methods-private] +---*/ + +//- elements +#f() { return 42; } +static g() { + return this.#f(); +} + +//- assertions +assert.sameValue(C.g.call(new C()), 42); +assert.throws(TypeError, function() { + C.g(); +}, 'Accessed private method from an object which did not contain it'); diff --git a/src/class-elements/static-private-method-referenced-from-instance-method.case b/src/class-elements/static-private-method-referenced-from-instance-method.case new file mode 100644 index 0000000000..af56aa8aa8 --- /dev/null +++ b/src/class-elements/static-private-method-referenced-from-instance-method.case @@ -0,0 +1,34 @@ +// Copyright (C) 2019 Kubilay Kahveci (Bloomberg LP). All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +desc: Static private method referenced from an instance method +info: | + PrivateFieldGet (P, O) + 1. Assert: P is a Private Name. + 2. If O is not an object, throw a TypeError exception. + 3. If P.[[Kind]] is "field", + ... + 4. Perform ? PrivateBrandCheck(O, P). + 5. If P.[[Kind]] is "method", + a. Return P.[[Value]]. + ... + + PrivateBrandCheck(O, P) + 1. If O.[[PrivateBrands]] does not contain an entry e such that SameValue(e, P.[[Brand]]) is true, + a. Throw a TypeError exception. +template: default +features: [class-static-methods-private] +---*/ + +//- elements +static #f() { return 42; } +g() { + return this.#f(); +} + +//- assertions +assert.sameValue(new C().g.call(C), 42); +assert.throws(TypeError, function() { + new C().g(); +}, 'Accessed static private method from an object which did not contain it');